Inserting value into database

Question

1.00/5 (1 vote)

See more:

VS2010

I wanted to insert values into database but it is not working eventhough my code perfectly working when its used as stored procedure. I am trieng to use button click to store the value. Please tell whats wrong with the code. Its not showing any error or exception but data is not getting updated in the table.

C#

protected void Button1_Click(object sender, EventArgs e)
{
        SqlConnection sqlConnection1 = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
        SqlCommand cmd = new SqlCommand();

        cmd.CommandText = "INSERT INTO sales(acnum, scripname, shares_bought) VALUES ('12', 'abcd', '20')";
        cmd.CommandType = CommandType.Text;
        cmd.Connection = sqlConnection1;
        sqlConnection1.Open();

        cmd.ExecuteNonQuery();
        sqlConnection1.Close();                                
}

Posted 10-Sep-15 3:31am

Member 11949886

Updated 10-Sep-15 4:05am

Thanks7872

v2

Add a Solution

Comments

ZurdoDev 10-Sep-15 9:39am

You're probably pointing to a different database. Just debug the code and see what ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString is.

Member 11949886 11-Sep-15 1:42am

its allright sir, I checked

ZurdoDev 11-Sep-15 7:08am

Then if there is no error the insert is happening.

Maciej Los 10-Sep-15 15:47pm

Does acnum and shares_bought is numeric data field?

Member 11949886 11-Sep-15 1:38am

yes sir

Member 11949886 11-Sep-15 1:39am

but i tried without single quotes also... still same problem

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2015-09-11T08:47:00

It's strongly recommended to use SqlParametersCollection.Add[^] method to create new SqlCommand[^]. Optionally, you can use SqlParametersCollection.AddWithValue method[^].

C#

string commandText = "INSERT INTO sales(acnum, scripname, shares_bought) VALUES (@acnum, @scripname, @sbought)";
using (SqlConnection connection = new SqlConnection(connectionString))
{
    SqlCommand command = new SqlCommand(commandText, connection);
    command.Parameters.AddWithValue("@acnum", 12);
    command.Parameters.AddWithValue("@scripname", "abcd");
    command.Parameters.AddWithValue("@sbought", 20);

    try
    {
        connection.Open();
        Int32 rowsAffected = command.ExecuteNonQuery();
        Console.WriteLine("RowsAffected: {0}", rowsAffected);
    }
    catch (Exception ex)
    {
        Console.WriteLine(ex.Message);
    }
}