Exit a thread in c# (see details)

Question

1.00/5 (1 vote)

See more:

As the title of the question says, I want to kill a thread from the same application that started it.

But... the thread is created this way:
new Thread => {...}).Start();
It works good, until I close my application and a MyApplication.exe stopped working messageBox shows because the thread has not been killed.

So, I am asking what is the correct way to close a thread started in that way.
Note: I tried using the currentThread.Abort(); and did not work.

Code Sample(of how the thread is started and what it does):

C#

private void btnListen_Click(object sender, EventArgs e)
       {
           server.Start(); // Starts Listening to Any IPAddress trying to connect to the program with port 1980
           MessageBox.Show("Waiting For Connection");
           new Thread(() => // Creates a New Thread (like a timer)
               {
                   client = server.AcceptTcpClient(); //Waits for the Client To Connect
                   MessageBox.Show("Connected To Client");
                   if (client.Connected) // If you are connected
                   {
                       ServerReceive(); //Start Receiving
                   }
               }).Start();
       }

Thanks in advance. CCB

Posted 1-Aug-15 17:24pm

ChrisCreateBoss

Updated 1-Aug-15 18:57pm

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 1-Aug-15 23:42pm

It does work, and should be used with care and full understanding of what you are doing. Most people recommend cooperative thread exit, but in many cases this is lame, in others simply not acceptable.
—SA

ChrisCreateBoss 2-Aug-15 0:06am

So what do you suggest me to do?

Sergey Alexandrovich Kryukov 2-Aug-15 0:29am

Create as short code sample as possible, but it should be comprehensive, just enough to demonstrate only one problem. Use "Improve question" to add it.
—SA

ChrisCreateBoss 2-Aug-15 0:57am

Done. See the code.

Sergey Alexandrovich Kryukov 2-Aug-15 7:08am

You did not even try to exist thread method, or abort thread, or anything. To abort thread, you have to have a named thread, to call myThread.Abort from some other thread. Thread.Abort has nothing to do with unsafe Windows TerminateThread. There is a wide class of problems where you cannot do "graceful" thread termination, and a wide class of problems where "graceful" termination is just silly. :-)
—SA

ChrisCreateBoss 2-Aug-15 14:33pm

Yes now I see. :) Thanks

Sergey Alexandrovich Kryukov 2-Aug-15 15:35pm

Sure.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-08-01T19:36:00

Set the Thread IsBackground[^] property to true before you start it: threads marked in this way are automatically killed by the framework when your application exits.
If you don't, they need to terminate themselves when the rest of the app closes (this is to give a "graceful" way for the thread to shut down tidily)

"Where do I set that bool in my code? See that my thread has not been named."

You're kidding, right? :laugh:

C#

Thread t = new Thread(() => // Creates a New Thread (like a timer)
    {
        client = server.AcceptTcpClient(); //Waits for the Client To Connect
        MessageBox.Show("Connected To Client");
        if (client.Connected) // If you are connected
        {
            ServerReceive(); //Start Receiving
        }
    });
t.IsBackground = true;
t.Start();