C / C++ / MFC

14-Oct-04 14:04

Hello, I'm creating a program that displays a menu to the user and gives the user the option to open the following programs:
1. Freecell
2. Minesweeper
3. Paint
4. Quit
It does open the programs correctly but when the user enters 4 for quit, I want my program to close all of the programs the user opened. I am not sure how to do that though. I have created a function called ExitProcess and have a call to it when the user enters 4 as their choice. There is no code in that function.

Here is most of the code:

#include <iostream.h><br />
#include <windows.h><br />
#include <string.h><br />
#include <stdio.h><br />
<br />
void DisplayMenu();<br />
void CreateProcess(int option);<br />
void ExitProcess(void);<br />
// Main<br />
void main()<br />
{<br />
	DisplayMenu();<br />
<br />
	return;<br />
}<br />
<br />
void DisplayMenu()<br />
{<br />
	int option;<br />
<br />
        //MENU IS DISPLAYED HERE<br />
<br />
	cout << "\n\nPlease type your choice "<br />
		 << "and press the return key : ";<br />
<br />
	cin >> option;<br />
	CreateProcess(option);<br />
<br />
	return;<br />
}<br />
<br />
void CreateProcess(int option)<br />
{<br />
	STARTUPINFO si;<br />
	PROCESS_INFORMATION pi;	<br />
<br />
	ZeroMemory( &si, sizeof(si) );<br />
	si.cb = sizeof(si);	<br />
	ZeroMemory( &pi, sizeof(pi) );	<br />
<br />
	switch (option)<br />
	{<br />
	case 1 : if( !CreateProcess( NULL, 				<br />
		"C://FreeCell.exe",NULL,NULL,FALSE,NULL,NULL,NULL,&si,&pi)) <br />
				{<br />
					ExitProcess(1);<br />
				}		<br />
		system("cls");<br />
		DisplayMenu();<br />
	<br />
		break; <br />
<br />
	case 2 : if( !CreateProcess( NULL, 				<br />
		"winmine.exe",NULL,NULL,FALSE,NULL,NULL,NULL,&si,&pi))             					 <br />
				{<br />
					ExitProcess(1);<br />
				}		<br />
		system("cls");<br />
		DisplayMenu();<br />
<br />
		break;<br />
<br />
	case 3 : if( !CreateProcess( NULL, 				<br />
		"MsPaint.exe",NULL,NULL,FALSE, NULL,NULL,NULL,&si,&pi ))           					<br />
			   	{<br />
					ExitProcess(1);<br />
				}		<br />
	<br />
		system("cls");<br />
		DisplayMenu();<br />
	<br />
		break;<br />
<br />
	<br />
<br />
	case 4 : WaitForSingleObject( pi.hProcess, INFINITE );<br />
		ExitProcess();<br />
		CloseHandle( pi.hProcess );<br />
		CloseHandle( pi.hThread );<br />
	<br />
		exit(100);<br />
		<br />
		break;<br />
	<br />
<br />
	default : cout << "\a\aOption Not Available\n";<br />
	system("cls");<br />
	DisplayMenu();<br />
	}<br />
<br />
return;<br />
}<br />
void ExitProcess(void)<br />
{<br />
<br />
}

Andrzej Markowski14-Oct-04 16:05

14-Oct-04 16:05

Send WM_QUIT message to each running application.

PROCESS_INFORMATION pi[3]; // for each process
STARTUPINFO si[3];
// init structures
ZeroMemory( &si[0], sizeof(si[0]) );
si.cb = sizeof(si[0]); 
ZeroMemory( &pi[0], sizeof(pi[0]) ); 

ZeroMemory( &si[1], sizeof(si[1]) );
si.cb = sizeof(si[1]); 
ZeroMemory( &pi[1], sizeof(pi[1]) ); 

ZeroMemory( &si[2], sizeof(si[2]) );
si.cb = sizeof(si[2]); 
ZeroMemory( &pi[2], sizeof(pi[2]) ); 

// start appications
if(pi[0].hProcess==NULL)
CreateProcess( NULL, "C://FreeCell.exe",NULL,NULL,FALSE,NULL,NULL,NULL,&si[0],&pi[0]));
if(pi[1].hProcess==NULL)
CreateProcess( NULL, "winmine.exe",NULL,NULL,FALSE,NULL,NULL,NULL,&si[1],&pi[1]);
if(pi[2].hProcess==NULL)
CreateProcess( NULL, "MsPaint.exe",NULL,NULL,FALSE, NULL,NULL,NULL,&si[2],&pi[2]);

// shutdown applications
if(pi[0].hProcess)
::PostThreadMessage(pi[0].dwThreadId,WM_QUIT,0,0);
if(pi[1].hProcess)
::PostThreadMessage(pi[1].dwThreadId,WM_QUIT,0,0);
if(pi[2].hProcess)
::PostThreadMessage(pi[2].dwThreadId,WM_QUIT,0,0);

CloseHandle( pi[0].hProcess );
CloseHandle( pi[0].hThread );
CloseHandle( pi[1].hProcess );
CloseHandle( pi[1].hThread );
CloseHandle( pi[2].hProcess );
CloseHandle( pi[2].hThread );

Regards,
Andrzej Markowski

My Latest ArticlesCCustomBitmapButton: An owner-draw button and a frame for the caption bar, in one class.
CCustomTabCtrl: A clone of the Excel tab sheet control.

vikramlinux14-Oct-04 19:22

vikramlinux

14-Oct-04 19:22

Enumerate All Windows on specified thread. Post WM_CLOSE to them , in order to close the application in safe manner.Later u may call terminateprocess API

Moochie515-Oct-04 6:27

15-Oct-04 6:27

Thanks for the reply.
I am getting an 3 errors which say "left of .cb must have class/struct/union type".

This is the part of the code it is giving those errors:

<br />
PROCESS_INFORMATION pi[3]; // for each process<br />
STARTUPINFO si[3];// init structures<br />
ZeroMemory( &si[0], sizeof(si[0]) );<br />
//HERE si.cb = sizeof(si[0]); <br />
ZeroMemory( &pi[0], sizeof(pi[0]) ); <br />
ZeroMemory( &si[1], sizeof(si[1]) );<br />
//HERE si.cb = sizeof(si[1]); <br />
ZeroMemory( &pi[1], sizeof(pi[1]) ); <br />
ZeroMemory( &si[2], sizeof(si[2]) );<br />
//HERE si.cb = sizeof(si[2]);

Andrzej Markowski15-Oct-04 7:04

15-Oct-04 7:04

Change the code like this:

PROCESS_INFORMATION pi[3]; // for each process<br />
STARTUPINFO si[3];// init structures<br />
ZeroMemory( &si[0], sizeof(STARTUPINFO));<br />
si[0].cb = sizeof(STARTUPINFO); <br />
ZeroMemory( &pi[0], sizeof(PROCESS_INFORMATION)); <br />
ZeroMemory( &si[1], sizeof(STARTUPINFO));<br />
si[1].cb = sizeof(STARTUPINFO); <br />
ZeroMemory( &pi[1], sizeof(PROCESS_INFORMATION)); <br />
ZeroMemory( &si[2], sizeof(STARTUPINFO));<br />
si[2].cb = sizeof(STARTUPINFO); <br />
ZeroMemory( &pi[2], sizeof(PROCESS_INFORMATION));

Regards,
Andrzej Markowski

My Latest ArticlesCCustomBitmapButton: An owner-draw button and a frame for the caption bar, in one class.
CCustomTabCtrl: A clone of the Excel tab sheet control.

Moochie515-Oct-04 8:14

15-Oct-04 8:14

Thanks for the help Andrzej
I have configured the code as shown below: Including a couple of functions. The program builds with 0 errors and 0 warnings, but for some reason when I enter a choice like (1) for "Freecell", my program quits, the program that I have opened remains open, so I do not have the chance to quit the Freecell program. Not sure why it is not giving me another choice:

#include <iostream.h><br />
#include <windows.h><br />
#include <string.h><br />
#include <stdio.h><br />
<br />
void DisplayMenu();<br />
void process(int option);<br />
<br />
<br />
void main()<br />
{<br />
	DisplayMenu();<br />
	return;<br />
}<br />
<br />
void DisplayMenu()<br />
{<br />
	int option;<br />
<br />
	cout << "\n\n\n";<br />
	cout << "\n\t*********************************";<br />
	cout << "\n\t*				*";<br />
	cout << "\n\t*	MENU			*";<br />
	cout << "\n\t*			  	*";<br />
	cout << "\n\t*	1. FreeCell		*";<br />
	cout << "\n\t*	2. MineSweeper		*";<br />
	cout << "\n\t*	3. Paint		*";<br />
	cout << "\n\t*	4. Quit			*";<br />
	cout << "\n\t*			  	*";<br />
	cout << "\n\t*********************************";<br />
<br />
	cout << "\n\nPlease type your choice "<br />
		 << "and press the return key : ";<br />
<br />
	cin >> option;<br />
	process(option);<br />
<br />
	return;<br />
}<br />
<br />
void process(int option)<br />
{<br />
	<br />
	STARTUPINFO si[3];<br />
	PROCESS_INFORMATION pi[3];	<br />
	int i=0;<br />
	<br />
	ZeroMemory( &si[0], sizeof(si[0]) );<br />
	si[0].cb = sizeof(si[0]); <br />
	ZeroMemory( &pi[0], sizeof(pi[0]) ); <br />
<br />
	ZeroMemory( &si[1], sizeof(si[1]) );<br />
	si[1].cb = sizeof(si[1]); <br />
	ZeroMemory( &pi[1], sizeof(pi[1]) ); <br />
<br />
	ZeroMemory( &si[2], sizeof(si[2]) );<br />
	si[2].cb = sizeof(si[2]); <br />
	ZeroMemory( &pi[2], sizeof(pi[2]) ); <br />
<br />
	switch (option)<br />
	{<br />
	case 1 : if(pi[0].hProcess==NULL)CreateProcess( NULL, 				 <br />
		"FreeCell.exe", 						 <br />
		    NULL,             					 <br />
			NULL,             					<br />
			FALSE,            					<br />
			NULL,							 <br />
			NULL,            					 <br />
			NULL,             					 <br />
			&si[0],              					<br />
			&pi[0]);             					<br />
		  <br />
				{<br />
					ExitProcess(1);<br />
				}		<br />
	<br />
	<br />
		system("cls");<br />
		DisplayMenu();<br />
	<br />
		break; <br />
<br />
	case 2 : if(pi[1].hProcess==NULL)CreateProcess( NULL, 				<br />
		"winmine.exe", 	<br />
		    NULL,             					<br />
			NULL,             					<br />
			FALSE,            					<br />
			NULL,								<br />
			NULL,            					<br />
			NULL,             					<br />
			&si[1],              					<br />
			&pi[1]);             					<br />
		  <br />
				{<br />
					ExitProcess(1);<br />
				}		<br />
		<br />
	<br />
		system("cls");<br />
		DisplayMenu();<br />
<br />
		break;<br />
<br />
	case 3 : if(pi[2].hProcess==NULL)CreateProcess( NULL, 			<br />
		"MsPaint.exe", 	// Command line. <br />
		    NULL,             					<br />
			NULL,             					<br />
			FALSE,            					 <br />
			NULL,								 <br />
			NULL,            					 <br />
			NULL,             					<br />
			&si[2],              					<br />
			&pi[2]);             					<br />
		  <br />
				{<br />
					ExitProcess(1);<br />
				}		<br />
	<br />
		system("cls");<br />
		DisplayMenu();<br />
	<br />
		break;<br />
<br />
	<br />
<br />
	case 4 : if(pi[0].hProcess)::PostThreadMessage(pi[0].dwThreadId,WM_QUIT,0,0);<br />
		if(pi[1].hProcess)::PostThreadMessage(pi[1].dwThreadId,WM_QUIT,0,0);<br />
		if(pi[2].hProcess)::PostThreadMessage(pi[2].dwThreadId,WM_QUIT,0,0);<br />
		CloseHandle( pi[0].hProcess );<br />
		CloseHandle( pi[0].hThread );<br />
		CloseHandle( pi[1].hProcess );<br />
		CloseHandle( pi[1].hThread );<br />
		CloseHandle( pi[2].hProcess );<br />
		CloseHandle( pi[2].hThread );<br />
	//	CloseHandle( pi[3].hProcess );<br />
	//	CloseHandle( pi[3].hThread );<br />
		exit(100);<br />
	<br />
		break;<br />
	<br />
	default : printf("\a\aOption Not Available\n");<br />
	system("cls");<br />
	DisplayMenu();<br />
	}<br />
<br />
return;<br />
}

Andrzej Markowski15-Oct-04 9:32

15-Oct-04 9:32

You should declare the arrays (si and pi) as global variables. Also you can't call the DisplayMenu from within the process function (recursion).
Here's an example how to fix these problems:

STARTUPINFO si[3];
PROCESS_INFORMATION pi[3]; 

int DisplayMenu();
void process(int option);

void main()
{
ZeroMemory( &si[0], sizeof(si[0]) );
si[0].cb = sizeof(si[0]); 
ZeroMemory( &pi[0], sizeof(pi[0]) ); 

ZeroMemory( &si[1], sizeof(si[1]) );
si[1].cb = sizeof(si[1]); 
ZeroMemory( &pi[1], sizeof(pi[1]) ); 

ZeroMemory( &si[2], sizeof(si[2]) );
si[2].cb = sizeof(si[2]); 
ZeroMemory( &pi[2], sizeof(pi[2]) ); 

while(DisplayMenu()!=4)
return;
}

int DisplayMenu()
{
int option;
system("cls");
cout << "\n\n\n";
cout << "\n\t*********************************";
cout << "\n\t* *";
cout << "\n\t* MENU *";
cout << "\n\t* *";
cout << "\n\t* 1. FreeCell *";
cout << "\n\t* 2. MineSweeper *";
cout << "\n\t* 3. Paint *";
cout << "\n\t* 4. Quit *";
cout << "\n\t* *";
cout << "\n\t*********************************";

cout << "\n\nPlease type your choice "
<< "and press the return key : ";

cin >> option;
process(option);
return option;
}

void process(int option)
{
switch (option)
{
case 1 : if(pi[0].hProcess==NULL)CreateProcess( NULL, 
"FreeCell.exe", 
NULL, 
NULL, 
FALSE, 
NULL, 
NULL, 
NULL, 
&si[0], 
&pi[0]); 

break; 

case 2 : if(pi[1].hProcess==NULL)CreateProcess( NULL, 
"winmine.exe", 
NULL, 
NULL, 
FALSE, 
NULL, 
NULL, 
NULL, 
&si[1], 
&pi[1]); 

break;

case 3 : if(pi[2].hProcess==NULL)CreateProcess( NULL, 
"MsPaint.exe", // Command line. 
NULL, 
NULL, 
FALSE, 
NULL, 
NULL, 
NULL, 
&si[2], 
&pi[2]); 

break;

case 4 : if(pi[0].hProcess)::PostThreadMessage(pi[0].dwThreadId,WM_QUIT,0,0);
if(pi[1].hProcess)::PostThreadMessage(pi[1].dwThreadId,WM_QUIT,0,0);
if(pi[2].hProcess)::PostThreadMessage(pi[2].dwThreadId,WM_QUIT,0,0);
CloseHandle( pi[0].hProcess );
CloseHandle( pi[0].hThread );
CloseHandle( pi[1].hProcess );
CloseHandle( pi[1].hThread );
CloseHandle( pi[2].hProcess );
CloseHandle( pi[2].hThread );
// CloseHandle( pi[3].hProcess );
// CloseHandle( pi[3].hThread );

break;

default : printf("\a\aOption Not Available\n");
break;
}

return;
}

Regards,
Andrzej Markowski

My Latest ArticlesCCustomBitmapButton: An owner-draw button and a frame for the caption bar, in one class.
CCustomTabCtrl: A clone of the Excel tab sheet control.

Moochie515-Oct-04 10:53

15-Oct-04 10:53

Finally got it!
Thanks for all the help

Moochie516-Oct-04 9:46

16-Oct-04 9:46

Again thanks for the help Andrzej, I have pretty much configured the program to work how I want except for one thing.
I want to be able to open more than one of the same program. So if I open one Paint program I want to be able to enter 3 again for Paint and have it open another. It only lets me open one of each right now.
Is there anyway to work around it? Meaning can I keep the global variables or is that one of the things that is preventing me from opening more than one program?
Thanks again.

Moochie516-Oct-04 10:01

16-Oct-04 10:01

Just want to clarify something...
I know how to be able to open more than one program but I'm not sure how to let the computer keep track of them so it closes them all.
When I do change it to open more than one program and I enter 4 to close them it does not close any of them.

Andrzej Markowski17-Oct-04 11:54

17-Oct-04 11:54

Your program has to save the ThreadId for each new created process. Later the ThreadId is passed as the parameter to the PostThreadMessage function which is called to close the program the user opened. The modified example saves this information in the rp array of RUNNING_PROCESS_INFO structures. The nRPCounter specifies a number of currently running processes and also is the next avaliable index in the rp table. When the process is created a space for the RUNNING_PROCESS_INFO structure is allocated at the and of the array and the nRPCounter is incremented. When the user closes the program the counter is decremented and the structures in the array located below deleted item are moved one item up.

#include stdio.h
#include process.h
#include iostream.h
#include time.h
#include windows.h

typedef struct 
{
	DWORD dwThreadId;
	BYTE bProcessType; // 1 - FreeCell 2 - MineSweeper 3 - Paint
} RUNNING_PROCESS_INFO;

#define MAX_PROCESSES 10
RUNNING_PROCESS_INFO rp[MAX_PROCESSES];
int nRPCounter = 0; // running processes counter

int DisplayMainMenu();
void DisplayStopProcessMenu();
void process(int option);

int main(int argc, char* argv[])
{
	while(DisplayMainMenu()!=5);
	return 0;
}

int DisplayMainMenu()
{
	int option=0;
	system("cls");
	cout << "\n\n\n";
	cout << "\n\t*********************************";
	cout << "\n\t* *";
	cout << "\n\t* MAIN MENU *";
	cout << "\n\t* *";
	cout << "\n\t* 1. FreeCell *";
	cout << "\n\t* 2. MineSweeper *";
	cout << "\n\t* 3. Paint *";
	cout << "\n\t* 4. StopProcess *";
	cout << "\n\t* 5. Quit *";
	cout << "\n\t* *";
	cout << "\n\t*********************************";
	cout << "\n\nPlease type your choice "<< "and press the return key : ";
	cin >> option;

	process(option);
	
	return option;
}

void DisplayStopProcessMenu()
{
	int option=0;
	system("cls");
	cout << "\n\n\n";
	cout << "\n\t*********************************";
	cout << "\n\t* *";
	cout << "\n\t* STOP PROCESS MENU *";
	cout << "\n\t* *";
	for(int i=0;i<nRPCounter;i++)
	{
		cout << "\n\t* ";
		cout << i+1;
		cout << ". ";
		if(rp[i].bProcessType==1)
			cout << "FreeCell *";
		else if(rp[i].bProcessType==2)
			cout << "MineSweeper *";
		else
			cout << "Paint *";
	}
	cout << "\n\t* *";
	cout << "\n\t*********************************";
	cout << "\n\nPlease type your choice "<< "and press the return key : ";
	cin >> option;
	if(option>=1 && option<=nRPCounter)
	{
		PostThreadMessage(rp[option-1].dwThreadId,WM_QUIT,0,0);
		nRPCounter--;
		for(int i=option-1; i<nRPCounter; i++)
			memcpy(&rp[i],&rp[i+1],sizeof(RUNNING_PROCESS_INFO));
	}
}

void process(int option)
{
	STARTUPINFO si;
	PROCESS_INFORMATION pi;
	if(option>=1 && option<=3)
	{
		if(nRPCounter==MAX_PROCESSES)
		{
			printf("\a\aRunning processes table full\n");
			return;
		}
		ZeroMemory( &pi, sizeof(PROCESS_INFORMATION) );
		ZeroMemory( &si, sizeof(STARTUPINFO) );
		si.cb = sizeof(STARTUPINFO); 
	}
	switch (option)
	{
	case 1 : 
		if(CreateProcess( NULL, "FreeCell.exe", NULL, NULL, FALSE, NULL, NULL, NULL, &si, &pi))
		{
			rp[nRPCounter].dwThreadId = pi.dwThreadId;
			rp[nRPCounter++].bProcessType = 1;
			CloseHandle(pi.hThread);
			CloseHandle(pi.hProcess);
		}
		else
			printf("\a\aCreateProcess(...) failed\n");
		break; 
	case 2 : 
		if(CreateProcess( NULL, "winmine.exe", NULL, NULL, FALSE, NULL, NULL, NULL, &si, &pi))
		{
			rp[nRPCounter].dwThreadId = pi.dwThreadId;
			rp[nRPCounter++].bProcessType = 2;
			CloseHandle(pi.hThread);
			CloseHandle(pi.hProcess);
		}
		else
			printf("\a\aCreateProcess(...) failed\n");
		break;
	case 3 : 
		if(CreateProcess( NULL, "MsPaint.exe", NULL, NULL, FALSE, NULL, NULL, NULL, &si, &pi))
		{
			rp[nRPCounter].dwThreadId = pi.dwThreadId;
			rp[nRPCounter++].bProcessType = 3;
			CloseHandle(pi.hThread);
			CloseHandle(pi.hProcess);
		}
		else
			printf("\a\aCreateProcess(...) failed\n");
		break;
	case 4:
		DisplayStopProcessMenu();
		break;
	case 5 : 
		{
			for(int i=0; i<nRPCounter;i++)
				PostThreadMessage(rp[i].dwThreadId,WM_QUIT,0,0);
		}
		break;
	default : 
		printf("\a\aOption Not Available\n");
		break;
	}
}

Regards,
Andrzej Markowski

My Latest ArticlesCCustomBitmapButton: An owner-draw button and a frame for the caption bar, in one class.
CCustomTabCtrl: A clone of the Excel tab sheet control.

Andrzej Markowski21-Oct-04 8:38

21-Oct-04 8:38

Very Important!!!!
Don't use WM_QUIT message to kill other processes. Instead of WM_QUIT use WM_CLOSE. If you send WM_QUIT the application will not clean up resources and you will have memory leaks.

Regards,
Andrzej Markowski

My Latest ArticlesCCustomBitmapButton: An owner-draw button and a frame for the caption bar, in one class.
CCustomTabCtrl: A clone of the Excel tab sheet control.

Andrzej Markowski23-Oct-04 19:16