Database

Re: Input string was not in a correct format

16-Jul-04 2:22

From the email that you sent me the appropriate line appears to be:

UpdateCommand.Parameters.Add("@Price", SqlDbType.Decimal, 9).Value = hprice

But only if the textbox used to populate hprice (which you mentioned in your previous post) contains a value that cannot be interpreted as a decimal.

As I've already mentioned, you need to perform validation on the user input to ensure that invalid and nonsense values are rejected properly. As this is a price, I would guess that the only valid characters are the numeric characters and the decimal point (or comma - depending on your locality)

One easy way around this to perform the conversion yourself, then pass the converted value as the parameter. Wrap the conversion in a try catch block so that if the input from the user is incorrect you can catch it and report to the user their input is incorrect.

Decimal convertedHPrice = Convert.ToDecimal(hprice);

UpdateCommand.Parameters.Add("@Price", SqlDbType.Decimal, 9).Value = convertedHPrice

Does this help?

DotNet16-Jul-04 3:57

DotNet

16-Jul-04 3:57

Colin...... the code is here...

Sub DataGrid_Update(Sender As Object, E As DataGridCommandEventArgs)

' update the database with the new values

' get the edit text boxes
Dim id As String = (CType(e.Item.Cells(2).Controls(0), TextBox)).Text
Dim lname As String = (CType(e.Item.Cells(3).Controls(0), TextBox)).Text

'********************** Problem is here below here...
Dim hprice As String = (Ctype(e.Item.Cells(4).Controls(0), TextBox)).Text
Dim hdesc As String = (CType(e.Item.Cells(5).Controls(0), TextBox)).Text

Dim myConnection As New SqlConnection(ConnectionString)
Dim UpdateCommand As SqlCommand = new SqlCommand()
UpdateCommand.Connection = myConnection

If AddingNew = True Then
UpdateCommand.CommandText = "INSERT INTO Hardware(HardwareID, Name, Price, Description) VALUES (@HardwareID, @Name, @Price, @Description)"
Else
UpdateCommand.CommandText = "UPDATE Hardware SET HardwareID = @HardwareID, Name = @Name, Price = @Price, Description = @Description WHERE HardwareID = @HardwareID"
End If

UpdateCommand.Parameters.Add("@HardwareID", SqlDbType.Varchar, 5).Value = id
UpdateCommand.Parameters.Add("@Name", SqlDbType.VarChar, 50).Value = lname
'************************************** Problem is here below here...
UpdateCommand.Parameters.Add("@Price", SqlDbType.Money, 8).Value = hprice
UPdateCommand.Parameters.Add("@Description", SqlDbType.VarChar, 100).Value = hdesc
' execute the command
Try
myConnection.Open()
UpdateCommand.ExecuteNonQuery()

Catch ex as Exception
Message.Text = ex.ToString()

Finally
myConnection.Close()

End Try

' Resort the grid for new records
If AddingNew = True Then
DataGrid1.CurrentPageIndex = 0
AddingNew = false
End If

' rebind the grid
DataGrid1.EditItemIndex = -1
BindGrid()

End Sub

can i get some operation infomation from SQLsrv2k ?

fu015-Jul-04 15:58

fu0

15-Jul-04 15:58

i thought SQLsrv2k had a interface for 3rd part software to gain operation infomation. For example, while a record is inserted into a table, the 3rd part software might get this information.
also it might like the windows message mechanism, any operation may produce a message to windows or others.

is this possible ?

Re: can i get some operation infomation from SQLsrv2k ?

RichardGrimmer15-Jul-04 23:28

RichardGrimmer

15-Jul-04 23:28

DO you mean TRIGGERS? Can set one up On insert / update / delete which can then execute code inside SQL Server, or do you mean the ability for a third party app to recieve change notification?

"Now I guess I'll sit back and watch people misinterpret what I just said......"
Christian Graus At The Soapbox

Re: can i get some operation infomation from SQLsrv2k ?

fu017-Jul-04 15:39

fu0

17-Jul-04 15:39

Triggers might be a solution for this. But it need to modify the database. So i prefer a third party application to do this without modify the database.
i thought it can receive change notification like windows hook doing.
where can i start ? And is there aother way ?

Re: can i get some operation infomation from SQLsrv2k ?

RichardGrimmer19-Jul-04 5:40

RichardGrimmer

19-Jul-04 5:40

Think that you would struggle to do it - the 3rd party app would need to constantly poll the DB looking for changes, which at best would affect performance!

"Now I guess I'll sit back and watch people misinterpret what I just said......"
Christian Graus At The Soapbox

Is This Complex Update Possible?

perlmunger15-Jul-04 11:38

15-Jul-04 11:38

I am trying to take the result of a caculation of two fields in one table and place it into a field in another table? Is this possible?

I have two tables StoreItems and TicketItems. I need to get a unit cost from my StoreItems table by dividing the cost for an entire case (CaseCost) by the case count (CaseCount) and then placing that result into the Cost field of an item in the TicketItems table with a corresponding PLU (like an SKU). PLU and StoreID are the two fields in the tables that link them together. In a nutshell I need this:

StoreItems.Cost = TicketItems.CaseCost / TicketItems.CaseCount

Keep in mind that I need to run this on every record in the two tables so just passing in a StoreID and PLU is not enough. This has to be done across the board--that is, every TicketItems record needs to have its Cost column set when this has finished running.

Thank you.

-Matt

------------------------------------------

The 3 great virtues of a programmer:
Laziness, Impatience, and Hubris.
--Larry Wall

Colin Angus Mackay15-Jul-04 12:03

15-Jul-04 12:03

Off the top of my head the following should do what you want.

[EDIT] Oops. I made a mistake the Cost field you are updating is in the StoreItems table, the original query was updating the TicketItems table Blush | :O

[/EDIT]

UPDATE StoreItems
SET Cost = TicketItems.CaseCost / TicketItems.CaseCount
FROM TicketItems, StoreItems
WHERE TicketItems.PLU = StoreItems.PLU

You can get more information in your SQL Server books online, look up the index for UPDATE, UPDATE (described)

Does this help?

perlmunger15-Jul-04 12:21

15-Jul-04 12:21

Actually, no you were right the first time. The cost field is in the TicketItems table not the StoreItems table. So what did that query look like?

-Matt

------------------------------------------

The 3 great virtues of a programmer:
Laziness, Impatience, and Hubris.
--Larry Wall

Colin Angus Mackay15-Jul-04 12:29

15-Jul-04 12:29

Almost the same actually:

UPDATE TicketItems
SET Cost = TicketItems.CaseCost / TicketItems.CaseCount
FROM TicketItems, StoreItems
WHERE TicketItems.PLU = StoreItems.PLU

I'm now a bit confused, which table do the CaseCost and CaseCount items reside? If it is StoreItems then the query will look like this instead:

UPDATE TicketItems
SET Cost = StoreItems.CaseCost / StoreItems.CaseCount
FROM TicketItems, StoreItems
WHERE TicketItems.PLU = StoreItems.PLU

The second query assumes:
TicketItems.PLU
TicketItems.Cost

StoreItems.PLU
StoreItems.CastCost
StoreItems.CaseCount

PLU is the common field that joins the two tables.

This update will update every row in the TicketItems table.

Does this help? Or have I confused you in return?

perlmunger15-Jul-04 12:39

15-Jul-04 12:39

I think the second one is right. Let me try it out.

Thanks a lot for your help.

-Matt

------------------------------------------

The 3 great virtues of a programmer:
Laziness, Impatience, and Hubris.
--Larry Wall

perlmunger15-Jul-04 13:02

15-Jul-04 13:02

It worked and I understand it. You're a life saver!! Thank you!!

-Matt

------------------------------------------

The 3 great virtues of a programmer:
Laziness, Impatience, and Hubris.
--Larry Wall

Colin Angus Mackay15-Jul-04 13:07

15-Jul-04 13:07

perlmunger wrote:
It worked and I understand it.

Excellent. Big Grin | :-D

dishanf19-Jul-04 1:57

dishanf

19-Jul-04 1:57

Yes . you can update from one or more table ., Try this sql. may be want to change some col names. I think you get the idea.. Wink | ;)

UPDATE StoreItems
SET Cost = T.CaseCost / T.CaseCount
FROM StoreItems S INNER JOIN TicketItems T
ON S.PLU = T.PLU

HTH

D!shan

What's wrong with this script from a Wrox Book

dishanf19-Jul-04 2:03

dishanf

19-Jul-04 2:03

Oh.. sorry . already answered! .. net is too slow Frown | :(

D!shan

mtbjr15-Jul-04 2:18

mtbjr

15-Jul-04 2:18

I've been reading the former Wrox book "Professional ADO.NET Programming", and the samples in Chapter 3 requies an SQL database named "WroxDB", the downloaded source code includes a SQL script file named "WroxDB.sql". I'm new in SQL scripts, and stored procedures. I have VS.NET and MSDE installed, I tried running this script from osql using this:

C:\MSSQL7\Binn>osql -U sa -P -i C:\WroxDB.sql

The WroxDB.sql file contains this:

if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[tabAuthors]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
drop table [dbo].[tabAuthors]
GO

if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[tabPayments]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
drop table [dbo].[tabPayments]
GO

CREATE TABLE [dbo].[tabAuthors] (
[AuthorID] [int] NOT NULL ,
[Author_FirstName] [char] (50) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL ,
[Author_LastName] [char] (50) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL ,
[Photo] [image] NULL
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]
GO

CREATE TABLE [dbo].[tabPayments] (
[PaymentID] [int] IDENTITY (1, 1) NOT NULL ,
[AuthorID] [int] NOT NULL ,
[Payment] [money] NOT NULL ,
[Paid] [bit] NULL
) ON [PRIMARY]
GO

This execution always displays this message:

1> 2> 3> 1> 2> 3> 4> 1> 2> 3> 4> 5> 6> 7> 8> Msg 170, Level 15, State 1, Server
MANUELJR, Procedure , Line 4
[Microsoft][ODBC SQL Server Driver][SQL Server]Line 4: Incorrect syntax near
'COLLATE'.
1> 2> 3> 4> 5> 6> 7> 8> 1> 2>
C:\MSSQL7\Binn>

Please help, support in APRESS in this book is terrible.

Michael Potter15-Jul-04 5:23

Michael Potter

15-Jul-04 5:23

(1)I would run this in SQL Query Analyzer instead of osql. By default, sa is going to create these structures in the Master DB. That is never a wise method of operating. You could add a few statements at the top to handle the database creation also.

CREATE DATABASE TestingDb
GO

USE TestingDb
GO

(2) The script ran fine on my box. You can always drop the COLLATE statement and just use your systems default collation for strings. Your error may have something to do with your SQL version or SQL installation choices.

CREATE TABLE [dbo].[tabAuthors] (
[AuthorID] [int] NOT NULL ,
[Author_FirstName] [char] (50) NOT NULL ,
[Author_LastName] [char] (50) NOT NULL ,
[Photo] [image] NULL 
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]
GO

Steven Campbell15-Jul-04 7:01

Steven Campbell

15-Jul-04 7:01

This is a SQL 2000 script that you are running on SQL 7. Not all of the SQL 2000 syntax is supported in SQL 7 -- specifically, it may run if you remove the COLLATE SQL_Latin1_General_CP1_CI_AS pieces. There may be other incompatibilities though.

my blog

mtbjr15-Jul-04 16:29

mtbjr

15-Jul-04 16:29

OK, I've uninstalled SQL 7 and installed MSDE SP3a. I'll try your suggestions when I get home. One problem is, I've deleted all entries of MSSQL in the registry but when I try to run the SQL Server Service Manager, there's a blank entry above the MANUELJR entry in the Server combo box, is this right? What's that blank entry? Does that mean that I've missed or did not properly removed SQL 7? Please help.

Mekong River17-Jul-04 4:58

Mekong River

17-Jul-04 4:58

Can you tell me what is windows you are using? (w2k, xp...) answer clearly about its version (if win2k tell me, server or pro.)

On the other hand, check on wrox website. They also have an errata site for user to post any question or any error on it to update to the correct one.

Roath Kanel
APO-CEDC
Save Children Norway-Cambodia Office