|
What you have new'd you must delete
What you have new'd you must delete
What you have new'd you must delete
If you then make it null that's a good programming practice.
but if you make it null without deleting it then you simply create a memory leak.
Nish
Sonork ID 100.9786 voidmain
www.busterboy.org
Nish is a BIG fan of Goran Ivanisevic
|
|
|
|
|
Nish answered your question, but here's a little debugging tip:
When doing comparisons, put the constant value on the LHS of the comparison operator:
if (NULL == m_pPointer)
If you happen to accidentally leave off one of the equal signs (i.e., NULL = m_pPointer), your code won't compile because you can't assign a value to a literal.
This has saved me lots of debugging headaches. 
Jon Sagara
"We assume you already know not to consider something like Windows as a firewall platform. Does the name "Windows" evoke images of security? Silly rabbit, Windows is for desktops." -- Unix System Administration Handbook
|
|
|
|
|
Jon Sagara wrote:
When doing comparisons, put the constant value on the LHS of the comparison operator:
Quote/Unquote 'Debugging Windows Application' Microsoft Press 
Regards
Ray
"Je Suis Mort De Rire"
|
|
|
|
|
Yep, it's in there, too.
Jon Sagara
"We assume you already know not to consider something like Windows as a firewall platform. Does the name "Windows" evoke images of security? Silly rabbit, Windows is for desktops." -- Unix System Administration Handbook
|
|
|
|
|
Jon Sagara wrote:
When doing comparisons, put the constant value on the LHS of the comparison operator:
if (NULL == m_pPointer)
If you happen to accidentally leave off one of the equal signs (i.e., NULL = m_pPointer), your code won't compile because you can't assign a value to a literal.
Here's a better tip:
Write it in the readable fashion, as you did, eg:
if (m_pointer == NULL)
and then use the following pragma to prevent assignments in the body of an if statement:
#pragma warning(error : 4706) // Assignment in conditional
This keeps your code readable and safe at the same time. And while the pragma is not portable, the resulting safe, readable code is.
|
|
|
|
|
Jim A. Johnson wrote:
if (NULL == m_pPointer)
I didn't realize that this was non-portable. It has worked for me using VC6 and the GNU compilers.
Also, what is so difficult to read? I actually prefer this method because I know right away what the value of the variable is supposed to be.
Jon Sagara
"We assume you already know not to consider something like Windows as a firewall platform. Does the name "Windows" evoke images of security? Silly rabbit, Windows is for desktops." -- Unix System Administration Handbook
|
|
|
|
|
He meant the #pragma that disallows assignments in if conditions is non-portable.
--Mike--
http://home.inreach.com/mdunn/
#include "witty_sig.h"
![Heart | [heart]](https://codeproject.freetls.fastly.net/script/Forums/Images/love.gif) your ![Green Alien | [Alien]](https://codeproject.freetls.fastly.net/script/Forums/Images/alien.gif) with ![Good Stuff | [The good stuff]](https://codeproject.freetls.fastly.net/script/Forums/Images/vegemite.gif) and ![Beer | [beer]](https://codeproject.freetls.fastly.net/script/Forums/Images/beer.gif)
|
|
|
|
|
Context - The Mother of all Flame Wars.
Thanks for the note Michael,
Jon Sagara
"We assume you already know not to consider something like Windows as a firewall platform. Does the name "Windows" evoke images of security? Silly rabbit, Windows is for desktops." -- Unix System Administration Handbook
|
|
|
|
|
Jon Sagara wrote:
I didn't realize that this was non-portable. It has worked for me using VC6 and the GNU compilers
That's not what I said. Read it again, please.
|
|
|
|
|
This keeps your code readable and safe at the same time. And while the pragma is not portable, the resulting safe, readable code is.
Misunderstanding. My bad. Please forgive me this one transgression. 
Just out of curiosity, why don't you consider if (NULL == m_pPointer) readable? I admit it looked strange to me at first, but it's such a simple coding trick that you can use to save debugging time without having to remember some obscure pragma directive.
Jon Sagara
"We assume you already know not to consider something like Windows as a firewall platform. Does the name "Windows" evoke images of security? Silly rabbit, Windows is for desktops." -- Unix System Administration Handbook
|
|
|
|
|
Yeah, I agree. It is all about just getting use to it.
Tim Smith
Descartes Systems Sciences, Inc.
|
|
|
|
|
Why not use:
if (!m_pPointer)
instead of
if (NULL == m_pPointer)
|
|
|
|
|
Because the second is instantly readable, whereas with the first one you have to remember that "!pointer" means "pointer is not zero".
--Mike--
http://home.inreach.com/mdunn/
#include "witty_sig.h"
your with and
|
|
|
|
|
I agree with Mike, but I would make it
if (m_pPointer == NULL)
instead.
It just looks better to me because it flows more like the way you speak the same phrase. I've never heard anyone say "If NULL is the pointer...", but instead, people say "If the pointer is NULL...".
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001
|
|
|
|
|
void NewPointer()
{
if (m_pPointer == NULL)
{
m_pPointer = new(MyCPointClass);
if (NULL != pPointer && m_pPointer->NewPoint()) // NewPoint is a function, right?
{
return;
}
else
{
delete(m_pPointer);
m_pPointer = NULL; // avoid deleting the memory twice! deleting a NULL pointer is safe, but has a performance penalty since a call to the C-runtime library is done.
}
}
}
void DeletePointer()
{
if (NULL != m_pPointer)
{
delete m_pPointer;
m_pPointer = NULL;
}
}
if you insert
m_pPointer = NULL
somewhere in your code between NewPointer() and DeletePointer(), then yes you have a memory leak.
--------------------------------------------------
If my messages appear curt, I apologize.
I try to be brief to save your time as well as mine.
--------------------------------------------------
|
|
|
|
|
I would just like to say thanks to everybody for their response, all the answers were superb. I just didn`t think to delete the pointer first and then assign it NULL, but everything fits perfectly in my head now. I wondered how the application could delete those pointers in my program that were unused, without any trouble and it was because I had assigned them all to NULL in the constructor! For some reason I thought delete, deleted the memory AND set it to NULL, thats why I couldn`t grasp how it was actually working. But thanks to everyone who wrote in, I am very grateful,
Cheers,
Alan.
P.S. I liked the tips too. Just when I think I seem to be mastering this language, someone comes along and goes "Here's a better way of going about it...", that always amazes me. Thanks for those too guys.
"When I left you I was but the learner, now I am the Master" - Darth Vader
|
|
|
|
|
pls
==============
www.design.kg
|
|
|
|
|
use this
ShellExecute(this->m_hWnd,"open","mailto:","","",SW_SHOW);
Nish
Sonork ID 100.9786 voidmain
www.busterboy.org
Nish is a BIG fan of Goran Ivanisevic
|
|
|
|
|
?
==============
www.design.kg
|
|
|
|
|
you need to open the following registry key
HKEY_CLASSES_ROOT\mailto\shell\open\command
Nish
Sonork ID 100.9786 voidmain
www.busterboy.org
Nish is a BIG fan of Goran Ivanisevic
|
|
|
|
|
|
(1) open the key HKEY_CLASSES_ROOT\mailto\shell\open\command
(2) read it default value. I got this when I did that here
"%ProgramFiles%\Outlook Express\msimn.exe" /mailurl:%1
(3) you need to replace %ProgramFiles% with the actual path
for that use SHGetSpecialFolderLocation and SHGetSpecialFolderPath [you'll find samples in CP]
(4) forget the /mailurl:%1 part
(5) shellexecute the rest of it
Nish
Sonork ID 100.9786 voidmain
www.busterboy.org
Nish is a BIG fan of Goran Ivanisevic
|
|
|
|
|
Hello, the codegurus around the world.;)
Have a nice day!
-Masaaki Onishi-
|
|
|
|
|
Do you need a DLL's source code to generate .tbl or in there some tool that will extract a .tbl file from a .dll ?
I was importing (declaring) functions from a .dll (you may know it RAPI.dll, it comes with MS ActiveSync) into VB software, the functions didn't work and kept returning wierd error values. I tracked down a web site, which offered a copy of a .tbl which described the .dll I was attempting to use. Once registered I had no problem using the .dll . Can someone tell me what was going on ?
Regards
Ray
"Je Suis Mort De Rire"
|
|
|
|
|
Did you try registering the dll?
regsvr32 xxx.dll
Glad you found a solution, its nice to be talking hypothetically instead of urgently.
Bill
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
