Welcome to the Lounge

honey the codewitch wrote:

considering taking a different approach - ground up rewrite, heavy on the copy and paste from the old codebase.

The "common code" was a huge DLL that took forever to load and it contained code that was only occasionally used.

My boss, who learned to program in the Navy over twenty years earlier, was one of the programmers who originally built the program. While he was a good programmer, he moved into management and his skills became very rusty and out of date. He could not see why the existing code had to be changed.

This left me with the dilemma: update it on my own time without telling him or try to patch the code and pray that nothing breaks irrevocably.

I came up with a plan:

1. I dropped the duplicate subroutines and functions, then recoded the calls to use the ones that remained. I hunted down all of the dependencies upon side effects and removed them. Many were functions that returned a single value of True or False, but modified other data. These I changed to return a data record with the data changes. I released this update to the huge common code DLL.
   
2. I split the common code DLL into a three level structure with all the non-UI Windows API calls in the bottom layer. Depreciated API calls, of which there were many, were replaced with the current ones. The code to set up for API calls, such as letter generation, print formatting, data base record construction and whatnot in the middle layer as multiple DLLs. The top layer contained the business logic, with separate DLLs for Mental Behavioral Health, Mental Retardation Developmental Disabilities, insurance processing, billing, and client demographics. I released this revised common code as an update. I received praise from the clinicians because the whole program loaded much faster. My boss provided no feedback.
   
3. I split the main UI code removing rarely used paths to separately called programs. The main UI code handled all of the windows that everyone used. The separate programs handled billing and report generation, behavioral health unique logic, and developmental disabilities unique logic. I released this in stages, and again the loading time decreased.
   
4. When my boss decided on a date to update to Windows 7, he asked (finally!) how long it would take to convert the code base. I told him that, with the recent updates currently in place, I could be ready in two weeks.
   

While the cutover was ongoing, I did have to maintain two versions of the bottom layer of DLLs, but that was not overly onerous. The field crew could reinstall the final version with a simple command line.

The whole thing went so smoothly, that my boss was amazed. He finally looked through the code and was instantly lost when he found the code for loading and running multiple independent modules. He blew a gasket - his and his buddy's "elegant solution," which had morphed into spaghetti code was almost totally gone, although most of their code remained. He could not do much to me at the time: I was the clinicians' hero.

When I was asked (not by my boss!), I told people I was hired by my boss' predecessor as a software engineer, not just as a programmer.

obermd wrote:

Part of the problem is more and more on-line "journals" are bypassing the peer review process.

QuantumPlumber wrote:

but it's way better than the "no peer review" that some pay-for-publication portals allow.