Welcome to the Lounge

jkirkerx wrote:

close the connection, free the statement, add error logging and include the function name in the error statements, add parameters and use prepared statements to over 900 database functions

$cost_sum = 0;
    $select = '';

<pre>
$get_cost = " 
SELECT SUM(proj_cost.Cost), proj_cost.Vend_ID
FROM proj_cost 
INNER JOIN vendor ON proj_cost.Vend_ID = vendor.Vendor_ID 
WHERE (proj_cost.Proj_ID = '$proj_no') 
  AND (proj_cost.Proj_Stage = '$proj_stage') 
  AND (proj_cost.Vers_ID = '$ver_no') 
  AND (proj_cost.Task_Oper = '$cat_ID') 
  AND vendor.delete_flag <> '1' 
GROUP BY proj_cost.Vend_ID 
ORDER BY proj_cost.Vend_ID ";

$res_cost = sqlsrv_query($conn, $get_cost) or Die(" 464:" . print_r(sqlsrv_errors()) . " <br /> ");
if (sqlsrv_has_rows($res_cost)) {

    while ($row_cost = sqlsrv_fetch_array($res_cost)) {

        $cost = $row_cost[0];
        $vend_id = $row_cost[1];
        $cost = $cost + $comment_cost;
        if ($job_vendor == $vend_id) $cost_sum += $cost;
        $vend_name = clsGetPart::getVendorName($vend_id);

        echo "<td class='text-align-left' width='10%'>";

        if ($job_vendor == $vend_id) {
            printf("<p class='margin-text-indent font-weight-bold text-red'>$vend_name <br /><b>$%.2f&nbsp; </b></p></td>\n", $cost);
        } else {
            printf("<p class='margin-text-indent font-weight-bold text-black'>$vend_name<br />$%.2f&nbsp; </p></td>\n", $cost);
        }
    }</pre>

jkirkerx wrote:

I wonder why a university taught them this.

jkirkerx wrote:

Like sizing a DB column for an email address with 13 varchars.

honey the codewitch wrote:

I'm still buying LG next time.