|
This is legacy code, is not written by me.
|
|
|
|
|
Then I would suggest you search out every usage of those defines and turn them into real code.
|
|
|
|
|
Quote: P.S. Of course, 0 values are for testing purpose only.
However they are bad arguments for a (very likely) legitimate macro.
If you get the error with such arguments, then we cannot blame the compiler. On the other hand, if you're getting the same error with proper arguments then post such code here.
|
|
|
|
|
With 0 or original argumtents value, the error is the same.
|
|
|
|
|
But I can't help on 0, because the compiler is absolutely right complaining.
|
|
|
|
|
Syntactically that directive looks fine. Have you examined the preprocessor output (/P) to see what that directive looks like once expanded?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
There I have:
_WINDOWS;NDEBUG;%(PreprocessorDefinitions)
|
|
|
|
|
This is the content of your .I file?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
This is a combination of all of the above responses.
I have compiled this in mfc and it works.
struct data {
int something;
};
struct container {
int something_before;
struct data data_item;
int something_after;
};
#define list_entry(ptr, type, member) \
((type *)((char *)(ptr)-(size_t)(&((type *)0)->member))) // <-- here is the error ...
struct data *data_ptr;
struct container *cont_ptr = list_entry(data_ptr, struct container, data_item);
// This is the code you say is not compiling.
#define list_next_entry(pos, member) list_entry(0, 0, 0)
// This error is caused by the above line because list_entry(0,0,0) '0' is not a valid data type.
const int nTest = list_next_entry(0, 0); // <-- error C2059: syntax error : ')'
// If you do this instead...
#define list_next_entry(pos, member) list_entry(data_ptr, struct container, data_item)
// You will get a new error you will have to resolve in some way.
// error C2440: 'initializing' : cannot convert from 'container *' to 'const int'
// 1> There is no context in which this conversion is possible
// The compiler can't convert a pointer to an int.
// Don't know what you are trying to do.
const int nTest = list_next_entry(0, 0);
|
|
|
|
|
I am just trying to integrate a C old code into MFC project. I will try to do what you said, and give you a feedback.
|
|
|
|
|
The original code is just like that:
#define list_next_entry(pos, member) list_entry((pos)->member.next, typeof(*(pos)), member)
but the errors is little more then:
error C2100: illegal indirection
error C2059: syntax error : ')'
error C2059: syntax error : 'bad suffix on number'
error C3861: 'typeof': identifier not found
all of them is in the same line ...
|
|
|
|
|
You can't use -> or * on a value of 0! That causes the compiler errors. Try any non-null value, and at least these compiler errors should go away.
Moreover, typeof is not standard C/C++. There are implementations for that in the GCC extension for C, or in the BOOST library. You may need to find the correct BOOST library and include that in your project to make this code work.
GOTOs are a bit like wire coat hangers: they tend to breed in the darkness, such that where there once were few, eventually there are many, and the program's architecture collapses beneath them. (Fran Poretto)
|
|
|
|
|
Should I understand that pos has 0 value ?
And what I could use instead of
typeof without using BOOST ?
|
|
|
|
|
This is the original code:
#define list_next_entry(pos, member) \
list_entry((pos)->member.next, typeof(*(pos)), member)
|
|
|
|
|
So, as a conclusion, the code is:
const int nTest = list_next_entry(0, 0);
where list_next_entry is defined:
#define list_next_entry(pos, member) \
list_entry((pos)->member.next, typeof(*(pos)), member)
and list_entry is defined as:
#define list_entry(ptr, type, member) \
((type *)((char *)(ptr)-(size_t)(&((type *)0)->member)))
and for this code I get:
error C2100: illegal indirection
error C2059: syntax error : ')'
error C2059: syntax error : 'bad suffix on number'
error C3861: 'typeof': identifier not found
at line "const int nTest = list_next_entry(0, 0);"
I cannot get rid of these errors ... 
|
|
|
|
|
_Flaviu wrote: I cannot get rid of these errors
And you will not get rid of them as long as you keep using 0 as the parameters to the list_next_entry call. The define uses specific C/C++ types that are not valid if replaced by 0. In the above case this code translates as follows:
const int nTest = list_next_entry(0, 0);
list_entry((0)->0.next, typeof(*(0)), 0)
which makes no sense at all.
|
|
|
|
|
Here is the code:
const file_info* file = list_first_entry(&dir_list->list, const file_info, list);
const file_info* file2 = td_list_next_entry(file, list);
and I get the same errors:
error C2059: syntax error : ')'
error C3861: 'typeof': identifier not found
|
|
|
|
|
_Flaviu wrote: and I get the same errors:
error C2059: syntax error : ')'
error C3861: 'typeof': identifier not found
Of course you must get these error messages! Just because Quote: 'typeof'
does not exist in MFC (nor in Microsoft C++)
|
|
|
|
|
|
I have tried:
#define list_next_entry(pos, member) \
list_entry((pos)->member.next, decltype(*(pos)), member)
and I get another errors:
error C2528: 'abstract declarator' : pointer to reference is illegal
error C2528: 'abstract declarator' : pointer to reference is illegal
error C2227: left of '->list' must point to class/struct/union/generic type
seem to go for solving  ... I guess ...
|
|
|
|
|
What do you think decltype is going to do for you?
|
|
|
|
|
I have nver used decltype by now, I guess I have used improperly ... I have to read about this.
|
|
|
|
|
Took me a while to figure it out, but decltype(*pos) will give you a reference type, and the parts of the macro using this type to cast to type* then fail, because you can't create a pointer to a reference!
However, that's where std::remove_reference comes to the rescue! Try these definitions:
#include <type_traits> // for std::remove_reference
using namespace std;
#define list_entry(ptr, type, member) \
((type *)((char *)(ptr)-(size_t)(&((type *)nullptr)->member)))
#define list_next_entry(pos, member) \
list_entry((pos)->member.next, remove_reference< decltype(*(pos)) >::type, member)
P.S.: are you sure the second #define you posted is correct? I could make up some type definitions that I could use with these macros without encountering compiler errors, but I'm not at all sure the macros would provide a valid pointer for these types!
Here's the code I used to validate there are no compiler errors:
struct link
{
struct link* next;
};
struct node
{
int a;
link b;
int c;
};
int main()
{
node y = { 3, nullptr, 2 };
node x = { 5, &y.b, 4 };
node* p = list_next_entry(&x, b);
cout << "value = " << p->a << endl;
return 0;
}It did compile, but the output was some random number, not 3 as I expected. I suspect that either the structs or that second #define must be defined differently...
P.P.S.: it compiles and prints value = 3 as expected.
GOTOs are a bit like wire coat hangers: they tend to breed in the darkness, such that where there once were few, eventually there are many, and the program's architecture collapses beneath them. (Fran Poretto)
modified 21-Aug-19 11:44am.
|
|
|
|
|
Soon as I put
#include <type_traits> // for std::remove_reference
in file.h I got:
error C2894: templates cannot be declared to have 'C' linkage
for more than 100 times ... what settings should I use to get rid of this error ?
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
