C / C++ / MFC

19-Jul-03 21:37

Hello,

I am trying to find all files with extension ".lng" in the directory of my application's exe. This is my current code:

m_listLang.ResetContent();

CFileFind ff;
char szThis[MAX_PATH*2];
unsigned long i = 0;
CString csTmp;
BOOL chk_w = FALSE;

GetModuleFileName(NULL, szThis, MAX_PATH * 2);
for(i = strlen(szThis)-1; i > 1; i--) // Extract dir
{
    if(szThis[i] == '\\') { szThis[i] = 0; break; }
}
strcat(szThis, "\\*.lng");

chk_w = ff.FindFile(szThis, 0);
while(chk_w == TRUE)
{
    if(ff.FindNextFile())
    {
        m_listLang.AddString(ff.GetFileTitle());
    }
    else
    {
        chk_w = FALSE;
    }
}

ff.Close();

This should find all *.lng files in the directory of the executable and add their titles (so without extension) to a CListBox.

But it's not working. It always misses one file. I tried to use the FindFile function directly (so without a FindNextFile call), but as stated in MSDN this is not allowed.

Do you have any idea what I am doing wrong? Confused | :confused:

Thanks
-Dominik

_outp(0x64, 0xAD);
and
__asm mov al, 0xAD __asm out 0x64, al
do the same... but what do they do??

Ryan Binns19-Jul-03 22:12

19-Jul-03 22:12

OK. As written, it will always skip the first file it finds. This is because you find the first file, enter the loop, and immediately find the next file without using the first one. Write your loop like this:

chk_w = ff.FindFile(szThis, 0);
while(chk_w == TRUE)
{
   m_listLang.AddString(ff.GetFileTitle());
   chk_w = ff.FindNextFile();
}

Hope this helps,

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

Dominik Reichl19-Jul-03 22:27

19-Jul-03 22:27

No, that doesn't work. You may not use the "output" of the FindFile function.

MSDN says:

After calling FindFile to begin the file search, call FindNextFile to retrieve subsequent files. You must call FindNextFile at least once before calling any of the following attribute member functions: [blablabla, functions like GetFileTitle]

.

So i think my loop is correct Wink | ;)

Any more ideas? Confused | :confused:

-Dominik

_outp(0x64, 0xAD);
and
__asm mov al, 0xAD __asm out 0x64, al
do the same... but what do they do??

Ryan Binns19-Jul-03 22:29

19-Jul-03 22:29

Have you tried it? I read the docs too, but I also looked at the source code, and can't find any reason why it wouldn't work.

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

Dominik Reichl19-Jul-03 22:31

19-Jul-03 22:31

Yes, I also tried it (couldn't believe it myself too Wink | ;)

), but it really doesn't work (ASSERTed).

-Dominik

_outp(0x64, 0xAD);
and
__asm mov al, 0xAD __asm out 0x64, al
do the same... but what do they do??

Ryan Binns19-Jul-03 22:33

19-Jul-03 22:33

Hmmm. Ok. I'll have a look, because it sounds like a bug to me. The output of the Win32 FindFirstFile() function can definitely be used - I use it all the time.

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

Dominik Reichl19-Jul-03 22:38

19-Jul-03 22:38

Thats true. The Win32 function returns information about the first file, but CFileFind::FindFile doesn't Eek! | :eek:

-Dominik

_outp(0x64, 0xAD);
and
__asm mov al, 0xAD __asm out 0x64, al
do the same... but what do they do??

Ryan Binns19-Jul-03 22:43

19-Jul-03 22:43

I just had a close look at the source code. For some reason they buffer the returned data so you're always one file behind what FindNextFile() returns. I always use the Win32 functions. Much easier Smile | :)

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

Dominik Reichl19-Jul-03 22:42

19-Jul-03 22:42

O damn, I cannot read the docs Blush | :O

MSDN on FindNextFile:

<br />
Return<br />
Nonzero if there are more files; zero if this is the last file, and the previous call to either FindFile or FindNextFile returned nonzero. To get extended error information, call the Win32 functionGetLastError.

.

So the (in my opinion stupid Big Grin | :-D

) function returns 0 if it returns information about the last file. I expected it returns 0 if there is no more file.

Blush | :O

-Dominik

_outp(0x64, 0xAD);
and
__asm mov al, 0xAD __asm out 0x64, al
do the same... but what do they do??

Ryan Binns19-Jul-03 22:44

19-Jul-03 22:44

Aah. So you need to do

BOOL res = ff.FindFile(_T("filespec.whatever"), 0);
while(ff.FindNextFile())
{
   // Whatever with the file.
}

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"