Click here to Skip to main content
15,917,005 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: Showing company code to potential new hire? Pin
Sander Rossel14-Sep-18 23:21
professionalSander Rossel14-Sep-18 23:21 
GeneralRe: Showing company code to potential new hire? Pin
dandy7214-Sep-18 9:56
dandy7214-Sep-18 9:56 
GeneralRe: Showing company code to potential new hire? Pin
Eddy Vluggen14-Sep-18 23:17
professionalEddy Vluggen14-Sep-18 23:17 
GeneralRe: Showing company code to potential new hire? Pin
Sander Rossel14-Sep-18 23:28
professionalSander Rossel14-Sep-18 23:28 
GeneralRe: Showing company code to potential new hire? Pin
Eric Lynch15-Sep-18 1:52
Eric Lynch15-Sep-18 1:52 
GeneralRe: Showing company code to potential new hire? Pin
GKP199215-Sep-18 2:25
professionalGKP199215-Sep-18 2:25 
GeneralRe: Showing company code to potential new hire? Pin
maze316-Sep-18 22:36
professionalmaze316-Sep-18 22:36 
GeneralRe: Showing company code to potential new hire? Pin
Kirk 1038982117-Sep-18 4:38
Kirk 1038982117-Sep-18 4:38 
Let me ask a different set of questions?
1) How often do you review code? (Code Reviews)
2) Do you have a Wiki with the details of how all code should be written/formatted, etc?
3) Have you made the code reviews combative or helpful?
4) Do new programmers get to participate in Code Reviews?

Then, I would show the PROSPECTIVE new hire the Wiki, and ask what they agree and disagree with, and why?

We allow exceptions to almost EVERY rule, if it is justified, makes the block easier to debug/analyze/or validate. But we push for consensus in these cases. Some things are defensible, others are not.

And if you are not doing code reviews. THEN you have found your problem. Our experience shows that without code reviews, NOBODY will take full ownership of the code, and continue to blame the people before them. We make you cleanup EVERY FILE you touch. AND we are flexible. The entire file has to be reformatted with default settings (if they were not applied before), and then the section that was "truly updated" is reviewed in detail. (Meaning EVERYTHING newly written or truly changed MUST follow our coding standards).

The results are amazing! Errors/Fixes are way down. The size/scope of fixes are a great predictor of the project being "done" and "stable" (if the last few fixes have been One liners. And we see nothing else, and it is in use, there are usually few if any gotchas remaining, and these things don't come back to haunt us. But a major rewrite... Ugghhh...)

Fix your culture first, and hire people who gravitate towards the rules!

GeneralRe: Showing company code to potential new hire? Pin
patbob17-Sep-18 6:21
patbob17-Sep-18 6:21 
GeneralThought of the Day Pin
OriginalGriff14-Sep-18 5:04
mveOriginalGriff14-Sep-18 5:04 
GeneralRe: Thought of the Day Pin
W Balboos, GHB14-Sep-18 5:09
W Balboos, GHB14-Sep-18 5:09 
GeneralRe: Thought of the Day Pin
megaadam14-Sep-18 5:13
professionalmegaadam14-Sep-18 5:13 
GeneralRe: Thought of the Day Pin
CodeWraith14-Sep-18 5:15
CodeWraith14-Sep-18 5:15 
GeneralRe: Thought of the Day Pin
OriginalGriff14-Sep-18 5:31
mveOriginalGriff14-Sep-18 5:31 
GeneralRe: Thought of the Day Pin
Mike Hankey14-Sep-18 5:38
mveMike Hankey14-Sep-18 5:38 
GeneralRe: Thought of the Day Pin
lopatir14-Sep-18 7:24
lopatir14-Sep-18 7:24 
GeneralRe: Thought of the Day Pin
DRHuff14-Sep-18 9:17
DRHuff14-Sep-18 9:17 
GeneralRe: Thought of the Day Pin
Eric Lynch15-Sep-18 1:54
Eric Lynch15-Sep-18 1:54 
GeneralThe Expanse Pin
Infosys Irvine14-Sep-18 4:50
Infosys Irvine14-Sep-18 4:50 
GeneralRe: The Expanse Pin
TheGreatAndPowerfulOz14-Sep-18 5:02
TheGreatAndPowerfulOz14-Sep-18 5:02 
GeneralRe: The Expanse Pin
phil.o14-Sep-18 5:24
professionalphil.o14-Sep-18 5:24 
GeneralRe: The Expanse Pin
Infosys Irvine14-Sep-18 5:59
Infosys Irvine14-Sep-18 5:59 
GeneralRe: The Expanse Pin
TheGreatAndPowerfulOz14-Sep-18 15:39
TheGreatAndPowerfulOz14-Sep-18 15:39 
GeneralRe: The Expanse Pin
Richard Deeming14-Sep-18 5:48
mveRichard Deeming14-Sep-18 5:48 
GeneralRe: The Expanse Pin
Infosys Irvine14-Sep-18 6:26
Infosys Irvine14-Sep-18 6:26 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.