C#

user20044 wrote:

AppendAllText uses FileShare.None flag?

user20044 wrote:

So what are shortcomings of this final version of the class you think?

user20044 wrote:

accessing the logDir variable in a thread safe way?

user20044 wrote:

What about performance?

user20044 wrote:

No other shortcomings?

private const string LogDirectory = @"C:\Logs\";

private static string _logDirectory = @"C:\Logs\";

public static string LogDirectory
{
    get
    {
        return _logDirectory;
    }
    set
    {
        if (string.IsNullOrWhiteSpace(value))
        {
            throw new ArgumentNullException("value");
        }
        if (!value.EndsWith(@"\"))
        {
            value += @"\";
        }

        _logDirectory = value;
    }
}

string logDir = _logDir;
if (!logDir.EndsWith(@"\")) logDir += @"\"; 
Directory.CreateDirectory(logDir);
var todaysLogFilePath = Path.Combine(logDir, ...);

static class GMLogger
{
    private const int MaxBufferSize = 25;
    private static readonly object _syncObject = new object();
    private static readonly List<string> _buffer = new List<string>();
    private static string _logDir = @"C:\Logs\";
    
    public static string LogDirectory
    {
        get
        {
            return _logDir;
        }
        set
        {
            if (string.IsNullOrWhiteSpace(value))
            {
                throw new ArgumentNullException("value");
            }
            if (!value.EndsWith(@"\"))
            {
                value += @"\";
            }
            
            _logDir = value;
        }
    }
    
    private static string EnsureLogDirectory()
    {
        string path = LogDirectory;
        Directory.CreateDirectory(path);
        return path;
    }
    
    private static string BuildLogPath(string directory, DateTime logDate)
    {
        string fileName = string.Format("Log{0:yyyy-MM-dd}.txt", logDate);
        return Path.Combine(directory, fileName);
    }
    
    private static void SaveLog()
    {
        if (_buffer.Count != 0)
        {
            string directory = EnsureLogDirectory();
            string fileName = BuildLogPath(directory, DateTime.Today);
            File.AppendAllLines(fileName, _buffer);
            _buffer.Clear();
        }
    }
    
    public static void Log(string logMessage)
    {
        lock (_syncObject)
        {
            _buffer.Add(logMessage);
            
            if (_buffer.Count == MaxBufferSize)
            {
                SaveLog();
            }
        }
    }
    
    public static void Save()
    {
        lock (_syncObject)
        {
            SaveLog();
        }
    }
}

static void Main()
{
    try
    {
        ...
    }
    finally
    {
        GMLogger.Save();
    }
}

user20044 wrote:

I remove buffer altogether and directly write to file

List<string> copy = null;
lock(_syncObject) {
  _buffer.Add(logMessage);
  if ( _buffer.Count > _maxBufferSize) {
    copy = _buffer;
    _buffer = new List<string>();
  }
}
if ( copy != null) 
  Save(copy);