C#

uniflare wrote:

comments about the quality of the code

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace etstapp1
{
    public partial class Form1 : Form
    {
        private skbtServerControl sc;
        public Form1()
        {
            InitializeComponent();

            this.sc = new skbtServerControl(this);

            // coxArmaPath = Combo Box (simple drop down)
            this.cBoxArmaPath.ValueMember = "Key";
            this.cBoxArmaPath.DisplayMember = "Value"; // This doesnt seem to stick after the first datasource set??
            // ....
        }

        public void addServerPathItem(String Key, String Value)
        {
            this.cBoxArmaPath.Items.Add(new KeyValuePair<String, String>(Key, Value));
            // This works fine, only the "DisplayMember" is displayed and the "ValueMember" is hidden.
        }

        // This acts differently with the same types???
        public void setServerPathDatasource(List<KeyValuePair<String, String>> source)
        {
            this.cBoxArmaPath.DisplayMember = "Value"; // fix datasource problem
            this.cBoxArmaPath.ValueMember = "Key"; // fix datasource problem

            this.cBoxArmaPath.DataSource = new BindingSource(source, null);
        }

        public void clearPathBox()
        {
            if(this.cBoxArmaPath.DataSource == null){
                this.cBoxArmaPath.Items.Clear();
            }
            else
            {
                this.cBoxArmaPath.DataSource = null;
            }
        }

        private void btnStatic_Click(object sender, EventArgs e)
        {
            this.sc.refreshformWindowWithSTATICDatasource();
        }

        private void btnNormal_Click(object sender, EventArgs e)
        {
            this.sc.refreshFormWindow();
        }

        private void btnDynamic_Click(object sender, EventArgs e)
        {
            this.sc.refreshformWindowWithDatasource();
        }
    }

    public class skbtServerControl
    {

        private CoreConfig CoreConfig;

        private Form1 frmMainWindowHandle;

        public skbtServerControl(Form1 f){
            this.frmMainWindowHandle = f;
            this.CoreConfig = new CoreConfig();
        }

        public void refreshFormWindow()
        {
            // Clear Drop Box (empties drop box)
            this.frmMainWindowHandle.clearPathBox();

            //skbtServerConfig is very simple property object
            foreach (KeyValuePair<String, skbtServerConfig> pair in CoreConfig.getServerConfigList())
            {
                // Populate Drop Box
                this.frmMainWindowHandle.addServerPathItem(pair.Key, pair.Value.getTextualName());
            }
        }

        // This works absolutely fine. ValueMembers are hidden.
        public void refreshformWindowWithSTATICDatasource()
        {
            // Clear Drop Box
            this.frmMainWindowHandle.clearPathBox();

            var pathDataSource = new List<KeyValuePair<String, String>>() 
            {
                new KeyValuePair<String, String>("testKey1", "somevalue1"),
                new KeyValuePair<String, String>("testKey2", "somevalue2"),
                new KeyValuePair<String, String>("testKey3", "somevalue3")
            };

            // Populate Drop Box
            this.frmMainWindowHandle.setServerPathDatasource(pathDataSource);
        }

        // ** HERE IS THE PROBLEM?? **
        // This creates a type that seems different to the above function which works fine...
        public void refreshformWindowWithDatasource()
        {
            // Clear Drop Box
            this.frmMainWindowHandle.clearPathBox();

            var pathDataSource = new List<KeyValuePair<String, String>>();

            //skbtServerConfig is very simple property object
            foreach (KeyValuePair<String, skbtServerConfig> pair in this.CoreConfig.getServerConfigList())
            {
                pathDataSource.Add(new KeyValuePair<String, String>(pair.Key, pair.Value.getTextualName()));
            }

            // Populate Drop Box
            this.frmMainWindowHandle.setServerPathDatasource(pathDataSource);
        }
    }

    public class CoreConfig
    {
        public Dictionary<String, skbtServerConfig> getServerConfigList(){
            return new Dictionary<string, skbtServerConfig>()
            {
                {"somekey1", new skbtServerConfig("somename1")},
                {"somekey2", new skbtServerConfig("somename2")}
            };
        }
    }

    public class skbtServerConfig
    {
        private String name;

        public skbtServerConfig(String name)
        {
            this.name = name;
        }

        public String getTextualName()
        {
            return this.name;
        }
    }
}