Re: Want Opinion on school assignment - C# Discussion Boards

13-Feb-15 1:51

Hi,

My instructor and I disagree on a mark that she gave me an assignment on generics. According to the requirements stated below, could someone tell me if my could meets these requirements.

Here is the requirements:

Write a generic method, Search, that implements the linear-search algorithm. Method Search
should compare the search key with each element in its array parameter until the search key is
found or until the end of the array is reached. If the search key is found, return its location in the
array; otherwise, return -1. Write a test app that inputs and searches an int array and a double array.

And here is my code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace GenericsTest
{
    class MyArrayList
    {
        int CountInt2 { get; set;}
        int CountInt1 { get; set;}
        int CountDouble2 { get; set; }
        int CountDouble1 { get; set; }

        int[] integerArray;
        double[] doubleArray;

        public MyArrayList() 
        {
            CountInt1 = 0;
            CountInt2 = 0;
            CountDouble1 = 0;
            CountDouble2 = 0;
            integerArray = new int[5];
            doubleArray = new double[5];
            
        }

        //used to fill Student array
        public void SetArrayInfo(int number)
        {
            integerArray[CountInt1] = number;
            ++CountInt1;
        }//end SetArrayInfo<Student>

        //used to fill Student array
        public void SetArrayInfo(double number)
        {
            doubleArray[CountDouble1] = number;
            ++CountDouble1;
        }//end SetArrayInfo<Student>
           
            public int Search<T>(T number)
        {

            if (number.GetType() == typeof(int))
            {
                //used to find student info in student array
                while (CountInt2 <= integerArray.Length)
                {
                    if (CountInt2 < integerArray.Length)
                        if (integerArray[CountInt2].Equals(number))
                        {
                            Console.Clear();
                            Console.WriteLine("The number " + integerArray[CountInt2] + " was found in array index number: " + CountInt2);
                            Console.WriteLine();
                            CountInt2 = 0;
                            return -2;
                        }
                    ++CountInt2;
                }
                return -1;
            }


            else if (number.GetType() == typeof(double))
            {
                //used to find student info in student array
                while (CountDouble2 <= doubleArray.Length)
                {
                    if (CountDouble2 < doubleArray.Length)
                        if (doubleArray[CountDouble2].Equals(number))
                        {
                            Console.Clear();
                            Console.WriteLine("The double " + doubleArray[CountDouble2] + " was found in array index number: {0}", CountDouble2);
                            Console.WriteLine();
                            CountDouble2 = 0;
                            return -2;
                        }
                    ++CountDouble2;
                }
            }
            return -1;
        }//end GetArrayInfo<int>
    }
   

    class DriverProgram 
    {
        static void Main(string[] args) 
        {
            int numberInt;
            double numberDouble;
            int choice = 0;

            MyArrayList myArrayList = new MyArrayList();

            myArrayList.SetArrayInfo(8);
            myArrayList.SetArrayInfo(9);
            myArrayList.SetArrayInfo(5);
            myArrayList.SetArrayInfo(10);
            myArrayList.SetArrayInfo(21);

            myArrayList.SetArrayInfo(7.7);
            myArrayList.SetArrayInfo(3.30);
            myArrayList.SetArrayInfo(9.80);
            myArrayList.SetArrayInfo(12.3);
            myArrayList.SetArrayInfo(21.58);

            do
            {

                Console.WriteLine("1  Get Integer Array Index");
                Console.WriteLine("2  Get Double Array Index");
                Console.WriteLine("3  Exit");
                try
                {
                    Console.Write("Choose one: ");
                    choice = Convert.ToInt32(Console.ReadLine());
                }

                catch (FormatException e)
                {
                    Console.WriteLine("You have entered an invalid type");
                    Console.WriteLine("Error: " + e);
                }


                

                //return Integer array index
                if (choice == 1)
                {
                    try
                    {
                        Console.Clear();
                        Console.Write("Enter integere number: ");
                        numberInt = Convert.ToInt32(Console.ReadLine());
                        int answer = myArrayList.Search<int>(numberInt);
                        if (answer == -1)
                            Console.WriteLine("The ID number entered was not found.");
                    }

                    catch (FormatException e)
                    {
                        Console.WriteLine("You have entered an invalid type");
                        Console.WriteLine("Error: " + e);
                    }
                }

                else if (choice == 2)
                {
                    try
                    {
                        Console.Clear();
                        Console.Write("Enter double number: ");
                        numberDouble = Convert.ToDouble(Console.ReadLine());
                        int answer = myArrayList.Search<double>(numberDouble);
                        if (answer == -1)
                            Console.WriteLine("The ID number entered was not found.");
                    }

                    catch (FormatException e)
                    {
                        Console.WriteLine("You have entered an invalid type");
                        Console.WriteLine("Error: " + e);
                    }
                }

                //clear screen before exit
                else if (choice == 3) { Console.Clear(); }

                //display error message if user chooses an invalid choice
                else
                {
                    Console.Clear();
                    Console.WriteLine("The choice you made is Invalid");
                }

                //exit program
                Console.WriteLine("Press any key to continue....");
                Console.ReadKey();
                Console.Clear();

            } while (choice != 3);//end do/while loop
        }
    }
}
</<pre lang="c#">

pre>

According to my instructor's feed back, my work was among some of the worst work submitted in class. I think my program meets my instructors requirements stated above.

Any feedback would be welcome.

If I do not thank you right away it is because I'm busy in school

Thanks,
Truck53

Freak3013-Feb-15 2:14

Freak30

13-Feb-15 2:14

Your search function isn't generic at all. You are specifically testing for int and double inside the function. What happens if you call

SearchArray<long>(5L)

SearchArray<String>("Test")

?

I think you were supposed to write a function with a signature like this:

int SearchArray<T>(T[] Array, T itemSearched)

You could have coded this function as member of the DriverProgramClass. Or if you insisted on creating an extra class MyArrayList for encapsulation, it should have been Generic (i.e. with a T[] member, instead of int[] and double[]) as well.

Besides, what does this comment about the student array mean? Did you just copy this somewhere else and slightly change it?

The good thing about pessimism is, that you are always either right or pleasently surprised.

Truck5313-Feb-15 4:58

13-Feb-15 4:58

Thanks
And God Bless.

Truck5313-Feb-15 17:13

13-Feb-15 17:13

Hello,

Thank you for answering my question. I was particularly interested with your commit. You said that my method was not generic at all and that I should have used a generic array of type T. Does the generic array create two types of arrays and access them at run time? If this is true, I could understand why people might be a little edgy with my code. But, if you look at the requirements, the instructor says that two arrays are to be used, one for double and one for integer; At least that is what I interpreted when I read "an integer and a double"The sentence she uses does not explicitly imply the use of a generic array. In fact, the only time the word generic is used is when the instructor refers to the Search method. And, the only way I could think of using two arrays of the type specified by my instructor is to compare the type passed by the my generic method at run time then traverse through the array and compare the key to the value in the array. I learned in college that a lot of projects fail because developers fail to meet the user’s requirements. I think assuming that a generic array was to be used when according to what the instructor wrote, the use of two array of the primitive type integer and double was implied. I would encourage you to take a good look at what my instructor wrote in the requirements and not just go by what you think is the best way to code. Hit me up and let me know what you think. If I’m wrong then I’m wrong.

And, about the student commented out code. I originally had a class with properties that held information like student ID and Student name etc. But, I took a second look at the instructor’s requirements and decided to keep it simple. I hope this answers your question.

Peace,

Truck53

Peace.

OriginalGriff13-Feb-15 2:21

OriginalGriff

13-Feb-15 2:21

The instructor is right, by definition: and arguing with him / her will not help in the future.
Remember: the same person will be marking your next effort, so annoying them is not a good idea.

And that is poor: it doesn't look like you understood the concept of generics at all - or indeed even tried particularly hard. I can't comment on if it's absolutely the worst: I've only seen two examples from your class (the other is here[^] and at least the other tried to use generics a little.

I suggest that you have a close look at all the comments on the other example, and the rather more mature way in which your classmate handled it...

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Eddy Vluggen13-Feb-15 3:03

Eddy Vluggen

13-Feb-15 3:03

OriginalGriff wrote:
The instructor is right, by definition

So, everything coming from an instructor (let us not even go into whether it is a qualified instructor) is the absolute truth?

I advocate the oppsite; you should question everything.

OriginalGriff wrote:
Remember: the same person will be marking your next effort, so annoying them is not a good idea.

Never understood how people accept that; the one that is teaching cannot be the one judging. That's why exams are checked by other people.

OriginalGriff wrote:
it doesn't look like you understood the concept of generics at all

That is a nice obeservation. How much would he learn from his instructors' code review?

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

OriginalGriff13-Feb-15 4:34

OriginalGriff

13-Feb-15 4:34

When it comes to marking the assignment, the instructor is always right - simply because they are doing the marking and nothing you can say or do will alter the mark they will give you (except to move it downward)
If you want to pass the course, you have to pander to the tutor's beliefs and submit work that agrees with that - or you will receive a failing grade. It may not be nice; it may not be helpful in the real world; but that is the politics of the situation, and challenging that is not going to help in real terms.

Teachers are wrong - frequently very, very wrong - but there is nothing to be gained by pointing that out to them, any more than there is with the Police! Laugh | :laugh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Eddy Vluggen13-Feb-15 4:52

Eddy Vluggen

13-Feb-15 4:52

OriginalGriff wrote:
When it comes to marking the assignment, the instructor is always right

No one holds the absolute truth.

OriginalGriff wrote:
you have to pander to the tutor's beliefs and submit work that agrees with that

That's how it works, yes. You be nice to the idiot and you pass. Sorry, but I'm paying for knowledge, not for someone to grade how kind I am. And yes, I made some "teachers" leave Smile | :)

OriginalGriff wrote:
but that is the politics of the situation, and challenging that is not going to help in real terms.

Accepting that as a reality is morally wrong.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Truck5313-Feb-15 5:01

13-Feb-15 5:01

Thanks
And God Bless.

Dave Kreskowiak13-Feb-15 3:03

Dave Kreskowiak

13-Feb-15 3:03

Dude, look. Asking this question is just stupid. If you think our opinion is ever going to sway your instructors is ridiculous.

Again, your code doesn't meet the requirements, not even close.

You've asked this question twice now and come on on the losing end every time. The problem is not with the instructor. It's with you.

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

Truck5313-Feb-15 5:01

13-Feb-15 5:01

Thanks
And God Bless.

Pete O'Hanlon13-Feb-15 3:18

Pete O'Hanlon

13-Feb-15 3:18

Your instructor is right. You could implement this in a dozen lines, using a generic. I'd award you extra credit if you catered for doubles not being 100% accurate in comparisons (there are ways to do this in a generic fashion).

Truck5313-Feb-15 5:01

how to insert wifi scan data into sql table

13-Feb-15 5:01

Thanks
And God Bless.

Olu_0112-Feb-15 18:03

12-Feb-15 18:03

Urgent assist required. Can someone help pls, i have scanned wifi data in C# that i have split into required form MAC,SSID and RSSi . i want when i push a button the results are inserted into an sql table that i already created. and if i push the buton again it stops inserting. I have tried several methods and could not get it to work, Will appreciate assist

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Data.SqlClient;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.IO.Ports;

namespace WICED_SERIALPORT_TEST
{
    public partial class Form1 : Form

    {
        
        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            string[] ports = SerialPort.GetPortNames();
            foreach (string port in ports)
            {
                comboBox1.Items.Add(port);
            }

        }
        //
        string t;
        private void button2_Click(object sender, EventArgs e)
        {

            t = comboBox1.Text.ToString();
            sErial(t);
            
        }
        //
        SerialPort sp;
        void sErial(string Port_name)
        {
            sp = new SerialPort(Port_name, 115200, Parity.None, 8, StopBits.One);
            sp.DataReceived += new SerialDataReceivedEventHandler(DataReceivedHandler);
            sp.Open();
        }
        // 
        private void DataReceivedHandler(object sender, SerialDataReceivedEventArgs e)
        {
            SerialPort sp = (SerialPort)sender;
            string msg = string.Empty;
            bool canCont = false;

            while (!canCont)
            {
                msg += sp.ReadLine();
                if (msg.Contains("Scan complete "))
                {
                    canCont = true;
                }
            }

            //string w = sp.ReadLine();
            //string w = sp.ReadExisting();

            // string msg = sp.ReadExisting();

            string[] msgArr = msg.Split('\r');

            Invoke(new Action(() => listBox1.Items.Clear()));


            List<string[]> list = new List<string[]>();
            List<Networks> Scan = new List<Networks>();

            for (int i = 0; i < msgArr.Length; i++)
            {
                list.Add(msgArr[i].Split(new string[] { "  " }, StringSplitOptions.RemoveEmptyEntries));
            }

            for (int i = 0; i < list.Count; i++)
            {
                if (i > 2)
                {
                    if (list[i].Length > 4)
                    {
                        int numOfSplits = 0;
                        List<string> tempList = new List<string>();

                        for (int ii = 0; ii < list[i].Length; ii++)
                        {
                            if (numOfSplits < 6)
                            {
                                string[] temp1 = list[i][ii].Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
                                numOfSplits += temp1.Length;

                                for (int iii = 0; iii < temp1.Length; iii++)
                                {
                                    tempList.Add(temp1[iii]);
                                }
                            }
                            else
                            {
                                tempList.Add(list[i][ii]);
                            }
                        }

                        Scan.Add(new Networks()
                        {
                            ID = Convert.ToInt32(tempList[0]),
                            NetworkType = tempList[1],
                            MAC = tempList[2],
                            RSSi = Convert.ToInt32(tempList[3]),
                            Rate = Convert.ToDouble(tempList[4]),
                            Channel = Convert.ToInt32(tempList[5]),
                            Security = tempList[6],
                            SSID = tempList[7],
                        });
                    }
                }
            }
            if (msg != String.Empty)
            {
                Invoke(new Action(() => richTextBox1.AppendText(msg)));

            }
            for (int i = 0; i < Scan.Count; i++)
            {
                Invoke(new Action(() => listBox1.Items.Add(Scan[i].MAC)));
                Invoke(new Action(() => listBox2.Items.Add(Scan[i].RSSi)));
                Invoke(new Action(() => listBox3.Items.Add(Scan[i].SSID)));

                msg = string.Empty;
                list.Clear();
            }
        }

        private void richTextBox1_TextChanged(object sender, EventArgs e)
        {

            
            
           
        }

        private void comboBox1_SelectedIndexChanged(object sender, EventArgs e)
        {
            
        }

        private void richTextBox2_TextChanged(object sender, EventArgs e)
        {
           
        }

        private void listBox1_SelectedIndexChanged(object sender, EventArgs e)
        {

        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }
        public SqlConnection con = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=|DataDirectory|\AP_SCAN_DATA.mdf;Integrated Security=True");
        private void button3_Click(object sender, EventArgs e)
        {
            

            using (SqlConnection connection = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=|DataDirectory|\AP_SCAN_DATA.mdf;Integrated Security=True"))
{
    using (SqlCommand command = new SqlCommand())
    {
        command.Connection = connection;            // <== lacking
        command.CommandType = CommandType.Text;
        command.CommandText = "INSERT into LOCATIONSCAN ((Scan[i].SSID),(Scan[i].MAC), (Scan[i].RSSi)) VALUES (@SSID, @MAC, @RSSi)";
        command.Parameters.AddWithValue("@SSID", listBox1);
        command.Parameters.AddWithValue("@MAC", listBox2);
        command.Parameters.AddWithValue("@RSSi",listBox3);

        try
        {
            connection.Open();
            int recordsAffected = command.ExecuteNonQuery();
        }
        catch(SqlException)
        {
            // error here
        }
        finally
        {
            connection.Close();
        }
    }
}





        }
       
    }
}

Wendelius12-Feb-15 18:31

Wendelius

12-Feb-15 18:31

If I understood your question correctly, you should execute the insert statement inside the DataReceivedHandler method. Currently the user needs to push a button in order for a single insert to happen.

So remodel the logic so that the insert happens whenever you have new data ready AND you have a permission to insert (from a boolean variable). The button then again should just toggle the permission. So for this you need a single boolean variable and the button click will change it's value.

Olu_0112-Feb-15 23:17

12-Feb-15 23:17

Sorry if i was not clear with my question .
The WIFI AP scan data is been received every 1500 millicesonds i want to push the button once to insert data into rows this could be upto 20 rows. and i want to then push the button to stop inserting data
i hope this made it a little clearer

Wendelius13-Feb-15 3:01

Wendelius

13-Feb-15 3:01

Thanks for the additional explanation but again, shouldn't you use the button to toggle the saving on and off and let the data gathering insert the data whenever new data arrives?

Olu_0116-Feb-15 12:16

16-Feb-15 12:16

thanks

Chris Quinn13-Feb-15 0:29

Chris Quinn

13-Feb-15 0:29

Have the button toggle a Boolean value (i.e. On/Off), and at the end of the routine that reads the data, put a conditional call that calls the Add routine only if the Boolean value is set to on.

=========================================================
I'm an optoholic - my glass is always half full of vodka.
=========================================================

Olu_0116-Feb-15 12:15

16-Feb-15 12:15

Thanks I will try this