|
|
Ho my....  
|
|
|
|
|
Would you perhaps be interested in buying a bridge? Or maybe you are willing to help out in a small transaction from Nigeria?
If only the NASA had known about airtight bedsheets, they would not have had to spend as much money on space suits for their astronauts. 
The language is JavaScript. that of Mordor, which I will not utter here
I hold an A-7 computer expert classification, Commodore. I'm well acquainted with Dr. Daystrom's theories and discoveries. The basic design of all our ship's computers are JavaScript.
|
|
|
|
|
What if I told you the husband was MM?
|
|
|
|
|
Nah, he ain't Clint Eastwood[^].
The language is JavaScript. that of Mordor, which I will not utter here
I hold an A-7 computer expert classification, Commodore. I'm well acquainted with Dr. Daystrom's theories and discoveries. The basic design of all our ship's computers are JavaScript.
|
|
|
|
|
That's looks like a fake news website, but the (f)article sure is funny.
"Real men drive manual transmission" - Rajesh.
|
|
|
|
|
Pity it's a fake - if the seal had been "airtight" then the flatulence could not have "displaced all the available oxygen" as it would have had no-where to go...
|
|
|
|
|
No[^] (see the second busted thing). Also, it's a satire site.
|
|
|
|
|
It might not be true, but it sure gives me a lot of good ideas... 
Anything that is unrelated to elephants is irrelephant
Anonymous
-----
Do not argue with an idiot. He will drag you down to his level and beat you with experience
Greg King
-----
I always wanted to be somebody, but now I realize I should have been more specific.
Lily Tomlin, Actress
|
|
|
|
|
This expression is of no respect for dutch people.
I wish I had never read this crap.
A gentleman is someone who can play the bag-pipe, and who does not.
|
|
|
|
|
Yet you don't think you should write 'Dutch' with a capital D?
|
|
|
|
|
Maybe I should. As english is not my native language, I may have to.
But I think it doesn't change the point I wanted to make.
Women are composed of carbon, hydrogen, oxygen and nitrogen; men are also composed of carbon, hydrogen, oxygen and nitrogen, but in such proportions that force respect.
|
|
|
|
|
I doubt it. I think it's an "onion" piece.
If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering.-Wernher von Braun
Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein
|
|
|
|
|
I am quite keen on doing code reviews at my current place of employment - although I have not worked anywhere that does code reviews before.
My belief is that code reviews will help ensure standards are kept, enhance the learning of all the developers, and help drive any changes in standards.
The other developers think it is a waste of time except for new developers having their code reviewed (presumably until they can be trusted)
Your thoughts/experiences/advice?
As a blatant gamble for more points, vote this message up if you think Code reviews are a Good Thing, and down if you think they are the devil's work!
MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011
.\\axxx
(That's an 'M')
|
|
|
|
|
|
tldr
MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011
.\\axxx
(That's an 'M')
|
|
|
|
|
+1
Code review is one of the hardest things to do and the most valuable.
Most of the time the code reviewed is really simple and you just have to nit-pik; but sometimes you get the "mother-load" and get some code that you really are not familiar with and then you spend a lot of time just understanding the "domain" and the algorithms before digging in the actual code.
I'd rather be phishing!
|
|
|
|
|
Reviewing other people's code is fun to an extent exponentially related to the size of their ego and organizational title.
yours, Bill
"What Turing gave us for the first time (and without Turing you just couldn't do any of this) is he gave us a way of thinking about and taking seriously and thinking in a disciplined way about phenomena that have, as I like to say, trillions of moving parts.
Until the late 20th century, nobody knew how to take seriously a machine with a trillion moving parts. It's just mind-boggling." Daniel C. Dennett
|
|
|
|
|
I hear you!
Already getting the "my code doesn't need to be reviewed" from a couple!
MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011
.\\axxx
(That's an 'M')
|
|
|
|
|
Spot on 
“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
|
|
|
|
|
In general I have good experience with code reviews - not as much as a tool for discovering bug as a mechanism for sharing knowledge.
However, as with most things in software engineering, you shouldn't go overboard with them. I've been in situations where code reviews were taking ridiculous amount of time and energy. In most cases, a code review should take one round of comments and responses, and the committer should be allowed to disregard the comments unless he/she is a junior developer.
|
|
|
|
|
I can't agree more.
Sadly I have been mostly at companies which did it wrong and were code reviews took days. They actually didn't code reviews, they looked at how they should have built it and then tell you you did it wrong. If you didn't comply with the architecture, that wouldn't have been a problem ofcourse, but the code always complied.
The there-are-multiple-ways-to-Rome idea missed its road from their building to Rome, because they really didn't get it and always complained they didn't have enough time to do their work, because they had to review everything...
A good code review looks for any problems, any deviations from required standards and some tips/hints. You should clearly separate those groups of comments. Problems and deviations need to be fixed. Tips/hints should be considered helpful and not a kick in the butt.
|
|
|
|
|
Nemanja Trifunovic wrote: and the committer should be allowed to disregard the comments
Review ticket items should be categorized as one of the following
- security bug
- bug
- comment
- well done
Security bugs must be fixed before the code goes to production. And it must be reviewed for the fix.
Bugs can be triaged but with the goal to fix.
Comments are suggestions about alternate ways to do something. There need not be any action at all.
Well done (or create your own term) is an indication that the reviewer really likes the way a piece of code works.
|
|
|
|
|
I've been a developer for several decades. I get value from my code being reviewed by others.
My ideas on reviewing of other people's code should be obvious.
====
On a related note, one of my observations is that every contributor will search until they find something to criticize. One of my review techniques (for my code submissions) is to make sure that there is at least one blatant mistake that everybody can find, which can be "fixed" with a trivial action on my part; else if your submission is truly close to perfect, you will get several new requirements to add wheel spinning features that have little (or negative) value.
Windows 8 is the resurrected version of Microsoft Bob. The only thing missing is the Fisher-Price logo.
- Harvey
|
|
|
|
|
A few of my thoughts:
1) Code reviews are good.
2) If you think your code doesn't need to be reviewed - Then it needs to be reviewed
3) As you said, code reviews are for everyone, Say you write perfect code, what better way for someone else to learn something they didnt know of
4) More and more, static analysis tools can check for coding standards, unfortanately most of the comments in reviews relate to naming conventions and comments :/
5) I like to focus on correctness of code and design for integration with the system and future maintainability.
To know and not do, is not yet to know
http://www.codeofthedamned.com
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
