C / C++ / MFC

Reference to a variable that goes out of scope

18-Apr-12 2:07

mir5465 wrote:
...active control that have a dialog.

Do you mean that you have an ActiveX control that is on a dialog?

mir5465 wrote:
but i cann't to move it as mfc controls

Meaning what exactly?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

elelont217-Apr-12 11:26

elelont2

17-Apr-12 11:26

int *pi;
  {
    int i = 3; 
    pi = &i;
  }
  std::cout << *pi << std::endl;

I figure that the *pi value in std:cout can not be trusted since i goes out of scope and the address of i can be used for other stuff. Is that correct?

Thank

Aescleal17-Apr-12 13:10

Aescleal

17-Apr-12 13:10

Yep, that's right. It's also why you should never return references to local variables - what they're based on disappears at the end of the block they're declared in.

Cheers,

Ash

Erudite_Eric17-Apr-12 22:31

Erudite_Eric

17-Apr-12 22:31

It depends on stack usage.

If you return a local var thats now out of scope to a func that eats the stack it will get munged. If not, it is still there, but its is risky of course.

Actually we found a windows bug that did just this. It returned a local var. This was OK till we hooked the func, and thus increased its tack usage.

In your case i is out of scope at code level, but is still on the stack since you havent returned from your func yet (your code is actually compiled with i on the stack just after pi).

--edit--

I see no one has responded. I guess an understanding of assembler (ie, the way code actually compiles) is totally foreign territory to todays 3G coders.

==============================

Nothing to say.

modified 19-Apr-12 2:43am.

Stefan_Lang20-Apr-12 4:10

Stefan_Lang

20-Apr-12 4:10

Erudite_Eric wrote:
It depends on stack usage.

AFAIK it doesn't so much depend on stack, but on the runtime libraries used: if they choose to invalidate a memory address as soon as it goes out of scope, then code like this will crash with an access violation. It may depend on compiler settings, but I've never seen code like that actually work on Windows XP or 7.

Then again I never deliberately tried Wink | ;)

[solved ]: 'MAKEINTRESOURCE' - Not Working Properly

Erudite_Eric20-Apr-12 22:04

Erudite_Eric

20-Apr-12 22:04

No, it isnt to do with libraries, but the very way local variables are allocated, ie, on the stack. This is only unwound, upwards dont forget, when the func the variables are declared in returns. Thats when the memory can be reused, by calling another func that declares its own variables.

So if you look at assembler you will see stuff like ebp+4 being set to a value. This is a local variable. At the end you see a ret 4. This returns from the func and winds the stack back by the same number as the size of the local variables declared.

==============================

Nothing to say.

AmbiguousName17-Apr-12 0:31

17-Apr-12 0:31

hello guys... I have this dialogbox whose name I am trying to get. I have added a new dialogbox to the project using Add->Resource, so this gets an ID automatically, in the resource.h file. But when I use MAKEINTRESOURCE macro by providing resource id to get its name, it does not return it. It gives an assertion. What can be wrong here? thnx for any input.

This world is going to explode due to international politics, SOON.

modified 18-Apr-12 1:11am.

David Crow17-Apr-12 3:10

17-Apr-12 3:10

overloaded Name wrote:
It gives an assertion.

Which is?

AmbiguousName17-Apr-12 5:31

17-Apr-12 5:31

plz refer to my answer below Smile | :)

This world is going to explode due to international politics, SOON.

Richard MacCutchan17-Apr-12 4:49

Richard MacCutchan

17-Apr-12 4:49

MAKEINTRESOURCE does not get the name, it merely casts the integer value to a pointer. However, that is neither here nor there, the important question is what assertion you get and which line of code does it occur on.

Binding 100,000 items to a list box can be just silly regardless of what pattern you are following. Jeremy Likness

AmbiguousName17-Apr-12 5:31

17-Apr-12 5:31

Assertion Shown: Debug Assertion Failed

Context of the program: actually I am adding CPropertyPages to CPropertySheet. Now when I pass the property page's IDD to CPropertyPage's constructor, there this macro can not cast this integer value to LPCTSTR (the resource type). Here is what the constructor looks like

C++

CString1Dlg::CString1Dlg(CWnd* pParent /*=NULL*/): CPropertyPage(CString1Dlg::IDD)
{
}

Now the point where it shows this assertion, looks like this.

C++

CPropertyPage::CPropertyPage(UINT nIDTemplate, UINT nIDCaption, DWORD dwSize)
{
	ASSERT(nIDTemplate != 0);
	AllocPSP(dwSize);
	CommonConstruct(MAKEINTRESOURCE(nIDTemplate), nIDCaption);
}

I debugged the application and know that nIDTemplate contains the ResourceId. Now MAKEINTRESOURCE here, does not convert this ID to corresponding resource type. Thats why I asked this question. During debuggin I came to know that MAKEINTRESOURCE is not working but in the first place, the assertion is shown in afxwin1.inl - line 24, where code looks like this.

C++

_AFXWIN_INLINE HINSTANCE AFXAPI AfxGetResourceHandle()
{ 
   ASSERT(afxCurrentResourceHandle != NULL);
   return afxCurrentResourceHandle; 
}

I hope I was able to clear the picture.

This world is going to explode due to international politics, SOON.

David Crow17-Apr-12 5:37

17-Apr-12 5:37

overloaded Name wrote:
Context of the program: actually I am adding CPropertyPages to CPropertySheet.

Which you should probably be doing in the sheet's constructor. Something like:

CMySheet::CMySheet(CWnd* pParentWnd /* =NULL */, UINT iSelectPage /* =0 */)
    :CPropertySheet(IDS_CAPTION_FRUITS, pParentWnd, iSelectPage)
{
    AddPage(&m_page1);
    AddPage(&m_page2);
    AddPage(&m_page3);
    AddPage(&m_page4);
}

AmbiguousName17-Apr-12 5:51

17-Apr-12 5:51

DavidCrow wrote:
Which you should probably be doing in the sheet's constructor

Yes. I have done that too. But eventually, the assertion is shown using that method too.

This world is going to explode due to international politics, SOON.

David Crow17-Apr-12 6:01

17-Apr-12 6:01

Then something else is fundamentally wrong. Other than calling AddPage() in the sheet's constructor, and creating a dialog template for each page, that's all there is to it. Since you are not getting a compiler/linker error, we can assume there is a CPropertyPage-derived object in the sheet's .h file for each page you want added.

AmbiguousName17-Apr-12 6:07

17-Apr-12 6:07

C++

class CString1Dlg : public CPropertyPage
{
// Construction
public:
	CString1Dlg(CWnd* pParent = NULL);	// standard constructor

// Dialog Data
	enum { IDD = IDD_STRING1_DLG };

///rest of the code down there.

Comparison of this code with previous one can be done here.

This world is going to explode due to international politics, SOON.

David Crow17-Apr-12 6:39

Re: 'MAKEINTRESOURCE' - Not Working Properly [modified]

17-Apr-12 6:39

Are you working with a DLL or EXE?

AmbiguousName17-Apr-12 6:57

Re: 'MAKEINTRESOURCE' - Not Working Properly [modified]

17-Apr-12 6:57

EXE . This is solved now. As I said in earlier posts, Resource was missing. I was instantiating my CPropertySheet class in the wrong place. I was doing so in the constructor of my APP file like this.

C++

CxyzApp::CxyzApp()
{
  // some other code if you like
  // ... ... ..
  MySheet sheet = new MySheet(_T("My Sheet"));
}

But this was wrong. Controls are not loaded until InitInstance() is called. I should have instantiated my sheet class in the InitInstance() of APP like this

C++

BOOL CxyzApp::InitInstance()
{
  // some other code
  SetRegistryKey(_T("Local AppWizard-Generated Applications"));

  MySheet = new CEmplSheet(_T("My Sheet"));
  if(MySheet != NULL)
    m_pMainWnd = MySheet;
}

Thank you for you time.

This world is going to explode due to international politics, SOON.

David Crow18-Apr-12 5:08

18-Apr-12 5:08

overloaded Name wrote:
I should have instantiated my sheet class in the InitInstance() of APP like this

Or you could have waited to construct the sheet object until it was actually called for. For example:

void CxyzApp::SomeFunction( void )
{
    CEmplSheet sheet(_T("My Sheet"));
    sheet.DoModal();
}

[SOLVED] Accelerator key issue

Richard MacCutchan17-Apr-12 7:08

Richard MacCutchan

17-Apr-12 7:08

overloaded Name wrote:
Now MAKEINTRESOURCE here, does not convert this ID to corresponding resource type.

It's not supposed to convert it to anything, it merely casts its type to the appropriate LPSTR so that the receiving function's definition is satisfied. The key issue is whether the value is correct and identifies a valid dialog template.

Binding 100,000 items to a list box can be just silly regardless of what pattern you are following. Jeremy Likness

David Crow16-Apr-12 6:13

16-Apr-12 6:13

I've got an SDI application created with VS2008. After some of the submenu item captions, I've added the tab escape sequence (\t) followed by the accelerator key I want (e.g., F2, F5). Visual Studio menu editor shows this correctly. The accelerator key table has also been updated. When I run the program, the submenu options work fine, but the accelerator keys do not show up in the submenu. Any obvious reason for this?

[edit]
It has something to do with a plain SDI app vs. one with a style and/or menu bar. I created another SDI app but opted for the standard style and the classic menu. My F5 accelerator key showed at run time.
[/edit]

modified 18-Apr-12 12:20pm.

jkirkerx17-Apr-12 6:50

jkirkerx

17-Apr-12 6:50

I didn't quite understand the question, you mean the F5 key is not doing it's thing, or F5 is not showing up in the SubMenu after the value?

Sub Menu Value\t Ctrl-F5

Mine work fine, but I did have trouble at first with the TranslateAccelerator function and loading 2 Accelerators tables at the same time, one for the Menu Bar and Another for Ctrl-F2, stuff not in the menu bar.

http://msdn.microsoft.com/en-us/library/windows/desktop/ms646337%28v=vs.85%29.aspx#creating_acc_table[^]

David Crow17-Apr-12 7:44

17-Apr-12 7:44

jkirkerx wrote:
I didn't quite understand the question, you mean the F5 key is not doing it's thing, or F5 is not showing up in the SubMenu after the value?

The latter.

jkirkerx17-Apr-12 8:30

jkirkerx

17-Apr-12 8:30

I'm not at your skill level, but I would create a new project as a test, and add the \t F5, and see if you get the same result.

David Crow17-Apr-12 9:31

17-Apr-12 9:31

jkirkerx wrote:
...I would create a new project as a test, and add the \t F5, and see if you get the same result.

Same result. I created a new SDI project, ran it without any mods, and I see the stock set of accelerator keys in the submenus. So I created a menu and added a few submenu items, each with an accelerator key. For simplicity, I deleted IDR_MAINFRAME, and renamed my menu to IDR_MAINFRAME. Running the app now shows my menu and submenus but does not show the accelerator keys. Confused | :confused:

I took it one step further and rather than create a new menu to replace a stock one, I simply made a change to the IDR_MAINFRAME menu. For the Save option, I changed Ctrl+S to F2. While F2 shows up in the menu editor next to Save, when I run the app, Ctrl+S still shows up next to Save in the File menu. I also added F3 to one of the Office themes in the View menu. It does not show up at all. I've looked at the project's .rc file in Notepad and there's no sign of Ctrl+S. I've cleaned the project so it rebuilt everything.

modified 17-Apr-12 15:51pm.