Click here to Skip to main content
15,892,804 members
Articles / Programming Languages / C#
Alternative
Tip/Trick

Extension Methods to Reverse a String and StringBuilder Object

Rate me:
Please Sign up or sign in to vote.
4.83/5 (5 votes)
1 Jan 2011CPOL 11.4K   3
This is an alternative to "Extension Methods to Reverse a String and StringBuilder Object".

Less code, and much faster, would be:

C#
public static string ReverseSB(string text) {
    int len = text.Length;
    if (len>1) {
        StringBuilder sb=new StringBuilder(text);
        int pivotPos=len/2;
        len--;
        for (int i = 0; i < pivotPos; i++) {
            int j=len-i;
            char temp=sb[i];
            sb[i]=sb[j];
            sb[j]=temp;
        }
        text=sb.ToString();
    }
    return text;
}

or its extension-method variant. Tested on a 80-char string, it is 8 times faster. The reason should be clear: John's code creates 6 strings for each character pair, as each SubString, Remove, Insert method generates a new string object, copying the relevant characters.

:)

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)


Written By
Software Developer (Senior)
Belgium Belgium
I am an engineer with a background in electronics, software and mathematics.

I develop technical software, both for embedded systems and for desktop equipment. This includes operating systems, communication software, local networks, image processing, machine control, automation, etc.

I have been using all kinds of microcontrollers and microprocessors (Intel 4004/8080/8051/80386/Pentium, Motorola 680x/680x0/ColdFire/PowerPC, Microchip PIC, Altera NIOS, and many more), lots of programming languages (all relevant assemblers, Fortran, Basic, C, Java, C#, and many more), and different operating systems (both proprietary and commercial).

For desktop applications and general development tools I have been using both UNIX systems and Mac/MacOS for many years, but I have switched to x86-based PCs with Windows, Visual Studio and the .NET Framework several years ago.

I specialize in:
- cross-platform development (making software that runs on diverse hardware/OS combinations)
- instruction set simulation
- improving software performance, i.e. making sure the software runs the job at hand in as short a time as possible on the given hardware. This entails algorithm selection, implementation design, accurate measurements, code optimisation, and sometimes implementing virtual machines, applying SIMD technology (such as MMX/SSE), and more.

Comments and Discussions

 
GeneralAhh yes, you most certainly did. :) Pin
#realJSOP1-Jan-11 5:45
mve#realJSOP1-Jan-11 5:45 
GeneralI did in the line <code>len--;</code> Pin
Luc Pattyn1-Jan-11 5:26
sitebuilderLuc Pattyn1-Jan-11 5:26 
GeneralIn yours, j will create an exception on the first character ... Pin
#realJSOP1-Jan-11 5:11
mve#realJSOP1-Jan-11 5:11 
In yours, j will create an exception on the first character swap. You have to subtract 1 from len-i for it to succeed. And to be fair, I did mention that calling the StringBuilder version from the string version would be better.

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.