|
He showed he tried something , whether it is homework or not is irrelevant.
V.
|
|
|
|
|
What if the assignment was "optimize this (provided) code"?
Regardless, your other post seems to point him in the right direction.
|
|
|
|
|
If don't want to say how i can do it or give idea for it write this. I've written this this function for my programm but they are big. I'd like to know how i can do it use less actions. Maybe anyone has idea How i can do it.
|
|
|
|
|
I don't know this game, but here are some pointers:
1. Always use { and } even on single statements.
2. Avoid multiple returns
3. As I said, but why are you using and IsEmpty boolean array which I assume is 'synchronized' with the labels array? You can pass your labels array and check whether the label is empty or not. eg( string.IsNullOrEmpty(lbl_array[x,y].Text) )
4. You don't check if x and or y is within the array size, you can get an arrayindexoutofboundsexception error
5. You hardcode all variables, if you want to change the game to a 10*10 matrix you'll have a fun time changing all the variables.
6. make sure you name your variables so they mean something. I have no idea what fx, fy, sx, sy, ftx, fty, ... are for.
7. One statement, one line avoid: sdx--; sdy--;
this should help you already.
Don't mind the homework remark, you showed you tried something yourself, whether it is homework or not is irrelevant.
V.
|
|
|
|
|
Those don't really have anything to do with optimisation, and most of them (1, 2, 6 and 7) are matters of opinion, of which I only agree with one (6, and even then, those names might well be meaningful if you know the game).
|
|
|
|
|
BobJanova wrote: Those don't really have anything to do with optimisation
Depends on what you mean with optimisation.
BobJanova wrote: which I only agree with one
You don't have to agree, but I wouldn't want to debug your code if you write it like that. (I'm not saying your code is bad nor is it wrong)
V.
|
|
|
|
|
BobJanova wrote: of which I only agree with one
Then you are missing good code standards used by most professionals
I know the language. I've read a book. - _Madmatt
|
|
|
|
|
I'm not missing them, I just don't agree with them 
(Or, to be less glib, they come from good principles, but when applied as fixed rules, they make things less readable, generally by expanding the code so that you can't see the pattern of it any more. In the case of the example posted here, decrementing both the x and y variables in one line makes sense because it's one thought, for example.)
There is nothing wrong with multiple returns, though. Checking a condition within a foreach loop and returning when it's hit is quite common and perfectly readable (arguably more so than assigning to a variable and breaking since you can see that it's an exit point).
|
|
|
|
|
To each there own. There is no learning when the mind is closed. Hope I don't have to pick any code you have been working on.
I know the language. I've read a book. - _Madmatt
|
|
|
|
|
"There is no learning when the mind is closed."
Quite. I'm glad you agree with me that fixed rules such as those I was responding to are not a good idea, and one should keep an open mind as to what the situation you're coding for requires.
|
|
|
|
|
V. wrote: You can pass your labels array
Not if you need to do a search to find your best next move. I'd use an int.
|
|
|
|
|
First of all, I'd ask you whether or not optimisation is really necessary. Quite often you'll spend a lot of time looking for optimisations which, strictly speaking, aren't necessary. You may save a clock cycle here or a clock cycle there, but it's not noticeable.
As for optimisations, the most obvious one that I see lies here:
if (Action[i, j] && !IsEmpty[sdx, sdy] && sdx == ftx && sdy == fty)
return true; Please though give your variables better names, and use { } to wrap code sections; I had real trouble wading through the logic.
|
|
|
|
|
I don't see very much there to optimize while keeping the same data structures.
Using an array of arrays can be faster than a 2D array. Using a BitArray instead of an array of bools is usually faster. If the array is sufficiently small, using the bits in an ulong directly is even faster, and you should probably look up bitboards if this is about a game board (and that's what it is, isn't it?)
edit: if you explain what the code is supposed to do, maybe I can help you sort out bitboard functions.
|
|
|
|
|
I have square 5*5.(Labels array) some of them Empty. other have symbols. bool IsEmpty 5*5 contains true if Lable is Empty or false if label has symbol.
first function:
When i do click on label first function cheks Label[x,y] is empty or not. if it is empty then it checks labels which near it if they have a symbol function return true;
second functions:
for select a word when i do click on labels.
I click on labels programm write cordinats label;
then i click next label function need to check if it has a symb and near first label then return true;
fx,fy are first label
sx,sy are second label
|
|
|
|
|
I'm sorry to say it, but your English wasn't very good so I can easily misunderstand what you mean, so please correct me if I'm wrong.
First function:
bool IsOpenForLetter(int x, int y, ulong isempty)
{
int index = x + 8 * y;
ulong isnotempty = ~isempty;
return ((isempty >> index) &
(isnotempty >> (index + 1)) &
(isnotempty >> (index - 1)) &
(isnotempty >> (index + 8)) &
(isnotempty >> (index - 8)))
!= 0;
}
edit: it doesn't check whether it would go out of bounds, because it isn't needed thanks to the padding.
Second function: I'll try this one later
|
|
|
|
|
Hi,
I have been developing add-ins for MS Word for quite some time now. I usually track bind failures using Fusion Logs and it used to work for all applications. But suddenly, the fusion logs fail to catch any load events for WINWORD.exe. I do not get any entries in my "C:\fusionlog\DEFAULT" folder for WINWORD.exe. It works fine for EXCEL.exe, POWERPNT.exe. I wanted to check fusion logs because my addins did not load in MS Word but the addins loaded in Excel and PowerPoint. Could anyone please help?
Thanks,
Ram
|
|
|
|
|
Hi,
I've the following XML-
<MessageParts xmlns="http://www.address.com">
<Status xmlns="">
.
.
.
.
<Data>
<PersonsMin xmlns="some attribute">
.
.
.
<Parts>
.
.
.
</Parts>
</PersonsMin>
</Data>
</Status>
</MessageParts>
I'me trying to get all the elements in PersonsMin.
var query = from response in xmlDoc.Elements("PersonsMin")<br />
select response;
But i'm getting "Sequence contains no elements".
What i'm doing wrong?
|
|
|
|
|
treuveni wrote: What i'm doing wrong?
That's fairly simple, you've forgotten to add the XML namespace to the query. Typically you would do this using
XNamespace myNamespace = "some namespace";
var query = from response in xmlDoc.Elements(myNamespace + "PersonsMin")
select response;
|
|
|
|
|
Pete O'Hanlon wrote: you've forgotten to add the XML namespace to the query
Like this?
XNamespace myNamespace = "some attribute";<br />
var query = from response in xmlDoc.Elements(myNamespace + "PersonsMin")<br />
select response;
XNamespace is the XAttribute?
|
|
|
|
|
Whereever you see xmlns in your XML, that's the namespace that you need to include to pick it up.
|
|
|
|
|
Pete O'Hanlon wrote: Whereever you see xmlns in your XML, that's the namespace that you need to
include to pick it up.
Still same error
"Sequence contains no elements"
|
|
|
|
|
Try this:
var query = from response in xDoc.Descendants(ns + "PersonsMin")
select response;
|
|
|
|
|
Hi ,
Is there anyway to find a set of words together on visual studio ?.For eg. I need to find 'egg' and 'chicken' together.Could you please let me know .
With regards.
|
|
|
|
|
If you mean the occurrence of these words in your source code then use one of the Edit->Find and Replace ... options from the menu.
If you mean in your resulting program then you will have to write the code yourself.
The best things in life are not things.
|
|
|
|
|
So I didn't have time to look into this exception in detail today. If no one can answer due to the vague nature that's okay. I just thought I could ask and possibly receive some general guidance for in the morning.
Anyhow, I am using C# (.NET 4.0, VS2010) to connect to a MS Access 2007 (.accdb) database. The database includes two tables, "Repairs" and "Scrap Codes". The Repairs table includes a field, "Scrap Code", which does a look-up for values using the Scrap Codes table. All works well within Access. I can successfully insert records (through my software) including a value for the Scrap Code field. I have checked the data in Access to verify proper data is inserted; success.
However, when I execute a simple statement within my software:
<br />
---- To retrieve the most common Scrap Code ----<br />
<br />
SELECT TOP 1 [Scrap Code] FROM Repairs<br />
WHERE [Failure Code]=13<br />
GROUP BY [Scrap Code]<br />
ORDER BY Count(*) DESC<br />
where "Failure Code" is another look-up column in the Repairs table, I receive an exception. In the exception dialog that I receive (the JIT box), instead of displaying a description above the Details button, it simply says "Scrap Codes.", the table name. If the possibilities are not too vague could you please provide a few likely culprits?
Now, if the "Scrap Code" field for EVERY record in Repairs is empty, however, I do not run into this issue at all. But if I set a value for "Scrap Code" on any number of records I get this error.
I will have time to look at it in depth tomorrow morning. But I felt the need to ask because it is going to bother me all night. Haha.
Thanks in advance,
Matt U.
[SOLUTION]
There was a typo in the statement. I had an extra letter at the end of the "Scrap Code" field, in the "Repairs" table. Problem solved.
modified on Thursday, June 16, 2011 6:18 PM
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
