Click here to Skip to main content
15,897,273 members
Home / Discussions / C / C++ / MFC
   

C / C++ / MFC

 
QuestionStatic class members Pin
csrss15-May-11 5:37
csrss15-May-11 5:37 
AnswerRe: Static class members Pin
Luc Pattyn15-May-11 5:46
sitebuilderLuc Pattyn15-May-11 5:46 
GeneralRe: Static class members Pin
csrss15-May-11 6:02
csrss15-May-11 6:02 
AnswerRe: Static class members Pin
Richard MacCutchan15-May-11 7:13
mveRichard MacCutchan15-May-11 7:13 
GeneralRe: Static class members Pin
csrss16-May-11 5:43
csrss16-May-11 5:43 
AnswerRe: Static class members Pin
Niklas L16-May-11 0:42
Niklas L16-May-11 0:42 
GeneralRe: Static class members Pin
csrss16-May-11 5:46
csrss16-May-11 5:46 
GeneralRe: Static class members Pin
Stefan_Lang17-May-11 0:48
Stefan_Lang17-May-11 0:48 
Then my guess was right, your construct is indeed meant as a way to implement a singleton.

This is wrong on so many accounts:

1. If you deal with multiple threads, this won't be thread safe
2. By making all your functions static, you give the false impression that these functions will not modify the internal state of your program, while in truth several effectively global parameters are being modified. Anyone else seeing and trying to use these functions may quite easily introduce fatal errors into the system.
3. Since your constructor creates the instance that you need, if that constructor is being called multiple times, your pointer will be overwritten, and you lose the current state of your application irrevokably.
4. Replacing function parameters with global variables is bad design. It will lead to functions producing different results with same parameters, making them effectively untestable.
GeneralRe: Static class members Pin
csrss17-May-11 5:38
csrss17-May-11 5:38 
GeneralRe: Static class members Pin
Stefan_Lang17-May-11 6:18
Stefan_Lang17-May-11 6:18 
AnswerRe: Static class members Pin
Stefan_Lang16-May-11 3:03
Stefan_Lang16-May-11 3:03 
GeneralRe: Static class members Pin
csrss16-May-11 5:52
csrss16-May-11 5:52 
GeneralRe: Static class members [modified] Pin
Stefan_Lang16-May-11 6:11
Stefan_Lang16-May-11 6:11 
QuestionCreating a window without focus [modified] Pin
csrss15-May-11 2:25
csrss15-May-11 2:25 
AnswerRe: Creating a window without focus Pin
Luc Pattyn15-May-11 2:45
sitebuilderLuc Pattyn15-May-11 2:45 
GeneralRe: Creating a window without focus Pin
csrss15-May-11 2:50
csrss15-May-11 2:50 
AnswerRe: Creating a window without focus Pin
Alain Rist15-May-11 3:43
Alain Rist15-May-11 3:43 
GeneralRe: Creating a window without focus Pin
csrss15-May-11 4:57
csrss15-May-11 4:57 
QuestionHow to get the keyboard event? Pin
sharanu14-May-11 23:06
sharanu14-May-11 23:06 
AnswerRe: How to get the keyboard event? Pin
«_Superman_»15-May-11 2:00
professional«_Superman_»15-May-11 2:00 
AnswerRe: How to get the keyboard event? Pin
Mark Salsbery15-May-11 8:39
Mark Salsbery15-May-11 8:39 
QuestionEdit Text Pin
john563214-May-11 22:46
john563214-May-11 22:46 
AnswerRe: Edit Text Pin
Mark Salsbery14-May-11 22:58
Mark Salsbery14-May-11 22:58 
AnswerRe: Edit Text Pin
Hans Dietrich14-May-11 23:08
mentorHans Dietrich14-May-11 23:08 
AnswerRe: Edit Text Pin
Alain Rist14-May-11 23:15
Alain Rist14-May-11 23:15 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.