Re: Wave files - C# Discussion Boards

Bernhard Hiller5-Aug-10 1:45

Bernhard Hiller

5-Aug-10 1:45

I guess the cast to byte makes a problem - isn't 8bit mono sound written as unsigned bytes? Try 16bit sound, that's (signed) Int16.

V.5-Aug-10 2:00

5-Aug-10 2:00

It's all 16 bit sound, all info past as int. Why do you think it's 8 bit? I at least defined it as stereo, 16 bit, 44100KHz sample rate.
I tried to inverse the frequency (1/freq) which seems to clean up the noise, yet it remains dirty. (other frequency tests show that I at least have to inverse the freq, else the pitch is not the same at all)

thanks for the idea.

OriginalGriff5-Aug-10 2:03

OriginalGriff

5-Aug-10 2:03

V. wrote:
Why do you think it's 8 bit?

Well the byte cast in your OP was a clue:

(byte)(256 * Math.Sin(frequency * i));

That may be your problem - if it is byte data you are handing to a function expecting 16 bit then it could go all odd...

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

V.5-Aug-10 2:14

5-Aug-10 2:14

MMM, I don't think so, the entire thing is written to file as a byte array (logical, it's a binary file Wink | ;-)

, but only when all else is set.
Here's the code:

public void PlayNoteWav(string note, int position)
{

    //I think the hardware only allows one beep at the time.
    //I would need to find a way to 'produce' a sound via the speakers instead of via a beep.
    //http://naudio.codeplex.com/
    //http://www.csharp-home.com/index/tiki-read_article.php?articleId=105
    //DIrectSound?
    Dictionary<int, double> played_note = guitar_strings[note];
    if (position >= 0)
    {
        double frequency = played_note[position];
        CreateWaveFile(frequency, duration);
    }                                               //end if
    else
    {
        System.Threading.Thread.Sleep(duration);
    }                                               //end if
}

public void CreateWaveFile(double frequency, int duration)
{
    bool whiteNoise = false;
    Random rand = new Random();

    file = new WaveFile(2, 16, 44100);

    int samples = 44100; //Creates 1 second of audio


    // Sound Data Array
    // Size needs to be :
    //          Number Of Channels - 1 for mono
    //                               2 for stereo
    //          Bits Per Sample    - How many bits are used to describe each Sample
    //          Samples            - How many samples that are provided
    //
    // Sound Data Size = Number Of Channels * Bits Per Sample * Samples

    /*  f:x -> a*sin(b*(x-c)) + d
     * a = amplitude
     * b = frequency
     * c = phase
     * d = move up/down Y-axis
     */

    byte[] data = new byte[file.NumChannels * (file.BitsPerSample / 8) * samples];

    if (whiteNoise)
    {
        //Creates White Noise
        for (int i = 0; i < data.Length; i++)
        {
            data[i] = (byte)rand.Next(256); //256 is the max size of a byte
        }
    }
    else
    {
        //Creates a Constant Sound
        for (int i = 0; i < data.Length; i++)
        {
            data[i] = (byte)(256 * Math.Sin(1/frequency * i));
        }
    }
    file.SetData(data, samples);
    file.WriteFile(@"C:\Test.wav"); //Writes the wave file out to the destination given
}

Generally in the background it will hold all the information before writing to file.
Doesn't this statement:

byte[] data = new byte[file.NumChannels * (file.BitsPerSample / 8) * samples];<br />

take in account 16 bit sound (if bitspersample is set to 16) ?

In any case I'll have a go with setting to 8 bits mono, just for testing.

thanks.

OriginalGriff5-Aug-10 2:24

OriginalGriff

5-Aug-10 2:24

Yes, but if as your code indicates, it is 16 bits per sample, why are you generating 8 bit samples and loading them into successive bytes?
It means you file ends up with 16 bit samples made of two 8 bit bytes with the same frequency value. Should you not be using short or ushort values instead?

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

Luc Pattyn5-Aug-10 2:41

Luc Pattyn

5-Aug-10 2:41

I'm pretty sure there are several errors here.

1.
if your samples are 16-bit you should use 16-bit quantities everywhere; so either work with a short array, or convert the intended short values to their upper and lower byte values; what you have basically is 8-bit samples.

2.
if your sound is to be stereophonic, you should generate two signals (e.g. two distinct sine waves) and alternate their samples; what you have is a single sine wave where consecutive samples are sent to the left and right channel, that isn't real stereo at all, there is just a small phase shift between left and right.

3.
if frequency is intended to indicate the tone pitch in Hertz, you need a conversion factor, probably 2*Math.Pi to make that happen. A sine wave goes one full cycle when its argument is increased by that amount, not by 1.

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

Re: Wave files [modified]

V.5-Aug-10 3:07

5-Aug-10 3:07

mmm, had to think about it a bit, but (i think) it starts to make sense Wink | ;-)

.

1. OK, so 2 bytes for each value.
2. makes sense
3. I think it should be 1/frequency, 2*PI gave bad results, but maybe that was for another reason Smile | :)

.

If I find the solution I'll let you know.

many thanks.

Luc Pattyn5-Aug-10 3:29

Luc Pattyn

5-Aug-10 3:29

Obviously for higher frequencies, the phase step has to be larger, not smaller, so F is in the numerator.

If you want N sine samples at frequency F spanning a period of 1 second, the phase step should be:

double deltaPhase=2*Math.Pi*F/N;
for(int i=0; i<N; i++) {
    double phase=i*deltaPhase;
    // now use Math.Sin(phase)
}

which means after N steps, your phase has increased by 2*Math.Pi*F, i.e. by F full circles.

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

modified on Thursday, August 5, 2010 9:52 AM

DaveyM695-Aug-10 3:47

DaveyM69

5-Aug-10 3:47

Hi Luc,

I really need to learn this stuff for my ongoing multimedia stuff (yeah, still tweaking and improving it when time allows, the article will follow one day). I understand it all from a musicians perspective but from a coding perspective I've yet to experiment with audio but it's high on my to do list! Thanks for this little insight as it will save me some time Thumbs Up | :thumbsup:

Dave

If this helped, please vote & accept answer!

Binging is like googling, it just feels dirtier.
Please take your VB.NET out of our nice case sensitive forum.(Pete O'Hanlon)

BTW, in software, hope and pray is not a viable strategy. (Luc Pattyn)

Luc Pattyn5-Aug-10 3:58

Luc Pattyn

5-Aug-10 3:58

Hi Dave,

if you need the basics, Wikipedia[^] is quite OK. You'll notice they use ω (omega, the angular frequency), which equals 2*pi*f.

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

V.5-Aug-10 21:04

5-Aug-10 21:04

Thanks, I appreciate the help.
I do understand the theory, but I think I jumped in a little too quickly.

much obliged.

Socket Connection

Agweet4-Aug-10 22:46

Agweet

4-Aug-10 22:46

Hi All,

i am trying to create a socket connection to a server and send it a XML string and receive the results.

For some reason it does not work, here is my code:

XML String: <?xml version="1.0" encoding="UTF-8" standalone="yes"? <MemberLookupRequest><Code>XXX</Code><idNumber>XXXXXXXXXXXXX</idNumber></MemberLookupRequest>

and my socket connection code:

try
{
TcpClient socketForServer;
socketForServer = new TcpClient(xxx.xxx.xxx.xxx, 6000);

socketForServer.SendTimeout = 300000;
socketForServer.ReceiveTimeout = 300000;

NetworkStream networkStream = socketForServer.GetStream();
System.IO.StreamReader streamReader =
new System.IO.StreamReader(networkStream);
System.IO.StreamWriter streamWriter =
new System.IO.StreamWriter(networkStream);
string outputString;
// read the data from the host and display it

streamWriter.WriteLine(XML String goes here);

streamWriter.Flush();

outputString = streamReader.ReadToEnd();

networkStream.Close();

return outputString;
}
catch (Exception ex)
{
return ex.Message.ToString();
}

it shows that i am connected to the server but i don't get any results back.

can anyone please help me with this?

thanks in advance!

living life on the flip side

freakyit5-Aug-10 1:54

freakyit

5-Aug-10 1:54

may be the server will not send data back to the client?!? this piece of code is not very helpfull for a good answer.

first your XML you want to send is corrupt! take a look at the xml-declaration >.

sencond one is that you will read data from the stream without knowing whether data is available or not ^^
use the search function to take a look at articles that work as server/client app..

Ennis Ray Lynch, Jr.5-Aug-10 2:27

Ennis Ray Lynch, Jr.

5-Aug-10 2:27

You are asking for results immediately but results would not be available immediately. You need a read loop to get the number of bytes back you expect from the server.

Need custom software developed? I do custom programming based primarily on MS tools with an emphasis on C# development and consulting. I also do Android Programming as I find it a refreshing break from the MS.

"And they, since they Were not the one dead, turned to their affairs" -- Robert Frost

Member 7906565-Aug-10 2:28

Member 790656

5-Aug-10 2:28

You need to block with

networkStream.Read()

Otherwise the connection closes before you have the oportunity to read data. Wink | ;)

See ms-help://MS.VSCC.v90/MS.MSDNQTR.v90.en/fxref_system/html/b46663bf-ae16-3bd8-73c3-2d057d0868e3.htm

How to Call a Server side Function on the Client side

Agweet5-Aug-10 3:58

Agweet

5-Aug-10 3:58

Hi All,

Thanks for the answers, will take them into account and will post my results.

living life on the flip side

Vimalsoft(Pty) Ltd4-Aug-10 22:04

Re: How to Call a Server side Function on the Client side

4-Aug-10 22:04

Good Day All

i have a Function e.g

public String Getdata(String mystr)

{

//Do what ever

//return  a String

}

and i want to call this function and pass data in Javascript like this

function KeyPress() {
            var TExtbox1 = document.getElementById('Text1');
        
         if (TExtbox1.value.length == 2) {

        //call the function here and pass the textbox1 value.  

   return false;
         }
        }

Thanks

Vuyiswa Maseko,

Spoted in Daniweb-- Sorry to rant. I hate websites. They are just wierd. They don't behave like normal code.

C#/VB.NET/ASP.NET/SQL7/2000/2005/2008
http://www.vuyiswamaseko.com
vuyiswa@its.co.za
http://www.itsabacus.co.za/itsabacus/

Prosanta Kundu online4-Aug-10 22:40

Prosanta Kundu online

4-Aug-10 22:40

You can use PageMethod.

Re: How to Call a Server side Function on the Client side

Vimalsoft(Pty) Ltd4-Aug-10 23:52

Re: How to Call a Server side Function on the Client side

4-Aug-10 23:52

Thanks , Now i have this

On the Server side

[WebMethod, System.Web.Script.Services.ScriptMethod]
public static string Getadata(String Data)
{
  String Scriptt  = "<script>alert('" + Data + "');</script>";
  return Scriptt;
}

function KeyPress() {


      var TExtbox1 = document.getElementById('Text1');
      var Results;
      if (TExtbox1.value.length == 2)
      {
         Results = Getadata(TExtbox1.value);
         alert(Results);
      }
      return false;
  }

and my ScriptManager

<asp:ScriptManager ID="ScriptManager1" EnablePageMethods="true"  runat="server">
</asp:ScriptManager>

but when i run it nothing happens

Thanks

Pete O'Hanlon5-Aug-10 0:07

Pete O'Hanlon

5-Aug-10 0:07

You call Getadata in your javascript. You should call PageMethods.Getadata instead.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Re: How to Call a Server side Function on the Client side

Vimalsoft(Pty) Ltd5-Aug-10 0:16

Re: How to Call a Server side Function on the Client side

5-Aug-10 0:16

Thanks , sorry i missed that, now i have a small problem with my javascript

<br />
     function KeyPress() {<br />
<br />
<br />
            var TExtbox1 = document.getElementById('Text1');<br />
            var Results;<br />
             if (TExtbox1.value.length == 2) {<br />
             <br />
                Results = PageMethods.Getadata(TExtbox1.value);<br />
                alert(Results);<br />
             }   <br />
             return false;<br />
         }<br />

the alert shows me "undefined"

is there anything wrong there ?

Pete O'Hanlon5-Aug-10 1:31

Pete O'Hanlon

5-Aug-10 1:31

That's because a script method doesn't return like this. What you need to do is supply a callback function which your javascript executes. Here's a sample page:

HTML

<%@ Page Language="C#" AutoEventWireup="true" CodeFile="Default.aspx.cs" Inherits="_Default" %>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head runat="server">
  <title>Untitled Page</title>
  <script>
    function keyPress()
    {
      var tb = document.getElementById('Text1');
      if (tb.value.length == 2)
        PageMethods.Getadata(tb.value, myFunction);
      return false;
    }
    function myFunction(msg)
    {
		alert(msg);
    }
  </script>
</head>
<body>
  <form id="form1" runat="server">
    <asp:ScriptManager ID="ScriptManager1" runat="server" EnablePageMethods="True" />
    <div>
      <input type="text" id="Text1" onkeypress="keyPress()" />
    </div>
  </form>
</body>
</html>

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Re: How to Call a Server side Function on the Client side

Vimalsoft(Pty) Ltd5-Aug-10 20:16