C / C++ / MFC

BOOL bSelected = (CButton*) GetDlgItem(IDC_XYZ))->GetCheck() == BST_CHECKED;

Maximilien wrote:

BOOL bSelected = (CButton*) GetDlgItem(IDC_XYZ))->GetCheck() == BST_CHECKED;
(but I'm only nitpicking).

Randor wrote:

You should avoid upcasting a pointer returned from GetDlgItem().

Richard MacCutchan wrote:

that is exactly what the documentation[^] recommends that you do.

Randor wrote:

The upcast in the documentation is completely pointless

Richard MacCutchan wrote:

Since the actual item being returned is a CButton

Randor wrote:

Are you sure saying that GetDlgItem returns a CButton object?

Richard MacCutchan wrote:

No, I'm saying it returns the object whose ID is sent to GetDlgItem(), which will be some class derived from CWnd.

Richard MacCutchan wrote:

Thanks for the guidance.

int radioCheck = GetCheckedRadioButton(ID_RADIO1,ID_RADIO3);

DEBUG: [Passes = 5000] 311191.953 Byte/s
RESULT:  303.90 KB/sec

DEBUG: [Passes = 5000] 734956.927 Byte/s
RESULT:  717.73 KB/sec

DEBUG: [Passes = 5000] 391962.053 Byte/s
RESULT:  382.78 KB/sec

DEBUG: [Passes = 5000] 274082.350 Byte/s
RESULT:  267.66 KB/sec

DEBUG: [Passes = 5000] 281520.063 Byte/s
RESULT:  274.92 KB/sec

saiyuk6=7 wrote:

double seconds = ((double)(iValue - iBaseTime) * dbFreq);

<br />
DEBUG: 1074556249.047 Byte/s<br />
MEMSET:  0.00/sec  0.98/ms  1.00 GB/sec<br />
RESULT:  6.91/sec 6905.56/ms 72.41 MB/sec<br />

class CTimer {
public:
   CTimer() {
	   m_TimeStart.QuadPart = 0;
	   m_TimeStop.QuadPart = 0;
	    QueryPerformanceFrequency(&m_Frequency);
   }

   void Start(void) {
      QueryPerformanceCounter(&m_TimeStart);
   }

   void Stop(void) {
      QueryPerformanceCounter(&m_TimeStop);
   }

   double Seconds() const {
      return (double)(m_TimeStop.QuadPart - m_TimeStart.QuadPart) / (double)m_Frequency.QuadPart;;
   }

   double Milliseconds() const {
      return Seconds() * 1000.0;
   }

private:
   double m_dbFreq;
   LARGE_INTEGER m_Frequency;
   LARGE_INTEGER m_TimeStart;
   LARGE_INTEGER m_TimeStop;
};

#define MUL_BYTES 1024.0
#define MUL_KB (MUL_BYTES*1024.0)
#define MUL_MB (MUL_KB*1024.0)
#define MUL_GB (MUL_MB*1024.0)

std::string BPStoString(double dbPerSec)
{
   char *pTemp[] = {
      "Bytes", "KB", "MB",
      "GB", "TB", "PB",
      "EB", "ZB", "YB"
   };
   char szTemp[30];

   int i = 0;
   while (dbPerSec >= 0.9 * MUL_BYTES) {
      dbPerSec /= MUL_BYTES;
      i++;
   }

   sprintf(szTemp, "%5.2f %s/sec", dbPerSec, pTemp[i]);
   return std::string(szTemp);
}

void Benchmark_MD5(void)
{
   CTimer tm;

   tm.Start();
   unsigned long ulSize = MUL_KB;
   unsigned char *bzBuffer = new unsigned char[ulSize];
   if (bzBuffer != NULL) {
      memset(bzBuffer, 0, ulSize);
      tm.Stop();
      <code>double bps = (double)((ulSize * 1) / tm.Seconds());</code>
      printf("DEBUG: %5.3f Byte/s\n", bps);
      printf("MEMSET: %5.2f/sec %5.2f/ms %s\n", tm.Seconds(), tm.Milliseconds(),BPStoString(bps).c_str());
   }

   tm.Start();

   MD5_CTX md5;
   int iPasses = 500;
   for (int i = 0; i < iPasses; i++) {
      MD5Init(&md5);
      MD5Update(&md5, bzBuffer, ulSize);
      MD5Final(&md5);
   }
   tm.Stop();
  <code> double bps = (double)((ulSize * iPasses) / tm.Seconds());</code>
   printf("RESULT: %5.2f/sec %5.2f/ms %s\n", tm.Seconds(), tm.Milliseconds(),BPStoString(bps).c_str());

   delete bzBuffer;
}

saiyuk6=7 wrote:

unsigned char *bzBuffer = new unsigned char[ulSize];

unsigned char bzBuffer[MUL_KB];

bm.cpp
bm.cpp(40) : error C2057: expected constant expression
bm.cpp(40) : error C2466: cannot allocate an array of constant size 0
bm.cpp(40) : error C2133: 'bzBuffer' : unknown size

unsigned char *bzBuffer;
for (int i = HT_MD5; i < (HT_WHIRLPOOL + 1); i++) {
   hash.Init(i);
   bzBuffer = new unsigned char[hash.DigestSize()];
   if (bzBuffer == NULL) {
      //err code here
      return 0;
   }
   hash.Update(hashTest[i].buffer, hashTest[i].length);
   hash.Final(bzBuffer);
   for (int h = 0; h < hash.DigestSize(); h++)
      printf("%02.2%", bzBuffer[i]);
   delete bzBuffer;
}