Set page range in PrintPreview - C# Discussion Boards

CTRL/I within a RichTextBox

11-May-10 6:17

set the Form.Size (or Width, or Height, or both) in the Form's constructor. Or, if they are constant, why not set them in Visual Designer; I use the properties pane for such purpose.

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

I only read formatted code with indentation, so please use PRE tags for code snippets.

I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

gmhanna11-May-10 5:22

gmhanna

11-May-10 5:22

Hi,

I'm trying to capture a CTRL/I key via a KeyDown event within a RichTextBox, the code is working perfect for the CTRL/B and CTRL/U keys (Bold and Underline), however the CTRL/I appears to erase the input and never gets to the KeyDown event. What do I need to do to get this to work.

if (e.KeyCode == Keys.B && e.Control)
    ToggleFormat(FontStyle.Bold);

if (e.KeyCode == Keys.I && e.Control)
    ToggleFormat(FontStyle.Italic);

if (e.KeyCode == Keys.U && e.Control)
    ToggleFormat(FontStyle.Underline);

Thank you,

Glenn

Re: CTRL/I within a RichTextBox [modified]

William Winner11-May-10 6:00

William Winner

11-May-10 6:00

Are you hooking the other events? Like KeyPreview or KeyPress? It works perfectly for me.

The only thing I have in my KeyDown event is:

if (e.Control && e.KeyCode == Keys.I)
{
   MessageBox.Show("Ctrl+I");
}

So, if it's not getting there, then you must be handling the "I" KeyDown in some other method.

[UPDATE]

Sorry, I didn't see it was a RichTextBox. Just add this into your KeyDown:

if (e.KeyCode == Keys.I && e.Control)
{
   e.SuppressKeyPress = True;
   e.Handled = True;
   ToggleFormat(FontStyle.Italic);
}

modified on Tuesday, May 11, 2010 1:40 PM

gmhanna11-May-10 8:34

gmhanna

11-May-10 8:34

Hi,

Thank you for your response. It is actually executing the ToggleFormat(FontStyle.Italic); however after setting the font to Italic, it is erasing what was highlighted. CTRL/B and CTRL/U does not erase what was highlighted with the mouse.

So a better question is how do you prevent CTRL/I from erasing. I tried playing around with the AcceptTabs without any luck.

Glenn

William Winner11-May-10 9:01

William Winner

11-May-10 9:01

Well, as I said, you would have to use the SuppressKeyPreview value within the Keydown code. Though what I found was that sometimes, it didn't work. For instance, if I set SuppressKeyPreview to true and then did a MessageBox, it went ahead and erased the line.

This was the code that I got to work:

private void richTextBox1_KeyDown(object sender, KeyEventArgs e)
{
    if (e.Control && e.KeyCode == Keys.I)
    {
        e.SuppressKeyPress = true;
        e.Handled = true;

        SetItalic();
    }
}

private void SetItalic()
{
    if (richTextBox1.SelectionFont.Italic)
    {
        richTextBox1.SelectionFont = new Font(richTextBox1.Font, FontStyle.Regular);
    }
    else
    {
        richTextBox1.SelectionFont = new Font(richTextBox1.Font, FontStyle.Italic);
    }
}

This code toggled Italic without erasing anything.

gmhanna11-May-10 9:20

gmhanna

11-May-10 9:20

That did the trick!! -- Thank you very much!!

Glenn

Luc Pattyn11-May-10 6:19

Set page range in PrintPreview

11-May-10 6:19

try

myRTB.AcceptsTab=true;

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

I only read formatted code with indentation, so please use PRE tags for code snippets.

I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

baranils11-May-10 5:18

baranils

11-May-10 5:18

Hello

The property AllowsSomePage in the PrintDialog allow to define a page range to Print

However it will be much more usefull in the PrintPreview dialog

Do someone knows if there is some ways to customize the PrintPreview dialog to add this feature ?

Thanks for any help

Maximum number of lines within a class

Tony Pazzard11-May-10 4:44

Tony Pazzard

11-May-10 4:44

One of my so called 'colleagues' has just written a class with over 8000 lines of code. Confused | :confused:

Apart from it being a nightmare to understand is there any peformance implications or any other good reasons I can use as evidence to try and put a stop to this practice! It's not a witch hunt, honest...

Luc Pattyn11-May-10 4:50

11-May-10 4:50

IMO readability is key.
If there are huge methods, consider splitting them up (and reusing some parts).
If there are lots of small methods, consider replacing them by fewer more general-purpose ones.
In short, look for ways to do the same thing with less code, however not at the expense of readability.

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

I only read formatted code with indentation, so please use PRE tags for code snippets.

I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

#realJSOP11-May-10 6:36

#realJSOP

11-May-10 6:36

From a maintenance standpoint, yes, there will be a performance hit. From a execution standpoint, that's a lot of code, and so it's going to impact overall performance of the app. Without seeing the code, we can't recommend changes, but I would start by performing a code review to see WHY the class is 8000 lines long. You might be able to move some of the functionality into a global static class, or if some of the code is used elsewhere, make a base class from which to derive other classes.

.45 ACP - because shooting twice is just silly
-----
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"The staggering layers of obscenity in your statement make it a work of art on so many levels." - J. Jystad, 2001

The Man from U.N.C.L.E.11-May-10 7:42

The Man from U.N.C.L.E.

11-May-10 7:42

This article[^] recommends 2000 lines of code max, which sounds manageable, though it is about readability more than anything. We have a few classes at around 3000-4000 lines, however most of that is GUI code. The Infragistics grid is particularly good at adding 1000 random lines of code to your class just because you set the border to be blue! Use of regions and partial classes help.

For a non-GUI class I would suspect it is doing the job of two or more classes if there is that much code in there.

Time to refactor with an axe. Smile | :)

If you have knowledge, let others light their candles at it.
Margaret Fuller (1810 - 1850)
[My Articles] [My Website]

PIEBALDconsult11-May-10 7:51

PIEBALDconsult

11-May-10 7:51

Tony Pazzard wrote:
lines of code

What's
a
line
of
code?

Luc Pattyn11-May-10 7:58

11-May-10 7:58

PIEBALDconsult wrote:
What's a line of code?

a comment or a statement, except when that would exceed reasonable width and needs to be chopped.

Most people prefer spaces over newlines for separators ... Laugh | :laugh:

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

I only read formatted code with indentation, so please use PRE tags for code snippets.

I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

PIEBALDconsult11-May-10 15:21

PIEBALDconsult

11-May-10 15:21

Oh,

a

statement

is

a

line

of

code

?

Luc Pattyn11-May-10 15:39

11-May-10 15:39

I'm sorry, at the moment your sentence can't be all displayed at once, so I can't provide a substantive reply to it. I'm still saving for that skyscraping monitor, and looking for a tall spot to put it.

Poke tongue | ;-P

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

I only read formatted code with indentation, so please use PRE tags for code snippets.

I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

Abhinav S11-May-10 7:52

Abhinav S

11-May-10 7:52

Tony Pazzard wrote:
class with over 8000 lines of code.

Ideally, this should not have been the case.
As a basic pattern a class should be decoupled and cohesive - thus probably making it smaller (than 8000 lines).
However, I suppose there are exceptions to this.