I need critique on this code - C# Discussion Boards

okay my bad. arraylist is available in compact framework.

however, im gonna try your suggestion instead. List looks like a better choice =)

Arrays in the .NET CLR are not resizable. Once they are created, that's it. In order to change their size, you'd have to create a new array of the required size, copy the data over, then destroy the original array.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak
Microsoft MVP
Visual Developer - Visual Basic
2006, 2007, 2008
But no longer in 2009...

tks Dave. =)

There is something called Redim which used to resize the array at later stage, or the best you can do is go for arraylist

C# doesn't have a ReDim method like VB.NET does.

And, in VB.NET ReDim does NOT resize an array. Behind the scenes it has to do the exact same thing you'd do manually. It creates a new array of the required size, copies the data to it, then destroys the original array.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak
Microsoft MVP
Visual Developer - Visual Basic
2006, 2007, 2008
But no longer in 2009...

Actually, all .NET languages have access to the static "System.Array.Resize" method (since .NET Framework 2, I believe) - but as you said, there's no magic - it just does the same copying that VB's ReDim does.

David Anton
Convert between VB, C#, C++, & Java
www.tangiblesoftwaresolutions.com

Yeah, I was saying that C# didn't have an equiv keyword to VB.NET's ReDim.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak
Microsoft MVP
Visual Developer - Visual Basic
2006, 2007, 2008
But no longer in 2009...

Just got back into writing code after 10 years. This is a infix to postfix converter. Can someone please critique this...

thanks

using System;
using System.Collections;
using System.Text;
using System.Text.RegularExpressions;
using System.Collections.Generic;

namespace Infix2Postfix
{
    public class Program
    {
        static void Main(string[] args)
        {
            #region variable declarations
            //declare and initialize the string to accept an expression in infix notation
            String stringInfix = "a+b/c-d";

            StringBuilder SbPostfix = new StringBuilder();
            Stack<char> stackGeneral = new Stack<char>();
            Stack<char> stackOperator = new Stack<char>();
            char[] tempArray = stringInfix.ToCharArray();

            Array.Reverse(tempArray);
            Regex regexAlphaNum = new Regex("[a-zA-Z0-9]");
            char temp;

            #endregion

            #region logic

            foreach (char ch in tempArray)
                stackGeneral.Push(ch);

            foreach (char ch in stackGeneral)
            {
                if (regexAlphaNum.IsMatch(Convert.ToString(ch)))
                    SbPostfix.Append(ch);
                else if (stackOperator.Count == 0)
                    stackOperator.Push(ch);
                else if (stackOperator.Count != 0)
                    switch (ch)
                    {
                        case '+':
                            temp = stackOperator.Peek();
                            if (temp == '*' || temp == '/')
                            {
                                while (stackOperator.Count > 0)
                                    SbPostfix.Append(stackOperator.Pop());
                                stackOperator.Push(ch);
                            }
                            else
                                stackOperator.Push(ch);
                            break;
                        case '-':
                            temp = stackOperator.Peek();
                            if (temp == '*' || temp == '/')
                            {
                                while (stackOperator.Count > 0)
                                    SbPostfix.Append(stackOperator.Pop());
                                stackOperator.Push(ch);
                            }
                            else
                                stackOperator.Push(ch);
                            break;
                        case '*':
                            temp = stackOperator.Peek();
                            if (temp == '*' || temp == '/')
                            {
                                while (stackOperator.Count > 0)
                                    SbPostfix.Append(stackOperator.Pop());
                                stackOperator.Push(ch);
                            }
                            else
                                stackOperator.Push(ch);
                            break;
                        case '/':
                            temp = stackOperator.Peek();
                            if (temp == '*' || temp == '/')
                            {
                                while (stackOperator.Count > 0)
                                    SbPostfix.Append(stackOperator.Pop());
                                stackOperator.Push(ch);
                            }
                            else
                                stackOperator.Push(ch);
                            break;
                    }

            }
            while (stackOperator.Count > 0)
                SbPostfix.Append(stackOperator.Pop());

            #endregion

            #region output to screen
            Console.WriteLine("Equation in infix notation: {0}", stringInfix);
            Console.Write("Equation in postfix/RPN notation: {0}", SbPostfix);
            Console.ReadKey();
            #endregion

        }
    }
}

I don't think you need tempArray.
How does it handle malformed input?

Here's[^] my infix-to-postfix code; there are others on here.

It only handles inputs in a*b-c/d format. The code is very basic, written in an non elegant way. I will look at your code, it might give me some insights.

Here I am criticizing it Big Grin | :-D

It's too long and too late at night for me Sleepy | :zzz:

. Now it's joke time :cool

LOL-i.pop();

and i.push() Big Grin | :-D

Sounds like candy...haha

I would fire you on the spot for putting regions in a method and not maintaining consistent capitalization of variables.

Need custom software developed? I do custom programming based primarily on MS tools with an emphasis on C# development and consulting.

A man said to the universe:
"Sir I exist!"
"However," replied the universe,
"The fact has not created in me
A sense of obligation."
--Stephen Crane

lol...I know exactly which variable name you are referring to.

Why are regions in a method a bad idea? I ask this risking sounding like a fool.

Regions are intended to be used in GROUPING methods not splitting one method's body.

[EDIT]
Example:

#region Events//put here all/most of the event(s) handling code

#region Drawing//put here all the drawing methods

#region YouNameIt// put here all the...

[/EDIT]

Ahh...I understand.

Thanks!

for nothing

Oh c'mon my friend...your statement helped me more than any other reading I did today Big Grin | :-D

Ohh, well, in that case, glad that I could help Smile | :)

That may be only a personal or company standard. One can use regions wherever one darn well wants to.

I generally use them only to group methods and properties, but I may also use seperate files (partial classes) for that purpose if the code becomes large enough.

In my RPN transformer I use regions to mark off less-important code that the reader may not be interested in -- it should at least help with documentation and readability -- I don't want to read through a bunch of error-handling code when I'm trying to get a feel for the process flow of a method.

Also, if you are using a region in a method, it is a sure sign you should put some of your logic into another method and just call that method from your original method.

[Forum Guidelines]

Thank you for your reply and the link! Blush | :O