C / C++ / MFC

18-Jul-09 16:53

thanks.
i am facing a new problem. i am trying to save the items of list control which are checked to a text file. here is the code ---

TCHAR ff[100] = {0};
CFile srvc;
    srvc.Open(_T("c:\\srvc.txt"), CFile::modeCreate|CFile::modeReadWrite);
for (int nItem = 0; nItem < srvcList.GetItemCount(); nItem++)
{
    if (srvcList.GetCheck(nItem))
    {

        srvcList.GetItemText(nItem, 0, (LPTSTR)ff, 98);
        wcscat_s(ff, L"\n");
        srvc.SeekToEnd();
        srvc.Write(ff, 100);
        ZeroMemory(ff, 100);

    }

}

the content of the file is not right ---

A e L o o k u p S v c 
   þþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþA p p H o s t S v c 
   þþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþA V P 
   þþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþB F E 
   þþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþB I T S 
   þþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþþ

there is extra space between each letter and the symble 'þ'. there is also no new line even with the use of '\n'.

modified on Saturday, July 18, 2009 11:05 PM

carter200018-Jul-09 17:14

18-Jul-09 17:14

Hi.
I use
"
CString temp(ff);
srvc.Write(ff, 2 * temp.GetLength() - 1);
"

instead of your "srvc.Write(ff, 100);", and it's works OK in my computer. Maybe you can try it, but it must not be a good solution.
If it couldn't work, tell me and I would try to find another solution.

rahuljin18-Jul-09 17:28

18-Jul-09 17:28

now the content of the file is this ----

A p p M g m t A V P B F E

the content should be like this ---

AppMgmt
AVP
BFE

carter200018-Jul-09 17:19

18-Jul-09 17:19

srvc.Write(ff, 2 * lstrlen(ff) - 1);
This can work in my computer too, maybe it's better than the last one I gave you.

rahuljin18-Jul-09 17:31

18-Jul-09 17:31

same problem as other. there is a extra space between each letter and no new line.

carter200018-Jul-09 18:01

18-Jul-09 18:01

My OS is winows XP.
And if I view the text by Notepad.exe, it's the same as you.
But if I use anothor software to view the text, it just be OK.

carter200018-Jul-09 18:09

18-Jul-09 18:09

wcscat_s(ff, L"\n");
Em, try to replace the code by
1. wcscat_s(ff, L"\r\n");
2. wcscat_s(ff, L"\r");
3. wcscat_s(ff, L"\n\r");

rahuljin18-Jul-09 18:49

18-Jul-09 18:49

i do some changes ----

for (int nItem = 0; nItem &lt; srvcList.GetItemCount(); nItem++)
{
	if (srvcList.GetCheck(nItem))
	{
		srvcList.GetItemText(nItem, 0, (LPTSTR)ff, 98);
		//wcscat_s(ff, L"\r\n");
		srvc.SeekToEnd();
		int i = 2 * lstrlen(ff) - 2;
		int j = 0;
		while(i)
		{
			srvc.Write(&amp;ff[j], 1);
			i--;
			j++;
		}
	}
}

the content is ---

AVP BFE BITS

if i use wcscat_s(ff, L"\r\n"), then

AVP
 þþþBFE
 þþþBITS
 þþþþ

this text file will be used by other program, therefore cant compromise with it.

carter200018-Jul-09 19:03

18-Jul-09 19:03

It looks inefficient Smile | :)

rahuljin19-Jul-09 1:07

19-Jul-09 1:07

still there is a problem, there is no new line. i want the content of the text file like this -----

AVP
BFE
BITS

carter200019-Jul-09 1:11

19-Jul-09 1:11

You can try veiwing the text in Edit Plus or other text edit software.

carter200019-Jul-09 1:33

19-Jul-09 1:33

You can try this, open the "srvc.txt", and select all text, and copy them, and open anthor TextEditor(Edit Plus), and paste.
If still there is no new line, then I have no ideas. It's seems that Microsoft define a new line as '\r\n', while in Unix it's '\n'.

rahuljin19-Jul-09 11:07

19-Jul-09 11:07

thanks for all the support. finally it is done. the code is not that good ---

TCHAR ff[100] = {0};
CStdioFile srvc;
srvc.Open(_T("c:\\srvc.txt"), CFile::modeCreate|CFile::modeReadWrite);

for (int nItem = 0; nItem < srvcList.GetItemCount(); nItem++)
{
    if (srvcList.GetCheck(nItem))
    {
        srvcList.GetItemText(nItem, 0, (LPTSTR)ff, 100);
        int i = 2 * lstrlen(ff) - 2;
        srvc.SeekToEnd();
        int j = 0;
        while(i)
        {
            srvc.Write(&ff[j++], 1);
            --i;
        }
        ZeroMemory(ff, 100);
        srvc.SeekToEnd();
        srvc.Write("\n", 1);
    }
}

output is ---

Audiosrv      
AVP 
BFE 
BITS

also please tell me that is there a way due to which edit box control can take only numeric values and with in a bound, say 1 to 1000 only ???

modified on Sunday, July 19, 2009 5:19 PM

carter200019-Jul-09 15:21

Re: search a list control [modified]

19-Jul-09 15:21

you solve the problem by yourself, congratulation Smile | :)

.
maybe you can try replace the follow codes by "srvc.Write(ff, 2 * lstrlen(ff));", it works too in my computer.

rahuljin wrote:
while(i) { srvc.Write(&ff[j++], 1); --i; }

rahuljin19-Jul-09 20:23

19-Jul-09 20:23

thanks. if you didnt guide and help me, it would be impossible for me.

please answer my last question.

one more problem found ---

in first list control, when i enter an ip say "111.111.111.111", then i cannot enter the ip address "111.111.111.11". also "111.111.111.11" deletes "111.111.111.111" from the list control.
here is the code ----

BYTE m_M1, m_M2, m_M3, m_M4;
TCHAR ss[50] = {0};
UpdateData();
int i = -1;
LVFINDINFO temp;

ipAdd.GetAddress(m_M1, m_M2, m_M3, m_M4);
temp.flags = LVFI_PARTIAL|LVFI_STRING;

_stprintf_s(ss, _T("%d.%d.%d.%d"), m_M1, m_M2, m_M3, m_M4);
temp.psz = ss;
i = ipList.FindItem(&temp);

if(radBut1->GetState())
{
    if(m_M1 && m_M2 && m_M3 && m_M4 && i == -1)
    {
        ipList.InsertItem(s++, (LPCTSTR)ss);
        ipAdd.ClearAddress();
    }
}

else if(radBut2->GetState())
{

    if(i != -1)
        ipList.DeleteItem(i);
    else
        MessageBox((LPCTSTR)L"Error: Address not found", (LPCTSTR)L"Delete Address", MB_ICONWARNING | MB_OK);


    ipAdd.ClearAddress();

modified on Monday, July 20, 2009 3:17 AM

carter200019-Jul-09 21:58

19-Jul-09 21:58

rahuljin wrote:
ipList.DeleteItem(i);

What's "s" means? The last index of CListCtrl?
So if it's, then here

rahuljin wrote:
ipList.DeleteItem(i);

after deleting a item, you must also descend "s". I don't know if this is the reason.

rahuljin19-Jul-09 22:18

19-Jul-09 22:18

still the same problem ---

ipList.DeleteItem(i);
s--;

carter200019-Jul-09 23:10

19-Jul-09 23:10

rahuljin wrote:
if(i != -1) ipList.DeleteItem(i);

Relpace the codes with:

if (i != -1 && lstrcmp(ipList.GetItemText(i), temp.psz) == 0)
{
ipList.DeleteItem(i);
}

rahuljin19-Jul-09 23:27

19-Jul-09 23:27

thanks, both the problems are solved.

BYTE m_M1, m_M2, m_M3, m_M4;
    TCHAR ss[50] = {0};
UpdateData();
int i = -1;
LVFINDINFO temp;

    ipAdd.GetAddress(m_M1, m_M2, m_M3, m_M4);
temp.flags = LVFI_PARTIAL|LVFI_STRING;

_stprintf_s(ss, _T("%d.%d.%d.%d"), m_M1, m_M2, m_M3, m_M4);
temp.psz = ss;
i = ipList.FindItem(&temp);

if(radBut1->GetState())
{
    if(m_M1 && (i == -1 || lstrcmp(ipList.GetItemText(i, 0), temp.psz) != 0) )
    {
        ipList.InsertItem(s++, (LPCTSTR)ss);
        ipAdd.ClearAddress();
    }
}

else if(radBut2->GetState())
{

    if (i != -1 && lstrcmp(ipList.GetItemText(i, 0), temp.psz) == 0)
    {
        ipList.DeleteItem(i);
        s--;
    }

    else
        MessageBox((LPCTSTR)L"Error: Address not found", (LPCTSTR)L"Delete Address", MB_ICONWARNING | MB_OK);


    ipAdd.ClearAddress();


}

carter200019-Jul-09 23:34

19-Jul-09 23:34

I think your code still has some problems.
Consider the situation below:
There are two items in CListCtrl.
111.111.111.111
111.111.111.11

And you enter 111.111.111.11 to insert the new item, see what happen.
If I am right, it will insert successfully!!That may not be what you want.

rahuljin19-Jul-09 23:45

19-Jul-09 23:45

in that case, 'i' will not be -1 and lstrcmp(ipList.GetItemText(i, 0), temp.psz) will be equal to zero because the item text and temp.psz will be same.

carter200020-Jul-09 0:06

20-Jul-09 0:06

Before you changed the "temp.flags = LVFI_PARTIAL|LVFI_STRING;" to "tem.flags=LVFI_STRING;", it's a wrong case exactly.
But now it isn't. Smile | :)

carter200019-Jul-09 23:19

Re: search a list control [modified]

19-Jul-09 23:19

BYTE m_M1, m_M2, m_M3, m_M4;    
    TCHAR ss[50] = {0};	
    UpdateData();
    ipAdd.GetAddress(m_M1, m_M2, m_M3, m_M4);	
    _stprintf_s(ss, _T("%d.%d.%d.%d"), m_M1, m_M2, m_M3, m_M4);  
    int compare;
    for (int i = 0; i < ipList.GetItemCount(), ++i)
    {
        compare = lstrcmp(ss, ipList.GetItemText(i));
        if(radBut1->GetState())	
        {		
            if(m_M1 && m_M2 && m_M3 && m_M4 && compare != 0)		
            {			
                ipList.InsertItem(s++, (LPCTSTR)ss);			
                ipAdd.ClearAddress();		
            }	
        }	
        else if(radBut2->GetState())	
        {		
            if(compare == 0)			
                ipList.DeleteItem(i);		
            else 			
                MessageBox((LPCTSTR)L"Error: Address not found", (LPCTSTR)L"Delete Address", MB_ICONWARNING | MB_OK);		
            ipAdd.ClearAddress();
        }
    }

This is the final version. Smile | :)

rahuljin19-Jul-09 23:39

19-Jul-09 23:39

got another solution ---

temp.flags = LVFI_STRING;

and everything becomes right.

modified on Monday, July 20, 2009 5:46 AM

carter200019-Jul-09 23:42