Re: mfc tab problem - C / C++ / MFC Discussion Boards

Roger Stoltz9-Jul-09 22:23

9-Jul-09 22:23

Phweeew...

To be honest, there's a lot of things wrong with your code and how you think you should go about multithreading.
Let's try and pin-point a few.

Use AfxBeginThread() when building with MFC framework
This must be done to keep the framework happy. Otherwise you'll get into obscure problems that are hard to track down.
Do NOT touch the GUI from a secondary thread
This is very important, especially in MFC since e.g. SetDlgItemText() sends a message to the windows of the control. The difference between sending and posting a message is that sending will block until the message has been processed by the receiving thread. This means that if the thread that "owns" the window doesn't process messages, you'll get a nice little deadlock.
Worker threads doesn't process messages
Your calls to ProcessMessages() are, apart from completely unnecessary, fundamentally wrong. No messages will be sent to your threads. You need to differentiate between so called worker threads that doesn't process messsages and UI-threads.
Your main thread doesn't process messages
After you have called ProcessMessages(), your main thread doesn't process messages any longer. This means that your secondary threads will hang when calling SetDlgItemText() since the receiving window/thread will not consume the message. One way to solve it would be to use ::MsgWaitForMultipleObjects() while waiting for the threads to complete. The correct way would be to return from the function that creates the threads and revert to the window procedure for the main thread. You get into this kind of trouble since you're trying to learn multithreading, but you're using it in a way that contradicts with the reason for having multiple threads since you're still doing things sequentially.

I suspect that the reason why your thread #2 is "still running" when you get the message box is a combination of the above. In other words: your thread #2 hangs because of the call to ::Sleep() since by the time it resumes execution your main thread has stopped processing messages. You should really have a look at the return value from ::WaitForMultipleObjects().

Some words about what you should do.... $Shucks | :-\$
Forget about the article you referred to and start here[^]. This is, in my opinion (and a lot of others), the absolute best article for starting out doing multithreading.

"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown

Re: Help with threads

FISH78610-Jul-09 0:34

FISH786

10-Jul-09 0:34

Thank you for the feedback. I appreciate the honesty. I will check on the article and work my way from there.

thanks a million.

Re: Help with threads

Rajesh R Subramanian9-Jul-09 22:52

Rajesh R Subramanian

9-Jul-09 22:52

FISH786 wrote:
CThreadDemoDlg* pDlg = pData->pObjDlg;

I smell MFC?

FISH786 wrote:
hThread_2 = CreateThread(NULL,0,Thread_2,TD2,0,NULL);

And you're calling CreateThread(). First things first[^]

It is a crappy thing, but it's life -^ Carlo Pallini

Re: Help with threads

Roger Stoltz10-Jul-09 1:03

Roger Stoltz

10-Jul-09 1:03

Rajesh R Subramanian wrote:
FISH786 wrote:
CThreadDemoDlg* pDlg = pData->pObjDlg;
I smell MFC?

FISH786 wrote:

MessageBox("Done","Information",MB_OKCANCEL);

Calling MessageBox() without a window handle looks very MFC-ish to me, so I guess we are right in our assumptions...
Wink | ;)

"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown

Re: Help with threads

Rajesh R Subramanian10-Jul-09 1:08

Rajesh R Subramanian

10-Jul-09 1:08

So, we can confirm the crime. Suspicious | :suss:

But, I didn't go that far. I saw the CThreadDemoDlg* on the first few lines and assumed MFC. After all, the user (while sober) cannot come up with a funky name of that sort on his own. Smile | :)

It is a crappy thing, but it's life -^ Carlo Pallini

mfc tab problem

DevelopmentNoob9-Jul-09 16:15

DevelopmentNoob

9-Jul-09 16:15

hi,
i got some to store the data in tab. i got 1 propertysheet and 3 propertypage to build the tab..
each page i got the data nid to save when the user press the ''ok'' button.
but when i press ''ok'',it only store the data in current page only and not all the 3 pages.
i have read the msdn,it say when u press ''ok'',it will call ''killactive'' function, but when i switch between page 1 to page 2 it already call ''killactive''..zzzz

Re: mfc tab problem

«_Superman_»9-Jul-09 19:47

«_Superman_»

9-Jul-09 19:47

Try manually calling UpdateData for each property page when the OK button is clicked.

«_Superman_»
I love work. It gives me something to do between weekends.

Re: mfc tab problem

DevelopmentNoob16-Jul-09 21:18

DevelopmentNoob

16-Jul-09 21:18

i find out the solution already. Just add the OnOK() function in each propertypage.
When the user click the 'OK', it will call all the OnOK in each propertypage.

Is it safe to cast from LPBYTE to LPSTR to LPBYTE ?

Mike the Red9-Jul-09 13:47

Mike the Red

9-Jul-09 13:47

I have a BYTE array that contains a mix of ANSI and binary data. I'm wanting to convert the LPBYTE to LPSTR so that I can use the CString functions to pull substrings of either ANSI or binary data out of the BYTE array. I know that explicit casts can be hazardous, so I tried this:

int _tmain(int argc, _TCHAR* argv[])
{	// (BYTE = unsigned char)
	unsigned char uc = 255; // 255 is max value for unsigned char, outside range for char

	cout << "unsigned char uc = " << (int) uc << "\n";
	char c = (char) uc;
	cout << "char c = (char) uc = " << (int) c << "\n";
	uc = (unsigned char) c;
	cout << "(unsigned char) c = " << (int) uc << "\n";
}<HR>
OUTPUT:
unsigned char uc = 255
char c = (char) uc = -1
(unsigned char) c = 255

I'm not 100% that this little test tells me it's safe to convert binary data in a BYTE array to a CHAR array and back...

Can you gurus help me out, again, please? Confused | :confused:

Re: Is it safe to cast from LPBYTE to LPSTR to LPBYTE ?

Stuart Dootson9-Jul-09 14:19

Stuart Dootson

9-Jul-09 14:19

Yes, you can cast LPBYTE to LPSTR without really worrying too much.

Rather than use CString, though, I'd probably use either STL algorithms (because LPBYTE and LPSTR can both be treated as STL iterators) or Boost algorithms[^] (which are actually a lot easier to use than the documentation can make it appear), because they will act on your BYTE array, whereas a CString manages its own buffer.

Here's an example of how to find a substring in a BYTE buffer (I've used unsigned char* because I'm testing on OS X, not Windows, so I don't have a BYTE type!):

#include <algorithm>
#include <iostream>

int main()
{
   unsigned char buffer[] = { 1, 2, 3, 'H', 'e', 'l', 'l', 'o', 34, 12 };
   unsigned char* bufferEnd = buffer + sizeof(buffer);
   char lookFor[] = "Hello";
   char* lookForEnd = lookFor + strlen(lookFor);

   unsigned char* where = std::search(buffer, bufferEnd, (unsigned char*)lookFor, (unsigned char*)lookForEnd);
   
   std::cout << std::distance(buffer, where) << std::endl; // Shows the offset of Hello in the buffer == 3
}

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

Thanks, Stuart! -nt-

Mike the Red9-Jul-09 15:43

Mike the Red

9-Jul-09 15:43

-nt-

Format CEdit for Phone Number

DanYELL9-Jul-09 12:04

DanYELL

9-Jul-09 12:04

Any chance, anyone has code to maintain the format:

(###) ###-####

for a CEdit? There are some masked edit controls, but I
cant get them to blend in with what I have. Im just looking
for something small to let me maintain the above phone
format.

Please, any response any one can give me will be greatly
appreciated.

Sincerely,
Danielle Brina

Re: Format CEdit for Phone Number

David Crow9-Jul-09 16:11

David Crow

9-Jul-09 16:11

DanYELL wrote:
Any chance, anyone has code to maintain the format:

(###) ###-####

for a CEdit? There are some masked edit controls...

Such as this one.

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

Re: Format CEdit for Phone Number

kilt9-Jul-09 23:25

kilt

9-Jul-09 23:25

Useless.
Masked Edit conrol is Native With Shell...

Re: Format CEdit for Phone Number

DanYELL10-Jul-09 1:46

DanYELL

10-Jul-09 1:46

Yeah, but Im looking for just the important
code that would take the contents of a CEdit and
make it stay in the format:

(###) ###-####

I already have a class which makes it hot when I
scroll over it and I dont want to try to combine
that class with another class. Im trying to
keep this simple.

Any chance you have something where if I handle
OnChangeEdit() and I can then call this function
that will maintain that phone number structure?

Re: Format CEdit for Phone Number

David Crow10-Jul-09 2:52

David Crow

10-Jul-09 2:52