|
i wrote the code below for a C++ programming class and i get a segmentation fault within this part of the code. now i asked my teacher and he told me that there's just a line in the wrong place but for the life of me i can't figure out which line is out of place. i thought i'd turn to some people with more experience with looking at code and finding the errors. it's really a simple problem i have i'm just not seeing it though.. please help me!
p.s. sorry if i posted the code the wrong way for the forum
void Search::Store(char *k, char *d) {
struct TBox *p1,*p2;
int i;
p1 = new TBox;
if (Start==NULL) {
p1->left = NULL;
p1->right = NULL;
p1->key = new char[strlen(k)+1];
p1->data = new char[strlen(d)+1];
strcpy(p1->key,k);
strcpy(p1->data,d);
Start=p1;
return;
p1=Start;
while(p1!=NULL) {
if ( (i=strcmp(k,p1->key)) == 0 ) {
delete [] p1->data;
p1->data = new char[strlen(d)+1];
strcpy(p1->data,d);
return;
}
if ( i < 0 ) {
p2=p1;
p1=p1->left;
continue;
}
p2=p1;
p1=p1->right;
}
}
p1 = new TBox;
p1->left = NULL;
p1->right = NULL;
p1->key = new char[strlen(k)+1];
p1->data = new char[strlen(d)+1];
strcpy(p1->key,k);
strcpy(p1->data,d);
Start=p1;
if (i<0) p2->left=p1;
else p2->right=p1;
return;
}
|
|
|
|
|
Brandon Ramirez wrote: p1->key = new char[strlen(k)+1];
p1->data = new char[strlen(d)+1];
strcpy(p1->key,k);
strcpy(p1->data,d);
Why didn't you check if memory allocation succeeded?
Brandon Ramirez wrote:
return;
p1=Start;
while(p1!=NULL) {
if ( (i=strcmp(k,p1->key)) == 0 ) {
delete [] p1->data;
p1->data = new char[strlen(d)+1];
strcpy(p1->data,d);
return;
}
What is the purpose of the return; line? Do you know the code below it will never be executed?
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
ok so what should i do with the return? yes i see that anything after it won't be executed but do i need to put that return at the bottom of this function or is it unecessary?
|
|
|
|
|
You didn't answer my question: What is the purpose of the intermediate return;? Do you really want to cut-off the remaining lines? As for the return; at the bottom of the function, it is optional (old saying: "leave out all the optional stuff").
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
to tell you the truth i don't know why that was there i took it out but am still getting a seg fault from something. i can't tell what's doing it.
|
|
|
|
|
Brandon Ramirez wrote: to tell you the truth i don't know why that was there
That's not promising... 
Brandon Ramirez wrote: am still getting a seg fault from something.
You should definitely use a debugger and find the offending line.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
CPallini wrote: Why didn't you check if memory allocation succeeded?
Get with the times, man - new throws when it fails...so long as you're not using VC6! Certainly, in VC++ 2003 and later, this code prints Whoops - not enough memory!:
try
{
int* a = new int[1e9];
}
catch(std::bad_alloc)
{
std::cout << "Whoops - not enough memory!\n";
}
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
|
|
|
|
|
Thank you.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
How do you know the problem lies within this code snippet?
"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
|
|
|
|
|
MFC, STUDIO 2008, MDI-project
If to comment
СAdderDialog* m_pModeless5;
then OK!
// modeldlg.h : implementation file
protected:
СAdderDialog* m_pModeless5; // pointer on class
error C2143: syntax error : missing ';' before '*'
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
: error C2614: 'CMainDlg' : illegal member initialization: 'm_pModeless5' is not a base or member
class CAdderDialog : public Cdialog
class CMainDlg : public Cdialog
// adderdlg.cpp : implementation file
#include "stdafx.h"
#include "ADO_MDI.h"
#include "Aadderdlg.h"
#include "modeldlg.h"
// modeldlg.cpp : implementation file
#include "stdafx.h"
#include "ADO_MDI.h"
#include "Aadderdlg.h"
#include "modeldlg.h"
|
|
|
|
|
CHIVOTIOV wrote: #include "Aadderdlg.h"
Any typo there?
«_Superman_»
I love work. It gives me something to do between weekends.
|
|
|
|
|
Forward declare class СAdderDialog before class declaration;
class СAdderDialog;
Regards,
Paresh.
|
|
|
|
|
Typo: #include "Aadderdlg.h" //"a" too much 
for class #include СAdderDialog
Press F1 for help or google it.
Greetings from Germany
|
|
|
|
|
advanced to forward, 2 errors became less:
#pragma once
class СAdderDialog; // after addition this line into file "modeldlg.h" eliminate (remove)only 2 errors
// CMainDlg
class CMainDlg : public CDialog
{
СAdderDialog* m_pModeless5;
CMainDlg::CMainDlg(CWnd* pParent /*=NULL*/)
: CDialog(CMainDlg::IDD, pParent)
, m_pModeless5(NULL)
{
. . . . . . . . . . .
///////////////////////////////////////
void CMainDlg::OnOK()
{
if (m_pModeless5 == NULL) // OK!
{
m_pModeless5 = new CAdderDialog(this); // error C2440: '=' : cannot convert from 'CAdderDialog *' to 'СAdderDialog *'
if (m_pModeless5->Create() == TRUE) // modeldlg.cpp(67) : error C2027: use of undefined type 'СAdderDialog'
// error C2227: left of '->Create' must point to class/struct/union/generic type
GetDlgItem(IDOK)->EnableWindow(FALSE);
}
else
m_pModeless5->SetActiveWindow(); // error C2027: use of undefined type 'СAdderDialog'
}
|
|
|
|
|
you got to include the CAdderDialog-Header file 
Press F1 for help or google it.
Greetings from Germany
|
|
|
|
|
classic case of non-usuage of forward decalaration
"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
Never mind - my own stupidity is the source of every "problem" - Mixture
cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief and You
|
|
|
|
|
Hi all,
I have a dialog based application ,here on InitInstance() function of application i want to run an another exe from ShellExecute command like this;
CString shell_str;
ShellExecute(NULL,_T("open"),shell_str,NULL,NULL,SW_HIDE);
with the use of this exe i want to copy or move some files in Program files folder,so in Case of VISTA and UAC is Enabled its wants to permission of admin rights to copy or move files .
so please tell me how can i do this.
thanks in advance.
To accomplish great things, we must not only act, but also dream;
not only plan, but also believe.
|
|
|
|
|
You can give it permission for admin rights. 
«_Superman_»
I love work. It gives me something to do between weekends.
|
|
|
|
|
I am shure that you havent use the search box. 
Press F1 for help or google it.
Greetings from Germany
|
|
|
|
|
means
To accomplish great things, we must not only act, but also dream;
not only plan, but also believe.
|
|
|
|
|
Read here.
"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
|
|
|
|
|
Is this[^] helpful ?
Regards,
Paresh.
|
|
|
|
|
Hello All ,
I want to make code in VC++ which will usefull,when some application like IE browser,mozilla .... That will run in mininum user access rights .please tell me which api are usefull for me and any extra from you .
Thank You.
|
|
|
|
|
CreateProcessWithLogonW Function[^]
CreateProcessAsUser() windowstations and desktops[^]
You can also accomplish the same thing without writing code. I run my internet browsers under a limited account by using the runas application[^] which allows a process to be created under an account with restrictive permissions.
Here is how I do it here in my office:
1.) I create a very limited user which has very restricted rights, perhaps I name the account 'LimitedUserName'.
2.) Create a shortcut to Internet Explorer or your favorite insecure application.
3.) Right click the shortcut and in the edit box labeled Target add:
C:\WINDOWS\system32\runas.exe /user:LimitedUserName /SaveCred "c:\Program Files\Internet Explorer\iexplore.exe"
Now Internet explorer will run as the user 'LimitedUserName' and may be less vunerable to exploits depending on your local user and security policies.
Best Wishes,
-David Delaune
|
|
|
|
|
Hi There.
Lets say, I have an exe. that sends a user defined message to my console based application on the basis of the title.
Now, I have to recieve that message in my Win32 Console based application. Just FYI, MFC support is enabled in this application.
Please provide your kind suggestions/pointers, so that I can proceed.
Thanks.
PanB
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
