|
What is the type of characters passed to your EncodeToUTF8 method?
You use LPCTSTR as the passed parameter type, which can be a
const char * or a const wchar_t * ... which is it?
If you are going to do specific character set conversions, you need
to use specific char types, not generics.
Here's an example of your EncodeToUTF8() method for a Unicode build
<code>CStringA</code> CChatManager::EncodeToUTF8(LPCTSTR szSource)
{
CStringA utf8str;
#ifdef _UNICODE
int utf8length = ::WideCharToMultiByte(CP_UTF8, 0, szSource, -1, NULL, 0, NULL, NULL);
if (utf8length > 0)
{
char *utf8strchars = utf8str.GetBuffer(utf8length - 1);
::WideCharToMultiByte(CP_UTF8, 0, szSource, -1, utf8strchars, utf8length, NULL, NULL);
utf8str.ReleaseBuffer();
}
#endif
return utf8str;
}
Note I changed the return type to a more specific CStringT type that
is the most appropriate for UTF-8.
Mark Salsbery
Microsoft MVP - Visual C++
![Java | [Coffee]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/coffee.gif)
|
|
|
|
|
Hi,
is there a way to switch off implicit inline,
that is
class ClassOfImplementationNamespace
{
void itsFunc(int x)
{
}
};
should no more give a compiler hint automatically,
to inline this. Something like a #pragma NoImplicitInline?
Thank you,
Werner
|
|
|
|
|
WernerP wrote: Something like a #pragma NoImplicitInline?
You are possibly looking for auto_inline(off)[^].
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
|
|
|
|
|
WernerP wrote: is there a way to switch off implicit inline,
Such as the /Ob0 compiler switch?
There's also #pragma auto_inline(off).
"Love people and use things, not love things and use people." - Unknown
"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch
|
|
|
|
|
I think it's the compiler option "/Ob0" you want.
See here[^].
"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown
|
|
|
|
|
Thank you. I'm not quite certain, whether this is, what I want.
What I definitely do not want is to prevent the compiler from inlining. I think it knows best.
What I actually want is to switch that implicit "inline" off, which is automatically associated with the function, although you don't see it, and which is a sweettalk to the compiler to inline the function whatever might be best.
Werner
|
|
|
|
|
WernerP wrote: What I definitely do not want is to prevent the compiler from inlining. I think it knows best.
..........
What I actually want is to switch that implicit "inline" off, which is automatically associated with the function, although you don't see it, and which is a sweettalk to the compiler to inline the function whatever might be best.
I find these two conditions to be contradictory.
In the first you want the compiler to decide, but in the second you don't want it to be automatic....  
It's probably the compiler option "/Ob1" you want, but you should also have a look at what happens when you're using the keywords for inlining here[^].
"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown
|
|
|
|
|
Roger Stoltz wrote: find these two conditions to be contradictory.
In the first you want the compiler to decide, but in the second you don't want it to be automatic.... Confused Unsure
In the second I *want* it to be automatic. That's my point. The inline keyword, and I think implicit inline too, means, that you don't let the compiler be automatic but try to tell him what to do. This is what I *don't* want and would like to switch off.
Regards
Werner
|
|
|
|
|
WernerP wrote: The inline keyword, and I think implicit inline too, means, that you don't let the compiler be automatic but try to tell him what to do.
Read the link I provided in my previous post and you will find that you cannot force the compiler to do inline expansion, not even with __forceinline.
The "implicit inline" your talking about must be the "/Ob2" compiler setting, thus if you're not compiling your code with that option, there won't be any "implicit inline".
"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown
|
|
|
|
|
I will do that. Thank you. Maybe I misunderstood the definition of implicit inline? I understood, that if a function is defined like that
class A
{
void someFunc()
{
}
}
this is equivalent to
inline void A::someFunc()
{
}
and I want it to be equivalent just to
void A::someFunc()
{
}
Best regards
Werner
|
|
|
|
|
WernerP wrote: The inline keyword, and I think implicit inline too, means, that you don't let the compiler be automatic but try to tell him what to do. This is what I *don't* want and would like to switch off.
Marking something as inline (while you think it would be beneficial) may turn out to be expensive too (well, with certain cases). So, the best way is to let the compiler do the dirty work for you. I am believing that I can never outsmart the compiler on making such a decision.
With the default settings, the compiler won't inline any function automatically.
BTW - Instead of the switch, the #pragma directive would give you greater flexibility on where to impose the restriction, in case you need it.
[Added] BTW - if that is you who has low-voted this post of mine, please do let me know what is that you feel so bad about it. 
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
modified on Tuesday, October 14, 2008 11:29 AM
|
|
|
|
|
Dear Rajesh,
I am very sorry, this happened automatically because in Germany marks at school are like that 1 = best, 6 = worst. I still can't get rid of that.
Thank you very much and best regards
Werner
|
|
|
|
|
WernerP wrote: I am very sorry, this happened automatically because in Germany marks at school are like that 1 = best, 6 = worst. I still can't get rid of that.
Thanks for the explanation. It is times like this when I realise CP is a truly global community.
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
|
|
|
|
|
but the true question is : why would you do that ?
|
|
|
|
|
Perhaps he's a C# (or Java) fan.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
Hi,
Because dividing class function declaration from definition does make sense, if the interface is to be seen by other modules. If the interface is just for the imlementation namespace of a certain module, I would not even put it into a header.
Why? Because I don't want to recompile other modules, if the private interface changes. And because splitting declaration from definition means more administration of code and higher cost. It's overhead, if I don't want to export the functions it declares to others.
This I think is a common concern of software engineering, and does not have to do with loving either one programming language or the other. Look, C++ has been called a multiparadigmatic language by it's founder. It should make us free to implement whatever pattern makes sense to us.
Werner
|
|
|
|
|
WernerP wrote: This I think is a common concern of software engineering, and does not have to do with loving either one programming language or the other. Look, C++ has been called a multiparadigmatic language by it's founder. It should make us free to implement whatever pattern makes sense to us.
Consider why Tox asked the question he did (and that English is not his native tongue). It was not to belittle you, but more to find out if you actually knew what you were doing and why, or were just doing it because a friend's cousin's boss said it was the way to go. You'd be surprised at the number of questions we see here that should not be asked. That doesn't mean that the poster did not have a legitimate concern; it just means that they did not understand the problem first.
"Love people and use things, not love things and use people." - Unknown
"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch
|
|
|
|
|
Well said David.
"It's supposed to be hard, otherwise anybody could do it!" - selfquote
"High speed never compensates for wrong direction!" - unknown
|
|
|
|
|
I do agree. Tox's question was the most interesting answer to mine I found, and so I was much interested in discussing it. I'm very sorry, if my message sounded unfriendly. It wasn't meant to be at all.
|
|
|
|
|
Hi All
I am useing CFolderDialog for Browser file and folder path.These path shwoing in Edit box.Now i want to open those file/folder which is currently showing in Edit Box.Plz help me
modified on Tuesday, October 14, 2008 6:59 AM
|
|
|
|
|
ShellExecute() with open may be?
I am not sure if I get what you want to do.
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
|
|
|
|
|
yes you are right i am useing this code
ShellExecute(handle, "open",<pathname>, NULL, NULL, SW_SHOWNORMAL);
</pathname>
Then i am geting this error error C2065: 'handle' : undeclared identifier.
I include shellapi.h.Plz help me
|
|
|
|
|
From the doc:
To open a folder, use either of the following calls:
ShellExecute(handle, NULL, <fully_qualified_path_to_folder>, NULL, NULL, SW_SHOWNORMAL);</fully_qualified_path_to_folder> or
ShellExecute(handle, "open", <fully_qualified_path_to_folder>, NULL, NULL, SW_SHOWNORMAL);</fully_qualified_path_to_folder>
And the handle should be the handle of your own window. The handle can be NULL too, but know what you're doing.
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
|
|
|
|
|
Thanks for reply.
But what it mean sir
The handle should be the handle of your own window
I am useing indos vista.So what can i do.I am new sir so plz help me
|
|
|
|
|
Every window will have a handle associated with it. If it doesn't matter to you, then pass NULL instead of your window handle.
BTW, Please stop saying "plz hlp me" in each and every message that you post. There isn't any real need for that. People will help you out here, provided you give adequate information.
Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche
.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
