|
They are all bad designs. What happens if you add a new checkbox? Have a read around on patterns, and see why this set of implementations is bad. BTW - those are really bad names for your checkboxes.
|
|
|
|
|
Not good design at all. You may want to stick to real names for the checkboxes as Pete has said. It would make it easier to read and know what each checkbox belongs to.
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
"Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon
"Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
|
|
|
|
|
My question is not about naming controls or variables, therefore, I did not give them very meaningful names. Of course, I would give them meaningful names in real projects.
If none of them are good designs then can you recommend a good one? I do know patterns and I use them all the time, however, I am not sure what patterns have to do with creating good subroutines. Can you please clarify or recommend a reading.
|
|
|
|
|
I posted this [^] on another forum but got no answer. I'm referencing it here in case you want some background on why I need to do this.
In short, I want to detect analog beacon radar pulses, that have already been converted from an A/D board to values between 1 and 256, the Y component or amplitude levels. The data is sampled at a 2 ns rate or 500 Mhz which comprises the X component. Typically, from what I've been told is that pulse lead edge detection and time stamping the LE is done using hardware. I'm not planning on posting all of the requirements but suffice it to say that I will meet all requirements if I can design the foundation of which this topic addresses.
I'm approaching this in two ways based mostly on my empirical observations of the raw data.
Using a plot program I can plot the continuous waveform and see where hardware or software would have some problems separating the pulses. Pulses must meet a minimum width and have various pulse to pulse and other timing tolerances. Of course, individual pulses are really part of a pulse train of a particular type of message, and can be correlated by amplitude and bit position once the pulses have been extracted as pulse records with attributes for the LE, TE, pulse width, plateau or amplitude, overlapped, etc.
1) Pulses of different signal level or amplitude can be intermixed, interleaved, or overlapped sometimes causing wide pulses where two or more pulses of different amplitudes may be joined and the Trailing Edge (TE) from the first pulse may not be detectable, though recoverable, using extrapolation of any downward slope. Pulses, that do not meet minimum width constraints and occasionally of significant amplitude are most likely noise and can be discarded or not stored. Noise can also interfere with pulse width sometimes causing a TE to be initially indiscernible or undetectable unless a small TE can be detected first.
2) I am performing my code design based on how I, a human, would interpret the individual pulses based on an empirical observation. Consequently, I and the program would process the data from left to right or for the direction of X where X equals time, in an increasing time reference.
Before I get too far, my initial question regarded using a state machine as part of the design to perform the pulse processing. Since that time, I already have started coding some of this in the manner #2 described above. When separating individual pulses from combined pulses and when separating pulses when TE's do not return to zero or the noise floor, changes in direction of slope (downward or upward ) I am running into some slight problems.
I've decided that a sliding window history (implemented as a circular queue) of my last 5 slope directions that the pulse is/was travelling could be used to construct a scoring algorithm to try to determine how confident I am about the waveform's future detection into individual pulses. For example, if I am following a TE pulse to about the 3 db point below the pulse's plateau, if I get say 3 consecutive hits in a change of direction initially from a downward slope to a rising slope, then depending on the existing pulse's width up to that point, I could be processing a noise spike, or a second pulse. Suffice it to say, I now just assume that if I have reached a -3 db point (~ 70% of pulse plateau level) and the pulse meets minimum width tolerance, I can just declare it a pulse and save its characteristics.
I want to assign a higher score based on a high degree of confidence that the direction change in slope is not momentary but for a longer period of time. I could also use a second scoring algorithm to assign higher levels of confidence to pulses that do return more to the noise floor perhaps all the way to the floor or the -6 db point.
Now, getting back to program design, IMHO I have discovered that, to me, there is no easy way to code this. There are several possibilities that exist once the LE, and plateau have been acquired: a normal TE could follow resulting in a clean pulse, a noise spike can temporarily occur as part of the TE widening the pulse slightly, a noise spike can be of significant enough of amplitude or width to be possibly interpreted as a secondary pulse adjacent to or following the pulse we were processing, an actual second pulse could be occurring intermixed with noise such that the first pulse's TE never returned to the noise floor or the noise floor is high as compared to the pulse or pulse train's amplitude level. Consequently, the LE for the second pulse may only be observable from say the -3 db point below the second pulse's plateau level.
After thinking about these possibilities and that you or the algorithm processing the continuous waveform won't really know what condition you have until after it occurs, this does not allow for calling of functions in a sequential or logical manner and have found that most or all possibilities must be included in a single function that looks for all of these possibilities. Needless to say I have made some progress and would appreciate any suggestions in design or in helping with coding suggestions.
|
|
|
|
|
I have a form which is used for data entry and then data is saved by pressing a button. I load numerous controls in the load event of the form. When user saves, I just hide the form so I do not have to load all the data again when user I show the form again. This also means I have to clear all the controls for the next time the form is shown.
I am using events of controls to change properties of classes I have. For example, in textchanged event of textbox I might have something like: employee.Name = TextBox1.Text where employee is an object. However, when I hide the form I have to clear the text box which causes the text changed event. I can have a boolean variable (something like cleaningUp) set to true during hiding of the form. If this variable is set to true then it will exit the text changed event handler. Alternatively, I can also remove the handler for text box before I clear it up and then rewire it. This is a lot of work with a form which has many controls.
What am I doing wrong? Is there a better way of accomplishing my task?
|
|
|
|
|
CodingYoshi wrote: This is a lot of work with a form which has many controls.
Yes it is. Littering windows with individual controls for each individual data point is what I call the Bug Splat User Interface technique. It's not user friendly and it's not coding friendly. Prefer to use controls like PropertyGrid for data entry. They are both user friendly and coding friendly.
led mike
|
|
|
|
|
PropertyGrid? I do not understand how that will help? Can you elaborate with a simple class please.
|
|
|
|
|
CodingYoshi wrote: I do not understand how that will help?
Sorry, I have no idea how to help you understand things. I can provide information, but it is up to you gain the requisite knowledge to understand the information.
Getting the most out of the PropertyGrid[^]
led mike
|
|
|
|
|
I kind of like the idea of that a bit but you would really use that for something like, a customer data entry form instead of using a form that has individual controls on it?
Never though about it before bit maybe...
|
|
|
|
|
Ray Cassick wrote: instead of using a form that has individual controls on it?
Yes. Your other parts of the UI provide views and navigation mechanisms of the system. When the user selects something in the system that has multiple data points that can be edited you use the PropertyGrid.
led mike
|
|
|
|
|
led mike wrote: Littering windows with individual controls for each individual data point is what I call the Bug Splat User Interface technique.
led mike wrote: Prefer to use controls like PropertyGrid for data entry. They are both user friendly and coding friendly
Yes, and the OP will find there could be less complaints from the user, as well.
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
"Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon
"Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
|
|
|
|
|
CodingYoshi wrote: I can have a boolean variable (something like cleaningUp) set to true during hiding of the form. If this variable is set to true then it will exit the text changed event handler.
There's nothing wrong with this approach; I've had to use it myself.
The problem is with the design of the controls, in my opinion. The XXXChanged events do not in most (all?) cases distinquish between changes generated by the user and those generated programmically. As a result, your event handler can't tell the difference. So you wind up having to use a kludge like a boolean flag to indicate when the event is being raised in response to the user's action as opposed to being raised in response to a change made programmically.
|
|
|
|
|
Used to do it similar to what you mentioned, except I did not use XXChanged to repopulate back to the business object. It was messy.
Now I mainly use DataBinding. The controls are unbound before the save, then I just clear the controls according to the control type. At least the code is cleaner and more uniform now.
|
|
|
|
|
I need to create a VB.NET service to exchange files with an a PDA using Telnet protocl. The PDA sends/receives files from an AS/400, a Unix box and a Microsoft FTP server, but all of the "chat" examples I've found can not be used. I have the C code from the Unix application and I'd like to create methods in C++ that I can call from my VB.NET project.
Can anyone send me any examples?
TIA!
Mike
Greetings from Kalamazoo, MI
|
|
|
|
|
There are articles around here showing how to call C++ methods in VB.NET, you'll have to do a search on that 
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
"Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon
"Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
|
|
|
|
|
Try Using a COM Object to Wrap around your C++ methods and libraries. so you can adapt it to other systems
JO
|
|
|
|
|
Hello,
I've a C function that take function ptr in argument:
double CFunc(
double (*funcptrA)(char *),
double (*funcptrB)(char *),
double (*funcptrC)(char *)
);
And I would like to transform it in a cool object design.
I've tried a lot of solutions (functor, interface) but the only way my compilator agree is to declare argument functions (funcptrABC) as static.
To illustrate, Here 's what i wrote first:
#include CFunc.h
class CplusFunc{
virtual double A(char*);
virtual double B(char*);
virtual double C(char*);
double CplusExec(){
retrun Cfunc(&A,&B,&C);
}
};
It doesn't work but give the semantic i would like to give to my object.
Have you got an idea?
|
|
|
|
|
mp3butcher wrote: but the only way my compilator agree
mp3butcher wrote: Have you got an idea?
Well if you are using VC++ 2008 there is the newly added support for TR1 including Polymorphic Function Objects[^]
led mike
|
|
|
|
|
I wrote portables applications for windows linux & mac then I search a portable technic that avoid the use of a microsoft specific one...But thanks for the idea
|
|
|
|
|
mp3butcher wrote: that avoid the use of a microsoft specific one
I don't know why I am bothering with this since you obviously don't actually READ the links I give you but TR1 is from the ISO C++ committee[^] and was published in 2005. So there might be any number of compilers that currently support some of it.
led mike
|
|
|
|
|
|
|
Excuse me for my fast answer, but I've seen this syntax in boost but I don't understand how to make it work:
MSVC2008 Compiler tells that member pointer functions,pointer function and boost::function haven't the same signature...
So, I can't pass to my c function otherthing than a static (member) pointer function
Can you, please, explain me further?
|
|
|
|
|
mp3butcher wrote: MSVC2008 Compiler tells that member pointer functions,pointer function and boost::function haven't the same signature
Well I don't know what you did since you posted no code. What I do know is that I successfully reproduced the concepts discussed in that article I linked to using MSVC2008
Also I am now confused as to what you are attempting to do. You originally seemed to be asking about design but in this last post you say:
mp3butcher wrote: So, I can't pass to my c function otherthing than a static (member) pointer function
Your C function is what it is. If you are asking what you can use to match the parameters of that function that's not even a design question.
If you are asking about design, I suggest you look at using interfaces rather than function pointers or functors or any of those new mechanisms.
"All other things being equal, the simplest solution is the best."
|
|
|
|
|
In fact my question has two linked aspects:
As I can't pass otherthing than a static member function to my cfunction( double (*g)(char*)):
1)I would like to know how I could make it a real parameter (not hardcoded) that belong to the caller of Cfunc.
2)I would like to know how I could make a cool cpp design permitting to overload the argument pointer function.
Then the design side of my question is the second aspect.
First I would like to parametrize my cfunction with member function belonging to the caller object...
If you see a manner to do it passing other thing that a static member function, I would be very glad.
PS: I think what i've done with the function<> template is not what you're thinking of:
class CPP{
double funcparam(char*);
void exec(){
function2<double> f=&CPP::funcparam;
CFUNC(f);
}
};
Silly isn't it?:(For this I think I haven't understand what to do... 
the only way I've found to make it work is:
class CPP{
static double funcparam(char*);
void exec(){
CFUNC(&funcparam);
}
};
but it don't permit to overload funcparam...
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
