|
Hi,
Can anyone explain to me why in the below code, the List that I added to the dictionary is being cleared by the line of code after it.
NOTE: This method is running in a seperate thread, and allAdaptersAndPorts is a volatile instance variable.
<br />
DSPortAdapter adapter = null;<br />
List<string> portsList = new List<string>();<br />
String portBuff = null;<br />
<br />
try<br />
{<br />
for (Enumeration adapterEnum = OneWireAccessProvider.enumerateAllAdapters();<br />
adapterEnum.hasMoreElements(); )<br />
{<br />
adapter = (DSPortAdapter)adapterEnum.nextElement();<br />
<br />
for (Enumeration portEnum = adapter.getPortNames();<br />
portEnum.hasMoreElements(); )<br />
{<br />
portBuff = (String)portEnum.nextElement();<br />
portsList.Add(portBuff);<br />
}<br />
<br />
this.allAdaptersAndPorts.Add(adapter.getAdapterName(), portsList);<br />
portsList.Clear();<br />
}<br />
}<br />
<br />
catch (OneWireException ex)<br />
{<br />
DebugHelper.LogError(ex, true);<br />
}<br />
</string></string>
Cheers,
|
|
|
|
|
MarkBrock wrote: Can anyone explain to me why in the below code, the List that I added to the dictionary is being cleared by the line of code after it.
MarkBrock wrote: portsList.Clear();
Because you are calling Clear on this list and Clear method clears the list.
I guess you thought that clearing portsList wouldn't clear the list in the dictionary but you have forgotten that List class is reference type so what's actually stored in portsList is reference to the list so when you clear the reference, it gets cleared in the dictionary too. To avoid this you can add a copy of the list to the dictionary.
Giorgi Dalakishvili
#region signature
my articles
#endregion
|
|
|
|
|
Yup that did the trick thanks for your help.
I hadnt realised it was a reference being stored in the dictionary 
Cheers,
|
|
|
|
|
Glad to help you 
Giorgi Dalakishvili
#region signature
my articles
#endregion
|
|
|
|
|
Like so:
try
{
for (Enumeration adapterEnum = OneWireAccessProvider.enumerateAllAdapters();
adapterEnum.hasMoreElements(); )
{
DSPortAdapter adapter = (DSPortAdapter)adapterEnum.nextElement();
List<string> portsList = new List<string>();
for (Enumeration portEnum = adapter.getPortNames();
portEnum.hasMoreElements(); )
{
portsList.Add((String)portEnum.nextElement());
}
this.allAdaptersAndPorts.Add(adapter.getAdapterName(), portsList);
}
}
catch (OneWireException ex)
{
DebugHelper.LogError(ex, true);
}
What I've done:
1. Moved variable declaration into the smallest scope (set of curlys) possible. In most cases that means you can initialize them in the declaration as well. Neither has any effect on performance whatsoever, the compiler will see to that, but it makes the code more compact and more readable. Good for maintainability.
2. For each adapter, I create a new list, which I add to the dictionary (the reference in portsList gets dropped at the closing curly, but as it is now held by the dictionary element, all is as it should be). No need to copy the list elements into a new list (which is very expensive - it is an extra loop over all the elements even if you let the framework do the job), and no need to clear it.
Should work, should be faster than copying the list.
By the way, what is the Enumeration thingy? Seems cumbersome... I would expect to see something like this:
try
{
foreach (DSPortAdapter adapter in OneWireAccessProvider.AllAdapters)
{
List<string> portsList = new List<string>();
foreach (DSPort port in adapter.Ports)
{
portsList.Add(port.Name);
}
allAdaptersAndPorts.Add(adapter.Name, portsList);
}
}
catch
{
DebugHelper.LogError(ex, true);
}
Assuming you have control over the classes concerned, of course. The "get" prefixes look like someone hasn't understood properties properly, and some healthy use of generics could save you some casts here and there...
Peter the small turnip
(1) It Has To Work. --RFC 1925[^]
|
|
|
|
|
Hi Peter,
Thanks for the help, ive changed a few things from your recommendations.
PeterTheSwede wrote: By the way, what is the Enumeration thingy? Seems cumbersome... I would expect to see something like this:
Yea I tryed foreach, but the class library i'm using to access the 1-wire stuff is written in java, it wont let me cast to a C# enumerator.
PeterTheSwede wrote: Assuming you have control over the classes concerned, of course. The "get" prefixes look like someone hasn't understood properties properly, and some healthy use of generics could save you some casts here and there...
where abouts did you have in mind? If your talking about in the DSPortAdaapter class I have no control over it (its a reference).
Cheers,
|
|
|
|
|
MarkBrock wrote: ... the class library ... is written in java ...
That explains the explicit Enumeration usage and possibly the strange naming conventions... 
MarkBrock wrote: If your talking about in the DSPortAdaapter class I have no control over it
Exactly what I meant and was afraid could be the case. Never mind my second rewrite then...
Peter the small turnip
(1) It Has To Work. --RFC 1925[^]
|
|
|
|
|
Hi all
Is exists a way to bind property to control through (this[string])
Ex:
<br />
<br />
protected override void OnLoad(EventArgs e)<br />
{<br />
base.OnLoad(e);<br />
<br />
DataSrc ds = new DataSrc();<br />
<br />
this.DataBindings.Add("Text", ds, "Prop1");
<br />
}<br />
<br />
...<br />
...<br />
...<br />
<br />
public class DataSrc <br />
{<br />
public object Prop1 { get { return "Prop1"; } }<br />
}<br />
<br />
But i realy need to bind control not throug explicit defined property (in case above Prop1) but through this[string PropName] property
Ex:
<br />
<br />
protected override void OnLoad(EventArgs e)<br />
{<br />
base.OnLoad(e);<br />
<br />
DataSrc ds = new DataSrc();<br />
<br />
this.DataBindings.Add("Text", ds, "Prop1");
<br />
}<br />
<br />
...<br />
...<br />
...<br />
<br />
public class DataSrc <br />
{<br />
public object this[string PropName] <br />
{<br />
get <br />
{ <br />
switch(PropName)<br />
{<br />
...<br />
case "Prop1":<br />
return "Prop1"; <br />
}<br />
} <br />
}<br />
}<br />
<br />
Is exists way to do such way????
THANK
|
|
|
|
|
How would you define the PropName? Isn't the whole point of "Prop1" in
this.DataBindings.Add("Text", ds, "Prop1") is to let you define in string which property that you want to bind to?
|
|
|
|
|
Obviously i was not very clear.
this.DataBindings.Add("Text", ds, "Prop1") - for my purpose "Prop1" - should be not property name, but parameter what should pass to this[string PropName] method. The same way as this act when datat source object is DataRow.
|
|
|
|
|
You were very clear, obviously I was not very clear. 
You can't just take an indexer and use it as property because they look roughly the same. If you really really want to do that, you probably should create a property for each of the indexer.
|
|
|
|
|
-you probably should create a property for each of the indexer
Good News Evryone (c) futurama
It's realy hard when you have about 50 fields.
Probably had to implement this throught DataRow class.
|
|
|
|
|
ORM code generator, map the fields in datarows into data objects.
BTW, if you map them to data objects, remember to implement OnPropertyChanged or OnXXXXXXChange, or the updating won't be bi-directional.
modified on Friday, May 23, 2008 7:38 AM
|
|
|
|
|
ORM code generator - what is this???
Actualy for my objective realy convient to use indexer, since all this invokation i suppose
to delegate for internal object what also have same indexer.
public System.Drawing.Color MyStubObject::Indexer[string FieldName]
{
if (ContainedDataRow[FieldName, Original] != ContainedDataRow[FieldName])
{
return System.Drawing.Color.LightGreen;
}
else
{
return System.Drawing.Color.White;
}
}
....
control1.DataBindings.Add("EditValue", dataRow, "CLIENT");
control1.DataBindings.Add("BackColor", dataRow.stubObject, "CLIENT");
control2.DataBindings.Add("EditValue", dataRow, "ACCOUNT");
control2.DataBindings.Add("BackColor", dataRow.stubObject, "ACCOUNT");
This way i have all modifyed fields on form with lighted beckground.
|
|
|
|
|
ORM Wiki[^]
Basically you will be working on an object that is mapped to your data, instead of working on datatable, datarow, datacolumn, etc.
You may want to look at whether you can write your own DataBinding for binding to the columns of datarow, good luck. 
|
|
|
|
|
Hi ,
I am using the following code to merge a number of word docs.
Word._Document wordDocument = wordApplication.Documents.Add(
ref missing
, ref missing
, ref missing
, ref missing);
Word.Selection selection = wordApplication.Selection;
foreach (string file in filesToMerge)
{
selection.InsertFile(
file
, ref missing
, ref missing
, ref missing
, ref missing);
if (insertPageBreaks)
{
selection.InsertBreak(ref pageBreak);
}
}
selection.
wordDocument.SaveAs(
ref outputFile
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing
, ref missing);
Testing showed that for certain documents all formatting was preserved yet for some documents it changed the font to Times New Roman size 12.
Any ideas to what would cause this as I am stumped.
Thanks in advance.
Ryan.
|
|
|
|
|
Hi ,
I am facing a problem . I have a windows application, from that
application i want to connect to one running instance of Mozilla
browser. I also want the event notification back from Mozilla browser
to windows application.
Please suggest some ideas .
Thanks & Regards
Mihir
|
|
|
|
|
|
Hello,
I have a .xsl document and I need to retrieve the data row by row (I would like to have the name of the column and the value for each record to use these information later)
Please help me, if you now how it is possible to do
Thanks in advance,
Bye
|
|
|
|
|
There are two ways to read xls files:
1.Excel Object model
2.Ole db adapter for excel
There are many sample on the web and codeproject. If you searched, you would find them.
Giorgi Dalakishvili
#region signature
my articles
#endregion
|
|
|
|
|
I've used this[^] before. The free version works fine but is limited to how many rows and sheets - the pro version costs.
Dave
|
|
|
|
|
Hi,
I am Developing an windows application i want when ever my application runs then form opacity will increase slowly from 0 to 100% on timer tick.
Thanks & Regards
|
|
|
|
|
In the event handler of the timers tick event increase opacity of the form according to your needs. Make sure you don't increase it after you reach 100%
Giorgi Dalakishvili
#region signature
my articles
#endregion
|
|
|
|
|
Hi, I'm developing a pocket pc(windows ce) application in visual studio with c#.
I build my forms controls(tabs,literal,textbox)from c# code (I parse an xml file and generate in on fly).
In whic mode i can put my objects in precise mode inside form?
For example:
literal -> textbox
literal -> combobox
literal -> textbox
ecc..
(2 cols and n rows ecc )
In compact framework i can't find Form.TablePanel.
There are other controls that allow it?
Suggestions? 
Thanks!!!
|
|
|
|
|
Hi,
I want to do a peculiar thing..
I want to run my console application in my system tray..
Can anyone tell me how to do this?
(My console app is more than a normal console app, it does many things in background, so want to do this)
Thanks..
modified on Friday, May 23, 2008 4:15 AM
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
