C / C++ / MFC

26-Apr-08 12:54

hi
i have this func :

void CForm1::OnCommand1()<br />
{<br />
	// TODO: Add your control notification handler code here<br />
	 CComVariant retval;	// - "AutoDim"<br />
<br />
	 CString app_path;<br />
	 CString Icon;<br />
     <br />
	app_path = Str(App.path)+CString("\\")+Str(App.EXEName)+".exe";<br />
	Icon = Str(App.path)+CString("\\")+"book.ico";<br />
<br />
	retval = Associate_File(".abd", app_path, "abd_ext", "My own extension", Icon);<br />
	AfxMessageBox(("Associated the file extension .abd with this application!"));<br />
<br />
}

and its converted from VB code by aprogram called VBto convertor.
when i compiled it , it shows an error that
error C2065: 'App' : undeclared identifier and
error C2228: left of '.path' must have class/struct/union type
as i understand .. App is aclass in VB
so my question is
Is There any equivalent class in vc++ for the App?
and if not ...
can someone please tell me what can i do about this?any help would be appreciated .
thanks in advance.

lahom

Saurabh.Garg26-Apr-08 15:52

Saurabh.Garg

26-Apr-08 15:52

There is no class in VC++ for this but you can use GetModuleBaseName and GetModuleFileName to achieve same thing.

This code snippet will give you the full path to the exe i.e. app_path.

char buffer2[2048];<br />
GetModuleFileName(NULL, buffer2, 2048);

This code snippet will give you the name of the executable path.

HANDLE hProcess = GetCurrentProcess();<br />
char buffer1[2048];<br />
DWORD r1 = GetModuleBaseName(hProcess, NULL, buffer1, 2048);

So if path of running application is C:\Windows\System32\Foo.exe. GetModuleFileName will return C:\Windows\System32\Foo.exe and GetModuleBaseName will return Foo.exe. Using these two string you can easily get path of Icon which should be C:\Windows\System32.

-Saurabh

Ozer Karaagac27-Apr-08 3:01

27-Apr-08 3:01

I don't know anything about VBto convertor. However, I'm trying to answer.

When using MFC (seeing that CString and AfxMessageBox() were used in your code snippet), there is a class named CWinApp. You can get it by calling AfxGetApp() but none of its members provides exactly what you need although it has public data members like m_pszAppName, m_pszExeName.

You can use following functions appropriately to get fully qualified executable file name and folder name.

Like;
app_path = GetExeName();
Icon = GetExeFolder() + "\\book.ico";

CString GetExeName()
{
  CString str;
  DWORD dwLen = GetModuleFileName(NULL, 
           str.GetBufferSetLength(_MAX_PATH), _MAX_PATH);
  // AfxGetApp()->m_hInstance can be used instead of NULL
  str.ReleaseBuffer(dwLen);
  return str;
}

CString GetExeFolder()
{
  CString str = GetExeName();
  LPTSTR psz = _tcsrchr(str.GetBuffer(1), _T('\\'));
  if(NULL != psz)
    *psz = _T('\0');
  str.ReleaseBuffer(-1);
  return str;
}

lahom3-May-08 8:45

3-May-08 8:45

hi iam sorry that it took me so long to reply to ui tried using the two functions u provided me >>>> but when i check the registry ....
i found that there is no directory specified for the extension i made "for example .ccc" .i mean there is a folder for the extension but with no directory specified for the "open " command for example.
i also tried the GetModuleFileName and GetModuleBaseName
but it also the same thing ...
no directory for the icon or the commands as well.....
what shall i do now?
thank u very much for ur help all
it was very helpful.
now iam just one step away from finishing.
this is "I HOPE" the last thing to complete the creation of the associate file type
again....THANK u all

lahom

Ozer Karaagac3-May-08 10:59

3-May-08 10:59

Have you ever watched the return values of the functions that I provided?

As I understand, you are trying to associate an extension to your application.

There should be a string value under that extension key, named ".abd" for your example, as following.
(Default) | REG_SZ | "abd_ext" (in right pane of regedit, Name, Type, Data columns respectively)

"key" means "directory" in your terms.

In addition, there should be another key with the name "abd_ext".
Under that abd_ext key, DefaultIcon and Shell/Open/Command keys should exist.

Please, check if they exist.

If not, there should be a problem within your Associate_File() function, I think.

lahom3-May-08 11:32

3-May-08 11:32

well everything u mentioned exists.
but with no directory shown in the right pane of regedit
what shown exactly for example is"for example":
(Default) | REG_SZ | u+s
as well as for the DefaultIcon and Shell/Open/Command keys ..
so i think the Associate_File() is working fine
what do u think the problem is and how to solve it...

lahom

Ozer Karaagac3-May-08 12:25

3-May-08 12:25

The same in mine (in WinXP SP2). So, we can say that regedit doesn't show directories in the right pane. Smile | :)

BTW, I didn't really understand what the problem is? Could you explain more?

lahom3-May-08 12:49

3-May-08 12:49

ok the problem is that
in the application demo that i have, when pressing the button....amessage box appears saying that the file type .abd has been associated
and when naming any text file with .abd ..... it would be open in the demo program showing the content of the file in the dialog box....ok
when i tried to do it my self with another extension".ccc"
everything going good when pressing abutton saying the same thing and eveything ....but where is the difference?
it is when i try to name a text file with the extension .ccc nothing happend and icant open it "it wont see the file type"....
and also as i said before when checking and comparing the .abd AND .ccc
i found that .abd has directory for the command and the defaulticon...where for the .ccc there is not just something like"s+I" or ")]"
which is nothing exactly
i dont know what is wrong
did u get the idea?
iam really stuck in this
thanks for ur PATIENCE

Ozer Karaagac3-May-08 13:35

3-May-08 13:35

lahom wrote:
it is when i try to name a text file with the extension .ccc nothing happend and icant open it "it wont see the file type"....

Check to make sure that you successfully renamed the file extension.
(Depending on which version of Windows OS you use)
There is an option in Windows explorer settings. Under Windows Explorer's Tools menu, there is a menu command "Folder Options...", if you run it, Folder Options dialog box pops up. In view tab of this dialog, you will see "Advanced Settings:" control, find "Hide extensions of known file types" check box and clear it (remove check mark). Then, have a look the file which you wanted to rename. txt extension may still there.

Which version of Windows OS you use?

lahom3-May-08 14:13

3-May-08 14:13

iam sorry ...maybe i wasnot clear enough

Ozer Karaagac wrote:
lahom wrote:
it is when i try to name a text file with the extension .ccc nothing happend and icant open it "it wont see the file type"....

i didnt mean it like that .
what i menti is that when i rename "example.txt"
to "example.ccc"
the file would chang to unknown file and need to open with "open with"
which is not the case in "example.abd"
where it would open normally in the demo application specified before.
i hope i was clear this time
by the way "i use windows xp pro"

Ozer Karaagac3-May-08 14:49

3-May-08 14:49

Well, what are the Default values of shell/open/command and DefaultIcon of the file type when you look into them by regedit? You may also use "Advanced" button in "File Types" tab of Folder Options dialog box.

If shell/open/command points a file which can not be found, file association won't be valid.

lahom4-May-08 3:25

4-May-08 3:25

Ozer Karaagac wrote:
what are the Default values of shell/open/command and DefaultIcon of the file type when you look into them by regedit?

ok
for the "example.abd"it is as the following:
folder: ext_abd (Default) REG_SZ My own extension
folder: Defaulticon (Default) REG_SZ C:\Documents and Settings\MooNPC\Desktop\my folder\project\FileAssociate_demo\book.ico
folder: shell (Default) REG_SZ (value not set)
folder: open (Default) REG_SZ (value not set)
folder: command (Default) REG_SZ "C:\Documents and Settings\MooN PC\Desktop\my folder\project\FileAssociate_demo\File_associate.exe" "%1"
//**************************************************************//
but for the "example.ccc" it is like this:
folder: ext_ccc (Default) REG_SZ <+B
folder: Defaulticon (Default) REG_SZ ce)B
folder: shell (Default) REG_SZ (value not set)
folder: open (Default) REG_SZ (value not set)
folder: command (Default) REG_SZ \$B
//*********************************************************************//
this is what is shown in the regedit
so
what do u think?
help pleeease

Ozer Karaagac4-May-08 13:05

4-May-08 13:05

Yes. They all seemed garbage values.
It also seems that some of the parametes, are passed to Associate_File() funtion, have a problem including 4th parameter which is just a string (i.e. "My own extension"). However, another string parameter "ext_ccc" have not. Because a registry key has been created with that name. I think, the problem may be in Associate_File() funtion. At first, we have to be sure for the parameter values which are passed to Associate_File() funtion.

Could you please re-post your code snippet with the latest changes that you've posted earlier?

And how do you use strings in your project ANSI or UNICODE?

lahom4-May-08 13:28

4-May-08 13:28

ok this is the associate file function:

CComVariant Associate_File(CString Extension, CString Application, CString &Identifier, CString Description, CString Icon)<br />
{<br />
	CComVariant Associate_File;<br />
<br />
	 LONG lRtn; // Returned Value From API Registry Call<br />
	 HKEY hKey = NULL;  // Handle Of Open Key<br />
	 int lValue; // Setting A Long Data Value<br />
	 CString sValue; // Setting A String Data Value<br />
	 int lsize; // Size Of String Data To Set<br />
	 CString commandline;<br />
     DWORD  dwDisp;<br />
     //const unsigned char* Identifier;<br />
	// Create The New Registry Key, the file extension<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, Extension, 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	lsize = Identifier.GetLength(); // Get Size Of identifier String<br />
	// Set "(Default)" String Value to identifier<br />
	lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Identifier, lsize);<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox("Error Setting String Value!");<br />
		RegCloseKey((hKey));<br />
		return Associate_File;<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
<br />
	// Create The New Registry Key, the file extension identifier<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, Identifier, 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	lsize = Description.GetLength(); // Get Size Of file type description String<br />
	// Set (Default) String Value to description of the file type<br />
	lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Description, lsize);<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox("Error Setting String Value!");<br />
		RegCloseKey((hKey));<br />
		return Associate_File;<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
<br />
<br />
	// Create The New Registry Key, the default icon key within the identifier key<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, (Identifier+"\\DefaultIcon"), 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	lsize = Icon.GetLength(); // Get Size Of String<br />
	// Set (Default) String Value to the full path name of the icon that will be associated with<br />
	// this file type<br />
<br />
	lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Icon, lsize);<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox("Error Setting String Value!");<br />
		RegCloseKey((hKey));<br />
		return Associate_File;<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
<br />
<br />
<br />
	Identifier += "\\shell";<br />
	// Create The New Registry Key, the "shell" key within the identifier key<br />
<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, Identifier, 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
<br />
<br />
	Identifier += "\\open";<br />
	// Create The New Registry Key, the "open" command key within the shell key<br />
<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, Identifier, 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
<br />
<br />
	Identifier += "\\command";<br />
	// Create The New Registry Key, the "command"  key within the "open" command key<br />
<br />
	lRtn = RegCreateKeyEx(HKEY_CLASSES_ROOT, Identifier, 0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, 0, &hKey, &dwDisp);<br />
<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox(CreateErr);<br />
	}<br />
<br />
	commandline = (Str(CString(char(34)))+Application+Str(CString(char(34)))+" "+Str(CString(char(34)))+"%1"+Str(CString(char(34))));<br />
	lsize = commandline.GetLength(); // Get Size Of String<br />
	// Set (Default) String Value of the "command" key to the command line to be used to open the file<br />
	lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&commandline, lsize);<br />
	// Check For An Error.<br />
	if (lRtn!=ERROR_SUCCESS) {<br />
		AfxMessageBox("Error Setting String Value!");<br />
		RegCloseKey((hKey));<br />
		return Associate_File;<br />
	}<br />
<br />
	// Close The Registry Key.<br />
	RegCloseKey((hKey));<br />
	return Associate_File;<br />
}

this is the button event:

void CForm1::OnCommand1()<br />
{<br />
	// TODO: Add your control notification handler code here<br />
	CComVariant retval;	// - "AutoDim"<br />
        CString exten="ccc_ext";<br />
	CString app_path;<br />
	CString Icon;<br />
	char buffer2[2048];<br />
	HANDLE hProcess = GetCurrentProcess();<br />
    char buffer1[2048];<br />
    DWORD r1 = GetModuleBaseName(hProcess, NULL, buffer1, 2048); <br />
    app_path=GetModuleFileName(NULL, buffer2, 2048)+"\\"+r1;<br />
    Icon=r1+"\\book.ico" ;<br />
    retval = Associate_File(".ccc", app_path,exten,"My own extension",Icon);<br />
   AfxMessageBox(("Associated the file extension .ccc with this application!"));<br />
<br />
}

maybe there is something wrong with the type conversion....right
i think iam using UNICODE

thank u

Ozer Karaagac4-May-08 15:05

4-May-08 15:05

First of all, you aren't already using the functions that I've provided via my first reply in this thread.
You should find them and copy&paste to your source file before the line void CForm1::OnCommand1().

Then, replace that function with the one below.

void CForm1::OnCommand1()
{
  // TODO: Add your control notification handler code here
  CComVariant retval; // - "AutoDim"
  CString exten="ccc_ext";
  CString app_path = GetExeName();
  CString Icon = GetExeFolder() + "\\book.ico";

  retval = Associate_File(".ccc", app_path, exten, "My own extension", Icon);
  AfxMessageBox(("Associated the file extension .ccc with this application!"));
}

I didn't want to post whole Associate_File() function that might mess up the board.
So, please find and replace all commented lines below with uncommented ones in Associate_File() function.

//lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Identifier, lsize);
lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (LPBYTE)(LPCTSTR)Identifier, lsize);

//lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Description, lsize);
lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (LPBYTE)(LPCTSTR)Description, lsize);

//lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&Icon, lsize);
lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (LPBYTE)(LPCTSTR)Icon, lsize);

//commandline = (Str(CString(char(34)))+Application+Str(CString(char(34)))+" "+Str(CString(char(34)))+"%1"+Str(CString(char(34))));
commandline = '\"' + Application + "\" \"%1\"";

//lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (const unsigned char*)&commandline, lsize);
lRtn = RegSetValueExA(hKey, "", 0, REG_SZ, (LPBYTE)(LPCTSTR)commandline, lsize);

It worked well in my system.

BTW, strings are not UNICODE.

lahom4-May-08 15:28

4-May-08 15:28

IT WORKED
Iam reeeeealy thankful to u
i cant really thank u enough
THANK U
Rose | [Rose]

Ozer Karaagac4-May-08 15:36

4-May-08 15:36

You're welcome.

Ozer Karaagac3-May-08 15:47

3-May-08 15:47

lahom wrote:
but with no directory shown in the right pane of regedit

Do you mean directory part of the fully qualified pathname?
like "C:\some.exe" or just "some.exe" for the action command.