C / C++ / MFC

Re: how dialog base application calls dos base application?

9-Jul-02 9:48

how can i call a win32 console application from dialog based application.

let's say, win32 console application takes an argument... like CString or char[ ]

how can i calling console app and passing an argument at the same time from the dialog based application??

S van Leent9-Jul-02 10:12

9-Jul-02 10:12

ShellExecute or ShellExecuteEx

HINSTANCE ShellExecute(
HWND hwnd,
LPCTSTR lpOperation,
LPCTSTR lpFile,
LPCTSTR lpParameters,
LPCTSTR lpDirectory,
INT nShowCmd
);

-- or --

BOOL ShellExecuteEx(
LPSHELLEXECUTEINFO lpExecInfo
);

typedef struct _SHELLEXECUTEINFO{
DWORD cbSize;
ULONG fMask;
HWND hwnd;
LPCTSTR lpVerb;
LPCTSTR lpFile;
LPCTSTR lpParameters;
LPCTSTR lpDirectory;
int nShow;
HINSTANCE hInstApp;

// Optional members
LPVOID lpIDList;
LPCSTR lpClass;
HKEY hkeyClass;
DWORD dwHotKey;
union {
HANDLE hIcon;
HANDLE hMonitor;
};
HANDLE hProcess;
} SHELLEXECUTEINFO, *LPSHELLEXECUTEINFO;

That will do it

Sjoerd van Leent

LPCSTR Dutch = "Double Dutch Smile | :)

Re: how ???

pnpfriend9-Jul-02 10:25

9-Jul-02 10:25

but how?
for my dos based application, which takes 3 arguments,

<br />
int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])<br />

is lpParameters will be the one i should set for my an argument?
what about int argc and the third parameter envp in main?
I dont' really understand because I have never call any applications from one applications.

thanks

pnpfriend9-Jul-02 10:43

9-Jul-02 10:43

This is how I had tried but it is not working! Cry | :((

the following code is in the dialog based application

<br />
void DialogBasedApp::OnTesting()<br />
{<br />
   SHELLEXECUTEINFO lpExecInfo;<br />
   const char* verb = "open";<br />
    lpExecInfo.cbSize  = sizeof(SHELLEXECUTEINFO);<br />
    lpExecInfo.lpFile = "c:\\printExcel\\Debug\\printExcel.exe";<br />
    lpExecInfo.fMask=SEE_MASK_DOENVSUBST|SEE_MASK_NOCLOSEPROCESS ;     <br />
    lpExecInfo.hwnd = NULL;<br />
    lpExecInfo.lpVerb = verb; <br />
    lpExecInfo.lpParameters = "c:\\testing.xls";<br />
    lpExecInfo.lpDirectory = NULL;<br />
    lpExecInfo.nShow = SW_SHOW ; <br />
    lpExecInfo.hInstApp = (HINSTANCE) SE_ERR_DDEFAIL ;   //WINSHELLAPI BOOL WINAPI result; <br />
   ShellExecuteEx(&lpExecInfo);  <br />
   if(lpExecInfo.hProcess != NULL)<br />
   {<br />
      ::WaitForSingleObject(lpExecInfo.hProcess, INFINITE);<br />
      ::CloseHandle(lpExecInfo.hProcess);<br />
   }<br />
   MessageBox("Finished Printing Excel");<br />
}<br />

my dos based application, which is called printExcel.cpp, is right below

<br />
int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])<br />
{ <br />
  AfxMessageBox(argv[0]);<br />
  return 1;<br />
<br />
}<br />

Honestly, i don't even know how to get the argument so no doubt that i have no idea where the program got wrong.
Cry | :((

can you tell me what and where it got wrong and how to fix it, please.

AlexMarbus9-Jul-02 11:08

AlexMarbus

9-Jul-02 11:08

Hi Win,

In this line:
int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])

is actually all you need. The 'argc' is the number of items specified on the commandline.
The array argv are all commandline arguments (including the name of the executable itself, printExcel.exe).

You can retrieve every argument by just using the index in the array:

int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])
{
CString strArgument;
for (int i = 0; i < argc; i++)
strArgument = argv[i];

} // Not compiled, assuming it's correct

--
Alex Marbus
www.marbus.net
But then again, I could be wrong.

Rick York9-Jul-02 19:02

Rick York

9-Jul-02 19:02

I see two odd things here.

First, how can you call AfxMessageBox in a DOS-based app ? If it is really a DOS app then shouldn't you use printf ? You can add a getch() to see what the console window says before it closes.

FWIW, argv[0] will be the name of the executable always, regardless of what args are passed.
argv[1] will be the first passed argument and argc will tell you how many were passed. I think this has been said already but I will reiterate. Here is a loop to print out all passed args except for the exe's name (which is why we start at 1) :

for( int index = 1; index < argc; index += 1 )
fprintf( stdout, "arg %d is '%s'\n", index, argv[index] );

Second is a stylistic issue. You appear to be using Hungarian notation. Well, lp stands for long pointer and you have an instance of the structure so it is not a pointer.

pnpfriend10-Jul-02 2:21

10-Jul-02 2:21

oh yeah.. my dos based application support MFC therefore i can call AfxMessageBox(). you know when you build the project, in first step, you choose win32 console application and in step 2,
you choose hello world support MFC option instead of hello world and empty application.
for second question i can't explain coz i don't know what is Hungarian notation.. ^_^ no clue at all. what is it?

S van Leent9-Jul-02 23:06

9-Jul-02 23:06

Do you need the extra params of ShellExecuteEx? Else, I would just use:

ShellExecute(hInstance, //handle of the executing program*/
"open", // open the program
"C:\\program.exe", //Windows register understands that this will be an executable
"/?", // you don't know how to use program.exe, so typing a question mark
NULL, // You can give up de directory, but is not necessary
SW_SHOWNORMAL // show the damned console window
);

LPCSTR Dutch = "Double Dutch Smile | :)

pnpfriend10-Jul-02 2:53

10-Jul-02 2:53

Thanks.. but I need to pass an argument, which is going to be file name.
the dos based program is basically opening excel files and format it like setting pagesetup like all pages in landscape, scaling 70%, fixing the margins.. and so on.

the dialog based program, smpPrint, have files' names, including excel files. other files could be, .txt, .doc, .tif, etc. i want smpPrint to use the excelPrint, dos based program, will take a file name, and format it. that's what i want to do.
and i have to know when the user closed Microsoft Excel application, so i have to use shellexecutex. shellexecuteex have a parameter that can tell the application is closed .

pnpfriend10-Jul-02 3:57

Safe way of passing WNDPROC through functions

10-Jul-02 3:57

i got it .. thank you all..

S van Leent9-Jul-02 8:51

Re: Safe way of passing WNDPROC through functions

9-Jul-02 8:51

Is experimented with both on the heap and on the stact to pass a __stdcall (WNDPROC) to different functions. But the program (and explorer.exe!) crashes when I do so. Does anyone know how to safely pass a CALLBACK through a function.

eg:

WNDPROC xproc;

LRESULT CALLBACK WindowProc(...)
{
}

void a()
{
b((WNDPROC)WindowProc)
}

void b(WNDPROC wndproc)
{
// Do something like:
xproc = wndproc;
c();
}

void c()
{
SetWindowLong(hWnd, GWL_WNDPROC, (long)xproc);
}

Don't try this!

Thanks in advance,
Sjoerd van Leent

LPCSTR Dutch = "Double Dutch Smile | :)

Joaquín M López Muñoz9-Jul-02 13:06

Joaquín M López Muñoz

9-Jul-02 13:06

There are a couple of issues in your code (maybe they are due to the fact that you have deleted some stuff in your post):

The right signature for WindowProc is

LRESULT CALLBACK WindowProc(HWND hwnd,UINT uMsg,WPARAM wParam,LPARAM lParam)

WindowProc should return a value. Also, typically you will forward most calls to DefWindowProc:

LRESULT CALLBACK WindowProc(HWND hwnd,UINT uMsg,WPARAM wParam,LPARAM lParam)
{
  return DefWindowProc(hwnd,uMsg,wParam,lParam);
}

Apart from this, the code seems just fine.

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo

Re: Safe way of passing WNDPROC through functions

S van Leent9-Jul-02 23:08