C / C++ / MFC

chandu004 wrote:

i dont suggest to use CString in a structure.

chandu004 wrote:

i dont suggest to use CString in a structure.
instead,
use some character array like,
char name[256];

progDes wrote:

2. The class is always safer then pointer.

progDes wrote:

// the data is not pointing to c, it is copied here, so you need to delete c

progDes wrote:

Destructor must call it.

John R. Shaw wrote:

The ‘new’ operator allocates memory and it is up to you to free it;

progDes wrote:

May be you have MFC 3.0?

Mark Salsbery wrote:

You haven't initialized the array that's being copied to the CString.

Class a
{
  void SetPath(CString strPath)
  {
    memset(m_pA->pSzPath, NULL, MAX_PATH);

    int len = min(MAX_PATH, strPath.GetLength());
    strncpy(m_pA->pSzPath, strPath, len);  // Path to folder
    m_pA->bPathUpdated = TRUE;  // a volatile BOOL
  }

  static UINT ThumbnailViewerThread(LPVOID pParam)
  {
    CString strFullPath, strFileName, strFolderPath;
    // blah blah
    
    while(!pData->bStop)
    {
      if (pClientData->bPathUpdated)
      {

        // Find file name by enumerating the folder

        // Replace the following 2 lines, every thing's fine! no need to Empty()

        // strFolderPath = _T("C:\\Images");
        strFolderPath = pClientData->pSzPath; // Folder path

        strFullPath = strFolderPath + "\\" + strFileName;
        // Blah blah

        // Memory leak, if I comment the following
        strFolderPath.Empty();
      }
      else
      {
         sleep(500);
      }
    }    
  }
}

Hamed Mosavi wrote:

void SetPath(CString strPath)
{
memset(m_pA->pSzPath, NULL, MAX_PATH);

int len = min(MAX_PATH, strPath.GetLength());
strncpy(m_pA->pSzPath, strPath, len); // Path to folder
m_pA->bPathUpdated = TRUE; // a volatile BOOL
}

void SetPath(CString strPath)
  {
    memset(m_pA->pSzPath, 0, MAX_PATH);

    int len = min(MAX_PATH<font color="Red"> - 1</font>, strPath.GetLength());
    strncpy(m_pA->pSzPath, strPath, len);  // Path to folder
<font color="Red"><font><font>    m_pA->pSzPath</font></font>[len] = 0;</font>
<font>    m_pA->bPathUpdated = TRUE;  // a volatile BOOL
  }</font>

Mark Salsbery
Microsoft MVP - Visual C++

Mark Salsbery wrote:

(MAX_PATH - 1,

m_pA->pSzPath[len] = 0;

memset(m_pA->pSzPath, 0, MAX_PATH);

Mark Salsbery wrote:

You shouldn't need the empty call

Mark Salsbery wrote:

the destructor isn't getting called.

Is your thread shutdown all the way before the app exits?