C / C++ / MFC

Problem with System Tray Icons

10-Jul-07 13:52

InOut.NET wrote:
It does seem a bit far-fetched that another EXE can change your variable.

In Windows, yes. On other systems it's entirely possible Smile | :)

Mark

Mark Salsbery
Microsoft MVP - Visual C++

This episode brought to you by the number 3

jamestheprogrammer10-Jul-07 8:25

10-Jul-07 8:25

I'm working on a program that requires a system tray icon, as it exists almost entirely in the background. I've been working off of the MSDN documentation, and I can get a tray icon to appear when I run the program. However, the window I gave doesn't receive any messages from the icon - I tried putting a call to Beep() in there just to see if it even got to that point, and nothing happens.

Here is the important parts of my code:

<br />
#define MSG_STATUSICON (WM_USER + 101)<br />
<br />
...<br />
<br />
/* create the structure */<br />
NOTIFYICONDATA request;<br />
request.cbSize = sizeof(NOTIFYICONDATA);<br />
request.hWnd = HiddenWindow;<br />
request.uID = 0;<br />
request.hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_ICONSCREEN_SMALL));<br />
strcpy((char *)&request.szTip, "Screen Monitor");<br />
request.uCallbackMessage = MSG_STATUSICON;<br />
request.uFlags = NIF_ICON | NIF_TIP | NIF_MESSAGE;<br />
<br />
/* add the icon */<br />
BOOL result;<br />
result = Shell_NotifyIcon(NIM_ADD, &request);<br />
if (result != TRUE) {<br />
	/* failed */<br />
	return -1;<br />
}<br />
<br />
...<br />
<br />
/* in the callback for HiddenWindow */<br />
case WM_STATUSICON:<br />
	/* something happened with the status icon */<br />
	switch (lParam) {<br />
	case WM_RBUTTONUP:<br />
		/* display the context menu */<br />
		TaskbarIcon::ShowPopupMenu();<br />
		break;<br />
	case WM_CONTEXTMENU:<br />
		/* display the context menu */<br />
		TaskbarIcon::ShowPopupMenu();<br />
		break;<br />
	default:<br />
		break;<br />
	}<br />
	return 0;<br />
	break;<br />

So, yeah. I've told it that I'm using a message ID equal to WM_USER + 101, and I'm checking for that in the callback, but I'm not getting any messages when I right-click the icon. Any ideas?

Hamid_RT10-Jul-07 8:55

Hamid_RT

10-Jul-07 8:55

See system tray Icons - Minimize Your Application to the Systray[^] does any help?

WhiteSky

jamestheprogrammer10-Jul-07 9:00

10-Jul-07 9:00

No... I'm not using MFC, just the Windows API. Thanks, though.

Perspx10-Jul-07 9:30

Perspx

10-Jul-07 9:30

I'm not sure if it will make a difference Sigh | :sigh:

but you might need to set the flags BEFORE you set the other data..? (as in put it after the uID parameter). I've got some code which I have used for this sort of thing and it's pretty much identical to yours' apart from that..

If this doesnt work, try getting rid of the icon and tooltip for now and see if the icon actually processes and sends any messages..

Hope this helps!
--PerspX

"Nowadays, security guys break the Mac every single day. Every single day, they come out with a total exploit, your machine can be taken over totally. I dare anybody to do that once a month on the Windows machine." - Bill Gates

jamestheprogrammer10-Jul-07 10:11

10-Jul-07 10:11

No, that doesn't help - I'm still not receiving any messages, even when I take away the icon and tip. Thanks for the advice, though... it's unusual how code that's so similar isn't working. I'm updating my Platform SDK, so maybe that will help... I wish I had something better than dialup Sigh | :sigh:

Perspx10-Jul-07 11:05

Perspx

10-Jul-07 11:05

... yes it is odd.. are you using Visual Studio?

--PerspX

Mark Salsbery10-Jul-07 10:12

10-Jul-07 10:12

The only thing I see missing is

request.uID = IDI_ICONSCREEN_SMALL; //instead of 0

Also make sure you're looking for MSG_STATUSICON in your message loop, and when you process that
message, the MSG.lParam is what you should switch() on (as shown in your code). You may already
be doing that, but you didn't show it in your code above.

Mark

Mark Salsbery
Microsoft MVP - Visual C++

This episode brought to you by the letter Z

JudyL_MD10-Jul-07 10:26

JudyL_MD

10-Jul-07 10:26

jamestheprogrammer wrote:
#define MSG_STATUSICON (WM_USER + 101)

My first suggestion is to change this to WM_APP instead of WM_USER. WM_USER is used internally by various Win32 controls and I'm seen some weird bugs when those controls are used on the same window as one that processes your own WM_USER message. This probably isn't your problem, but I hate seeing WM_USER used when WM_APP exists and is guaranteed to be unique in your app.

Looking in some code of mine where I have a service displaying a tray icon, I also set the version number in the notify request structure

Here's my entire "create the tray icon" routine that is called from within my interactive service.

if (CreateEx (0, AfxRegisterWndClass (0), "", WS_POPUP, 0, 0, 10, 10, NULL, 0) == 0)
{
    // handle error
    return false;
}

m_notifyIconData.cbSize           = sizeof (NOTIFYICONDATA);
m_notifyIconData.hWnd             = m_hWnd;
m_notifyIconData.uID              = 1;
m_notifyIconData.uFlags           = NIF_ICON | NIF_MESSAGE | NIF_TIP;
m_notifyIconData.uCallbackMessage = WM_APP;
m_notifyIconData.hIcon            = ::LoadIcon (AfxGetResourceHandle (),
                                                MAKEINTRESOURCE (IDI_ICONTRAY));
m_notifyIconData.uVersion         = NOTIFYICON_VERSION;
strcpy_s (m_notifyIconData.szTip, 64, "xxx Service");

if (Shell_NotifyIcon (NIM_ADD, &m_notifyIconData) == FALSE)
{
    // handle error
    return false;
}

m_notifyIconData is a variable of type NOTIFYICONDATA that I keep around so that the service can destroy the icon later if it wants. m_hWnd is the handle created by the CreateEx call.

Hope this helps

Judy

jamestheprogrammer10-Jul-07 10:47

10-Jul-07 10:47

Yeah, I'm thinking that the problem has something to do with the uVersion variable... I'm actually stuck with VC6 for the time being, and the Platform SDK I have is so old that the uVersion variable doesn't even exist. I'm downloading the February 2003 Platform SDK, so hopefully that will help.

Thanks.

Mark Salsbery10-Jul-07 11:58

10-Jul-07 11:58

jamestheprogrammer wrote:
I'm thinking that the problem has something to do with the uVersion variable

That's only used when sending a NIM_SETVERSION (via Shell_NotifyIcon), not for NIM_ADD.

Mark

Mark Salsbery
Microsoft MVP - Visual C++

This episode brought to you by the number 3

Mark Salsbery10-Jul-07 12:02

10-Jul-07 12:02

You're not receiving any messages from the icon, right?

In your code you show

/* in the callback for HiddenWindow */
...

What is the callback? You should be looking for the MSG_STATUSICON message in the windowproc for
the HWND passed to Shell_NotifyIcon().

LRESULT CALLBACK MyWindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
{
   if (MSG_STATUSICON == uMsg)
   {
      UINT IconID = (UINT)wParam;
 
      switch((UINT)lParam)
      {
         case WM_RBUTTONUP:
         ...
         case WM_CONTEXTMENU:
         ...
         case WM_LBUTTONDBLCLK:
         ...
         case WM_LBUTTONDOWN:
         ...
         case WM_RBUTTONDOWN:
         ...
         default:
         ...
      }
   }
...
}

Mark

Mark Salsbery
Microsoft MVP - Visual C++

This episode brought to you by the number 3

jamestheprogrammer10-Jul-07 12:20

10-Jul-07 12:20

Yeah, I think so (unless there's something I'm missing). I've created a Window class called SMStatusHelper, with lpfnWndProc set to the callback in the code I first posted.

<br />
/* create the window class */<br />
WNDCLASSEX wndClass;<br />
wndClass.cbSize = sizeof(WNDCLASSEX);							wndClass.style = CS_DBLCLKS;								<br />
wndClass.lpfnWndProc = WndProc;								<br />
wndClass.cbClsExtra = 0;								<br />
wndClass.cbWndExtra = 0;								<br />
wndClass.hInstance = hInstance;								<br />
wndClass.hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_ICONSCREEN));<br />
wndClass.hCursor = LoadCursor(NULL, IDC_ARROW);<br />
wndClass.hbrBackground = (HBRUSH) GetStockObject(WHITE_BRUSH);<br />
wndClass.lpszMenuName = NULL;<br />
wndClass.lpszClassName = "SMStatusHelper";<br />
wndClass.hIconSm = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_ICONSCREEN_SMALL));<br />
RegisterClassEx(&wndClass);<br />

Then I create a new window using the SMStatusHelper class, WS_EX_TOOLWINDOW extended style, and WS_POPUP|WS_VISIBLE for the regular style, using the CreateWindowEx method. I take the return value of that and set it to a global variable called HiddenWindow, which is the hWnd value of the NOTIFYICONDATA structure I pass to Shell_NotifyIcon. So I'm pretty sure that's the right callback...

Thanks.

Mark Salsbery10-Jul-07 12:39

10-Jul-07 12:39

Sounds good.

I'm just wondering about the "callback" you mentioned since you didn't post complete code.
You showed case statements but not the switch() and the switch argument Smile | :)

Now that I see your window class, the MyWindowProc (or whatever I called it) example in the code
I posted (last post) would go in your "WndProc".

Are you checking for the notification message in a similar way?

Mark

Mark Salsbery
Microsoft MVP - Visual C++

This episode brought to you by the number 3

jamestheprogrammer10-Jul-07 13:07