C / C++ / MFC

13-Jun-02 8:38

Hi all,

So I have a list< double* >, which contains arrays which were created with something like new double[4]. When I'm done with the list I need to free all of the elements. At first I tried this:

list< double* > ::iterator it = my_list.begin();
while( it != my_list.end() )
   delete [](*it);

but that didn't work, with MFC saying the pointer was still valid, I think because the list still contained references to the element.

So I figured the best way would be to walk thru the list, removing, then deleting, elements as I go. But I'm a little unsure about the behaviour of iterators in this situation. For example after the following code:

list< double* > ::iterator my_it = my_list.begin();
my_list.pop_front();

Would my_it stil be valid? Where would it be pointing to?

I need to figure out the quickest way to safely []delete all elements in the list.

Any pointers?

TIA,

Pete

moredip13-Jun-02 9:06

13-Jun-02 9:06

Doh!

this code:
while( it != my_list.end() )
delete [](*it);

should have been:
while( it != my_list.end() )
delete [](*it++);

I guess I'm too used to good old for loops Smile | :)

well, I can now just run thru the list, deleting all the elements, then just delete the list.

This is probably the quickest way.... right?

Pete

Oz Ben Eliezer13-Jun-02 9:09

Oz Ben Eliezer

13-Jun-02 9:09

Try the following:

list< double* >::iterator i;
while ((i = my_list.begin()) != my_list.end())
{
double *p = *i;
my_list.pop_front();
delete [] p;
}

moredip13-Jun-02 9:18

13-Jun-02 9:18

That looks like it would work, but I'm not sure if it's the quickest way to do it, calling begin() every time...

jbarton13-Jun-02 10:20

jbarton

13-Jun-02 10:20

I like to use something like:

while ( ! my_list.empty() )
{
delete [] my_list.front();
my_list.pop_front();
}

Best regards,
John

moredip13-Jun-02 10:19

13-Jun-02 10:19

Yeah, that looks nice

Do you think it'd be quicker this way...

for( i = my_list.size(); i >= 0; i-- )
{
delete [] my_list.front();
my_list.pop_front();
}

Im guessing the lack of a function call would speed it up, what do you think?

Pete

jbarton13-Jun-02 10:34

jbarton

13-Jun-02 10:34

The speed difference would be insignificant. The members of list are generally inlined, so don't add any function call overhead.

John

moredip13-Jun-02 10:40

13-Jun-02 10:40

>>The speed difference would be insignificant.

Whereas the time wasted while I try to understand my 'efficient' function in two weeks would be significant... I think I'll go with your version Wink | ;)

Thanks John

jbarton13-Jun-02 10:56

jbarton

13-Jun-02 10:56

My original reply was written assuming that you can't change the type of the list.

If you can change the type of the list, I would do that instead.

I would use:

list< vector< double > > my_list.

Then, when you erase any elements inside the list, the vector will automatically clean up after itself.

John

moredip13-Jun-02 10:59

13-Jun-02 10:59

I _could_ change the type, but it would be more [bureaucratic] effort than it's worth.

Thanks anyway,

Pete

Christian Graus13-Jun-02 12:36

Christian Graus

13-Jun-02 12:36

For future reference though, a vector of doubles in a list would have been a much nicer solution. I usually delete pointers if I need to carry them ( because of polymorphism ) using a for_each and a function object that calls delete on everything in my container.

Christian

I am completely intolerant of stupidity. Stupidity is, of course, anything that doesn't conform to my way of thinking. - Jamie Hale - 29/05/2002

Half the reason people switch away from VB is to find out what actually goes on.. and then like me they find out that they weren't quite as good as they thought - they've been nannied. - Alex, 13 June 2002

Rama Krishna Vavilala13-Jun-02 12:49

Rama Krishna Vavilala

13-Jun-02 12:49

Even I don't see much sense in storing double* instead of double in a vector. It will also cause Heap fragmentation and your code may cause more page faults as each double may be scattered all over the memory. Unless you have very important reason against it, change it to double.

moredip13-Jun-02 12:54

Midi Song Length using MCI (non-MFC)

13-Jun-02 12:54

Well, it seems that it would be worth the effort, based on all of your posts. I shall get to it...

Thanks for the advice everyone Smile | :)

13-Jun-02 8:08

Hello. This problem has been plaguing me and I can't seem to find an answer. I am programming a Win32 App using the Win32 API. I am using MCI to play a midi and I need to figure out how long the song is. Does anyone know how to do this or can anyone direct me to a resource that would show me? I've tried many things but I just can't seem to figure it out. Thanks in advance.

Re: Midi Song Length using MCI (non-MFC)

redeemer13-Jun-02 8:53

redeemer

13-Jun-02 8:53

Have you tried searching on google for information on the MIDI format?

Re: Midi Song Length using MCI (non-MFC)

13-Jun-02 11:17

Yes, and I've read it too.

Re: Midi Song Length using MCI (non-MFC)

Ed Gadziemski13-Jun-02 12:26

Ed Gadziemski

13-Jun-02 12:26

From http://msdn.microsoft.com/library/default.asp?url=/library/en-us/multimed/mmcmdstr_6tyl.asp

To send the status command, call the mciSendString function.

status length track number

Returns the length of the track, in time or frames, specified by number.

For PPQN format files, the length is returned in song pointer units. For SMPTE format files, it is returned as hh:mm:ss:ff, where hh is hours, mm is minutes, ss is seconds, and ff is frames.

image portion

SilentWarrior13-Jun-02 7:22

SilentWarrior

13-Jun-02 7:22

is there a way i could get a specifc portion from an image in visual c++6.
i meant to say if i had a image and i want to make another file of that image of its center portion only .

looking forward from all the gurus of code

C^hris L^osinger13-Jun-02 7:55

C^hris L^osinger

13-Jun-02 7:55

i'm sure the various image classes on this site can help.

or, as always, i know where you can find a commercial solution...

-c

Cheap Oil. It's worth it!

Image Processing?

Jeremy Falcon13-Jun-02 8:43

Jeremy Falcon

13-Jun-02 8:43

C^hris L^osinger wrote:
or, as always, i know where you can find a commercial solution...

One can only imagine! Roll eyes | :rolleyes:

Jeremy L. Falcon<nobr>
Homepage : Sonork = 100.16311

"It was a blind man who taught me how to see." - Aerosmith

C^hris L^osinger13-Jun-02 8:51

C^hris L^osinger

13-Jun-02 8:51

i always mention the stuff here first! Smile | :)

-c

Cheap Oil. It's worth it!

Image Processing?