|
class TreeNode
<br />
package guiID3;<br />
<br />
import java.util.ArrayList;<br />
<br />
public class TreeNode {<br />
<br />
private ArrayList mChilds = new ArrayList();<br />
private Attribute mAttribute;<br />
<br />
public TreeNode(Attribute attribute){<br />
if (attribute.getIntTypesArray() != null)<br />
{<br />
mChilds = new ArrayList(attribute.getIntTypesArray().length);<br />
for (int i = 0; i < attribute.getIntTypesArray().length; i++){<br />
mChilds.add(null);<br />
<br />
}<br />
}<br />
else<br />
{<br />
mChilds = new ArrayList(1);<br />
mChilds.add(null);<br />
}<br />
mAttribute = attribute;<br />
}<br />
<br />
public void AddTreeNode(TreeNode treeNode, int ValueName)<br />
{<br />
int index = mAttribute.indexOf(ValueName);<br />
mChilds.add(index,treeNode);<br />
}<br />
<br />
<br />
<br />
public TreeNode getChild(int index)<br />
{<br />
return (TreeNode)mChilds.get(index);<br />
}<br />
<br />
public Attribute getMAttribute()<br />
{<br />
return mAttribute;<br />
}<br />
<br />
public TreeNode getChildByBranchName(String branchName)<br />
{<br />
int index = mAttribute.indexOf(branchName);<br />
return (TreeNode)mChilds.get(index);<br />
}<br />
<br />
public int getmChilds() <br />
{<br />
return mChilds.size();<br />
}<br />
<br />
<br />
<br />
<br />
}<br />
<br />
best regards
|
|
|
|
|
This is an English language site, not Portuguese. Worthless.
|
|
|
|
|
alslam alikum;
good work; but when i want convert the code to java to make comparsion with other algorithms
i found that you just deal with two class problem you have make one method instead of two methods
{allSamplesPostive;;allSamplenegative}
cal this method checkSameClass the input to this method" Samples and targetClass";
and try to read from file it make your program good;
i hope if i missing something you declare it;
best regards;
|
|
|
|
|
I have changed your code into VB language, cause my task is in VB. I think there's no big difference. This is my training data.
'===================================================================================
'Exam Result Sample
'===================================================================================
col = result.Columns.Add("NFails")
col.DataType = GetType(String)
col = result.Columns.Add("NMarg")
col.DataType = GetType(String)
col = result.Columns.Add("Att")
col.DataType = GetType(String)
col = result.Columns.Add("Ext")
col.DataType = GetType(String)
col = result.Columns.Add("Ant")
col.DataType = GetType(String)
col = result.Columns.Add("Result")
col.DataType = GetType(String)
result.Rows.Add(New Object() {"0", "0", "good", "no", "P", "P"})
result.Rows.Add(New Object() {"0", "0", "poor", "yes", "F", "P"})
result.Rows.Add(New Object() {"0", "0", "good", "yes", "F", "P"})
result.Rows.Add(New Object() {"3", "0", "good", "no", "F", "F"})
result.Rows.Add(New Object() {"3", "1", "poor", "no", "F", "F"})
result.Rows.Add(New Object() {"3", "0", "good", "no", "P", "F"})
result.Rows.Add(New Object() {"3", "2", "good", "yes", "P", "R"})
result.Rows.Add(New Object() {"2", "1", "poor", "no", "F", "F"})
result.Rows.Add(New Object() {"2", "2", "good", "yes", "P", "R"})
result.Rows.Add(New Object() {"1", "0", "poor", "yes", "P", "R"})
result.Rows.Add(New Object() {"1", "1", "good", "yes", "F", "R"})
result.Rows.Add(New Object() {"1", "1", "good", "no", "F", "R"})
result.Rows.Add(New Object() {"1", "0", "poor", "no", "F", "F"})
result.Rows.Add(New Object() {"3", "2", "good", "no", "P", "F"})
result.Rows.Add(New Object() {"2", "2", "good", "no", "F", "R"})
result.Rows.Add(New Object() {"2", "1", "good", "yes", "P", "R"})
result.Rows.Add(New Object() {"2", "0", "poor", "no", "F", "F"})
'===================================================================================
in function InternalMountTree, there are some lines :
If aSample.Rows.Count = 0 Then
Return New TreeNode(New Attribute(getMostCommonValue(samples, targetAttr)))
Else
Dim dc3 As DecisionTreeID3 = New DecisionTreeID3()
Dim ChildNode As TreeNode = dc3.mountTree(aSample, targetAttr, _
DirectCast(aAttributes.ToArray(GetType(Attribute)), Attribute()))
root.addTreeNode(ChildNode, value)
End If
there's no need to return the treenode, just add a new treenode so it doesn't break the recursive way. The codes become like this :
If aSample.Rows.Count = 0 Then
Dim ChildNode As New TreeNode(New Attribute(getMostCommonValue(samples, targetAttr)))
root.addTreeNode(ChildNode, value)
'Return New TreeNode(New Attribute(getMostCommonValue(samples, targetAttr)))
Else
Dim dc3 As DecisionTreeID3 = New DecisionTreeID3()
Dim ChildNode As TreeNode = dc3.mountTree(aSample, targetAttr, _
DirectCast(aAttributes.ToArray(GetType(Attribute)), Attribute()))
root.addTreeNode(ChildNode, value)
End If
Please correct me if i'm wrong because i've also changed some procedures and functions to match with my task. And you were so great about making this algorithm become so simple... Thank you so much!
Best Regards,
dee
|
|
|
|
|
I'm interested in DataMining,i'm research and implement it with c#, and if u too,u can help me a association rule, thank a lot,
happy and lucky to u! and any body like it
Huynh Ly Thanh Nhan
|
|
|
|
|
if u not use function "getDistinctValues" , will have error in the second call function "mountTree".
---
and
ArrayList aAttributes = new ArrayList(attributes.Length - 1);
for(int i = 0; i < attributes.Length; i++)
{
if (attributes[i].AttributeName != bestAttribute.AttributeName)
aAttributes.Add(attributes[i]);
}
------
it have a problem if data example is a little,
----> can edit :
Attribute[] aAttributes = new Attribute [attributes.Length-1];
int j = 0;
for (int i = 0; i <attributes.length; i++)<br="" mode="hold"> {
if (attributes[i].AttributeName != bestAttribute.AttributeName)
{
Attribute t=new Attribute ( attributes[i].AttributeName,(string[])getDistinctValues(childSample, attributes[i].AttributeName).ToArray(typeof(string)));
aAttributes[j] = t;
j++;
}
}
--> ok?
Huynh Ly Thanh Nhan
modified on Wednesday, December 12, 2007 3:55:54 AM
|
|
|
|
|
alslam alikum;
find duplicate item --- it is true but why i have use function "getDistinctValues"
all i need save attributes that have been used
so i used another arrayList called it usedAttributes; which hold the attributes used during the loops
so frist
ArrayList usedAttributes=new ArrayList();
then
usedAttributes.add(bestAttribute.getAttributeName());
finally
ArrayList aAttributes = new ArrayList(attributes.length - 1);
for(int i = 0; i < attributes.length-1; i++)
{
if (usedAttributes.contains(attributes[i].getAttributeName())!=true)
aAttributes.add(attributes[i]);
}
}
|
|
|
|
|
Hi coders
Had to spend more than 2 hours for the translation from Portugese to English via translate.google.com
Hope the code now makes some sense for us English Speaking people
Get the translated Code from http://kirankonathala.com/AI/ID3DecisionTree.zip
Watch this space cos' Im gonna make a Java version of this Algorithm - our evaluator demands JAVA
I need to work out an extension of this progam wherein once we build a decision tree,it should parse Test Data to predict the results.
Inducing a Decision Tree - Supplying training data and expecting an output for Test Data (makes sense,right?)
Q)How do we parse the test data?
A)Once we form an optimal Decision tree from the Training Data,we need to parse the Test Data by froming predicates (p and q and .....).
Will be posting the Test Data part very soon!!
Kiran K
|
|
|
|
|
|
hi,can u sent me a translated code to me? i can`s down load that form the link http://kirankonathala.com/AI/ID3DecisionTree.zip.
my email is hiwinson@gmail.com, thanks very much.
|
|
|
|
|
Please share your extended program Kiran.
|
|
|
|
|
please i want english version
my mail m_wesemy@YAHOO.COM
|
|
|
|
|
please send me the translated version with comments to jibran.javed@gmail.com
i tried to access the link but not succeed
best wishes
thankful
javed
|
|
|
|
|
Cannot access the page either. Someone upload the code somewhere else?
|
|
|
|
|
This is a trick to get you to go to his spam site!
DO NOT FOLLOW LINK!
|
|
|
|
|
Hi all!!
The comments are in Portugese,will post the translated comments if time permits
amostragem - Sampling!!
http://translate.google.com
Kiran K
I need to modify the code to suit my problem - will post here if successful!
http://kirankonathala.com
|
|
|
|
|
SPAM! DO NOT FOLLOW LINK!
HAS NOTHING TO DO WITH C# OR ID3 ALOGRITHM!
|
|
|
|
|
Hey,add Console.Redline() in main() cos' it disappears before I even look at it
|
|
|
|
|
using System;
using System.Collections;
using System.Data;
//AUTHOR: Roosevelt dos Santos Júnior
namespace ExemploID3
{
///
/// Classe que representa um atributo utilizado na
......
......
classe de decisão
///
class ID3Sample
{
public static void printNode(TreeNode root, string tabs)
{
Console.WriteLine(tabs + '|' + root.attribute + '|');
if (root.attribute.values != null)
{
for (int i = 0; i < root.attribute.values.Length; i++)
{
Console.WriteLine(tabs + "\t" + "<" + root.attribute.values[i] + ">");
TreeNode childNode = root.getChildByBranchName(root.attribute.values[i]);
printNode(childNode, "\t" + tabs);
}
}
}
static DataTable getDataTable()
{
DataTable result = new DataTable("samples");
DataColumn column = result.Columns.Add("TF");
column.DataType = typeof(string);
column = result.Columns.Add("IDF");
column.DataType = typeof(string);
column = result.Columns.Add("POS");
column.DataType = typeof(string);
column = result.Columns.Add("result");
column.DataType = typeof(bool);
result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
result.Rows.Add(new object[] {"TF9", "IDF0", "A", false});
// result.Rows.Add(new object[] {"TF9", "IDF0", "A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "N N", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "N N N", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "N A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "N N", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "N N", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "N N A", false});
result.Rows.Add(new object[] {"TF9", "IDF0", "N N", true});
// result.Rows.Add(new object[] {"TF0", "IDF0", "N N N", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
result.Rows.Add(new object[] {"TF0", "IDF0", "A A", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "N N N", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "N N", false});
// result.Rows.Add(new object[] {"TF0", "IDF0", "A", false});
return result;
Console.ReadLine();
}
///
/// The main entry point for the application.
///
///
[STAThread]
static void Main(string[] args)
{
Attribute TF = new Attribute("TF", new string[] {"TF0", "TF9"});
Attribute IDF = new Attribute("IDF", new string[] {"IDF0"});
Attribute POS = new Attribute("POS", new string[] {"A", "N N", "N A", "N N N", "A A", "N N A"});
Attribute[] attributes = new Attribute[] {TF, IDF, POS};
DataTable samples = getDataTable();
DecisionTreeID3 id3 = new DecisionTreeID3();
TreeNode root = id3.mountTree(samples, "result", attributes);
printNode(root, "");
}
}
}
|
|
|
|
|
when two attributes are same gain then we chose one and there are have some case positives = negatives = 0 --> gain = -1.#IND000000000 -> our decision tree error
|
|
|
|
|
English please
I can't read comments !
Tx by P.P.
|
|
|
|
|
Hi,
Can't you read comments in source code?
|
|
|
|
|
No, they are in Portuguese. As much as some may not like it English is the international language for programmers so writing comments in anything but English ON AN ENGLISH LANGUAGE SITE is pretty silly.
In fact most technical words are in English. Just ask anyone in Brazil to tell you the name of the software/hardware that protects your network from the bad people on the Inter-web and they will tell you, "Um firewall." But if you ask them if they have a good "uma parede de fogo" or "um incêndio parede" they will look at you strangely.
|
|
|
|
|
I can't read comment you have Eng ver?
if you have it please give me one.
|
|
|
|
|
You can go to one of numerous translators on the Internet and try to translate comments by yourself. It is not too hard as it seems to.
|
|
|
|
|