|
I'm having a problem with a class I wrote- the destructor isn't being called for some reason and I'm getting a rather large memory leak as a result. I verified that the destructor was not being called through the use of breakpoints. Any help would be appreciated.
Here is the class defenition:
class CCharLinkedList
{
public:
CCharLinkedList();
~CCharLinkedList();
void AddNodeToHead(char DataToAdd[]);
void AddNodeToTail(char DataToAdd[]);
bool DeleteFromHead();
bool DeleteFromTail();
bool CopyFromHead(char DataToCopy[]);
bool CopyFromTail(char DataToCopy[]);
void PrintHeadToTail();
void PrintTailToHead();
protected:
private:
void DeleteList();
CharLinkedListNodeType* HeadPtr;
CharLinkedListNodeType* TailPtr;
};
The destructor implementation:
CCharLinkedList::~CCharLinkedList()
{
DeleteList();
HeadPtr = NULL;
TailPtr = NULL;
}
DeleteList():
void CCharLinkedList::DeleteList()
{
CharLinkedListNodeType* IterationPtr = HeadPtr;
CharLinkedListNodeType* DeletePtr = NULL;
while(IterationPtr != NULL)
{
DeletePtr = IterationPtr;
IterationPtr = IterationPtr->ForwardPtr;
delete DeletePtr;
}
}
The class is declared in the free store in another class header file. The other class has been working fine for a long time. So far I have been able to use the linked list to add nodes, but when it is time to call the destructor upon exiting and delete all the nodes, nothing happens.
|
|
|
|
|
You've shown the code for the class but it's irrelevent to the problem.
What's important is the creation and destruction of the CCharLinkedList object(s).
Are they created/destroyed with new/delete?
Are they member variables in another class? If so, when does the object of THAT class get deleted
or go out of scope?
etc...
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
|
I only have one CCharLinkedList object. It is allocated on the free store (not new/delete), here:
class CRatiosWin : public CFrameWnd
{
public:
CRatiosWin();
~CRatiosWin();
CRatiosLogic RatiosLogic;
bool GetNewFilePath(CString & Path);
void PrintResults(string results);
bool ReturnValidFilePathSet();
void ResetSearchDialogFlag();
void SetDatabaseFilePathStatus(bool FilePathWasSet);
void SetTimeParameterStatus(bool NewTimeParametersWereSet);
protected:
private:
CRatiosNewSearchDialog NewSearchDialog;
CRatiosSearchTimeParameters TimeParametersDialog;
CCharLinkedList TestLinkedList; :(
CEdit ResultsBox;
BOOL NewSearchDialogIsVisible;
bool ValidFilePathSet;
bool TimeParametersWereSet;
afx_msg void OnClose();
afx_msg void OnOpenFile();
afx_msg void OnNewSearch();
afx_msg void OnOpenSearch();
afx_msg void OnAbout();
afx_msg void OnTestList();
DECLARE_MESSAGE_MAP()
};
I loaded some text into the list by calling this at runtime:
afx_msg void CRatiosWin::OnTestList()
{
fstream ListFileStream;
char chLine[MAXNUMCHARS_LINKLISTNODE];
string strLine = "";
ListFileStream.open("list_test.txt");
while(ListFileStream.eof() == false)
{
getline(ListFileStream, strLine);
ASSERT(strLine.length() < MAXNUMCHARS_LINKLISTNODE);
strcpy(chLine, strLine.c_str());
TestLinkedList.AddNodeToTail(chLine);
}
MessageBox("Sent to file.", "Boink", MB_OK);
ListFileStream.close();
}
All of the above worked fine. But I set breakpoints in the destructor in the previous post and none of them were reached, plus I have a big memory leak.
|
|
|
|
|
Cool thanks. In that case you need to look at when the CRatiosWin object is destroyed.
It is then that the CCharLinkedList member object will be destroyed.
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
|
Can I assume that CRatiosWin is not getting deleted in this segment of code?
class CPRatiosApp : public CWinApp
{
public:
BOOL InitInstance()
{
_CrtSetDbgFlag( _CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF);
m_pMainWnd = new CRatiosWin;
m_pMainWnd->ShowWindow(m_nCmdShow);
m_pMainWnd->UpdateWindow();
m_pMainWnd->SetWindowText("Ratios v0.1b");
m_pMainWnd->MoveWindow(0,0,800,600);
return TRUE;
}
} CRatiosApp;
|
|
|
|
|
CoffeeAddict19 wrote: Can I assume that CRatiosWin is not getting deleted in this segment of code?
Yes...correct.
I can't find where m_pMainWnd is destroyed in the MFC source...When I find it I'll post. 
Try adding this override to your CPRatiosApp class:
virtual int ExitInstance()
{
if (m_pMainWnd)
{
m_pMainWnd->DestroyWindow();
m_pMainWnd = 0;
}
return CWinApp::ExitInstance();
}
Your destructor should be called when the m_pMainWnd->DestroyWindow(); is executed.
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
|
Ok....after reviewing MFC source -
Your destructors should get called when you close the main window (since frame windows are self-
deleting). I found no place where the app classes destroy the main window explicitly.
The ExitInstance() code I posted won't help. You'll need to close the main window before a
breakpoint in your destuctor will be called 
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
|
When I learned to program we had to write stuff like this – why are you? You should be using the ‘list’ template.
Some of the modern MS languages allow you to ignore the fact that if you use ‘new’ you need to supply a ‘delete’, may be that is the problem. Any thing you allocate you need to deallocate – even in C++.
INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
|
|
|
|
|
Hello you wise people out there,
how can I log off a user on Windows NT, XP, Vista platform from a Windows Service?
Do I have to impersonate the user and send a certain message or can I use ExitWindowsEx(0,0)? Which privileges does the Service need?
Thanks for your help
I'm just a beginner longing for wisdom
|
|
|
|
|
Hi
I have 3 dailog boxes(Dlg1,Dlg2,Dlg3) which create a fourth dialog box which is called ChildDlg.How can I understand which one is the parent of the ChildDlg? I tried that;
ChildDlg::Something()
{
Dlg1 *dlg = (Dlg1*)GetParent();
if(Dlg1 is not the parent)
{
delete dlg;
Dlg2 *dlg = (Dlg2*)GetParent();
if(Dlg2 is not the parent)
{
Delete dlg;
Dlg3 *dlg = (Dlg3*)GetParent();
}
}
(After that part of the code I am using dlg as the object of the parent.)
)
I have many methods like this method which I should know which one is the parent.Where is the mistake in this method.It doesn't work.I know I asked a question similar to this one but still I have problems about that subject.
Thanks
|
|
|
|
|
Exactly what is it that you are trying to do?
Why is common sense not common?
Never argue with an idiot. They will drag you down to their level where they are an expert.
Sometimes it takes a lot of work to be lazy
|
|
|
|
|
why don't you just pass the parent pointer to the ChildDlg when it's created and check the GetParent against that pointer ?
|
|
|
|
|
Maximilien wrote: why don't you just pass the parent pointer to the ChildDlg when it's created and check the GetParent against that pointer ?
I think that, stated the way above, you're check will always return true.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
You can make the three candidate parents to implement the same interface (pure abstract class) that defines a method returning some type info. For instance, Suppose you define IMyTypeInfo:
class IMyTypeInfo
{
public:
virtual int getType()=0;
}
then you can do something similar to:
class Dlg1 : public CDialog, public IMyTypeInfo
{
public:
virtual int getType(){return 1;}
...
}
class Dlg2 : public CDialog, public IMyTypeInfo
{
public:
virtual int getType(){return 2;}
...
}
class Dlg3 : public CDialog, public IMyTypeInfo
{
public:
virtual int getType(){return 3;}
...
}
finally, you child dialog, can safely do the following cast:
int iType = ((IMyTypeInfo *)GetParent())->getType();
and retrieve parent's type.
(you can also go through RTTI...)
hope that helps.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
Be careful if these dialogs are modeless. What GetParent() and GetWindow() report differs depending on the dialog style (i.e. popup, overlapped, or child)
Be aware of the differences of parent and owner depending on these styles.
Window Owners and Parents
[^]
|
|
|
|
|
This example is MFC
In each parent, create the child like:
CChildDlg childDlg (this)
This will pass the parent CWnd to the child and the standard MFC implementation will store the CWnd pointer.
In the child, when something occurs that has to be sent back to the parent, simply do:
GetParent ()->PostMessage (build whatever message and parameters you need)
If the child really cares about _which_ parent called him, modify the child's constructor to include another parameter and pass in an indicator that the child can store in its member variables that shows who created the child.
CChildDlg childDlg (this, flag_value)
Now, in the child, when you want to call into a specific parent, cast the parent CWnd pointer to the appropriate parent class based on the flag
if (flag_value == parent_1)<br />
{<br />
Dlg1 *pDlg = (Dlg1 *) GetParent ();<br />
}<br />
else if (flag_value == parent_2)<br />
{<br />
Dlg2 *pDlg = (Dlg2 *) GetParent ();<br />
}<br />
else<br />
You need to be careful when you call back into another window class that you don't do things that may cause your window to redraw. In general, it is much better to post a windows message than it is to call directly when communicating between windows.
Judy
|
|
|
|
|
Thanks to all who spent time for answers.
|
|
|
|
|
i am not able to get hard disk serial number in vista. i want code that can be used in vc++ 6.0 and should be able to run in vista.
i don't want to use wmi or .net framwork and without administrator login as my software can run form win95,98,me to vista. my software is not useing any api of .net.
viral joshi
|
|
|
|
|
viral_umang@hotmail.com wrote: i don't want to use wmi
Unfortunately, WMI is the easiest way to go when it comes to getting hardware information. There is a WMI redistributable for Win95, Win98, and WinNT that you can package up in an msi along with your app. The read-only side of WMI works great when logged on as a regular user (non-admin). I program with it in Visual C++ 6.0 (Platform SDK is required on your Visual C++ 6.0 machine) and it works fine on Vista.
Now, I agree with you on the "no dotNet stuff" and WMI is quite complex since it is DCOM based but it hasn't weighed me down too much since the queries are always on the same box. DCOM seems heavy only when you try to do stuff remotely. There are just too many variables involved with trying to write your own code for every possible piece of hardware out there that may be underneath any Win95-Vista installation for even the most conservative programmer.
If you've never programmed in COM or DCOM, then I might understand any hesitation or reluctance since the initial learning curve is substantial in Visual C++ but if your a veteran COM programmer, this is one of those rare instances where I'd have to ask "Why not give it a try?". Once you write the code for one property, you can reuse that code for most others.
|
|
|
|
|
hi
thanks for the reply
my code is working fine upto winxp. but i am not able to get same info in vista. it return blank. i am able find out wich os is runing and base on i can call that function. that is ok. just i want what are the change in vista to get hdd serial number.
if i include wmi with my app. deploment set get big as it include complet wmi and i want only one info i.e. hdd serial no. so it would be not good just to include whole stuff in my deploment setup. this is same case with dotnet framework. that is why i want to write this code i my app.
thank you
|
|
|
|
|
Fair enough.
What method are you using to obtain HDD Serial number as it might help understand what might be stopping it?
Just to see if it's related to UAC, have you disabled UAC temporarily while trying your code to see if it works. I'm not sure how that could affect code that normally runs as "user" but Vista has been throwing some pretty mean curveballs my way the last few weeks so it might not be a bad idea to try that.
If you go to administrative tools, Local Security Policy, Local Policies, Security Options, and scroll to the "User Account Control:" settings and disable them (Just for testing) and try what you are trying and it works, then you found the culprit(s). You may need to logoff/logon or restart to get the new settings to apply.
|
|
|
|
|
Greetings All,
I have a client CSocket sending information to a server CSocket. For simplicity, I make the client scocket send message only, without receiving or processing any returned message.
I wonder, if the server keeps sending back acknowledgements and piles up the client's receiving buffer, what will happen. Will old messages be automaticly cleared? Or, will click socket crash due to the buffer overflow?
Is there any way to make the client socket automatically discard all returned message and clear the receiving buffer?
Many thanks,
Bill
|
|
|
|
|
TCP protocol?
Is the server sending acknowledgements or are you talking about the ones that are part of the
protocol?
If you are sending bytes then they should be flushed (recv'd) at the destination but the protocol
ACKs will be stripped by the protocol stack.
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
|
Thanks for the reply.
I was talking about the message sent back by the server. The server intendedly sends back some information via the connected socket, but the client doesn't need it. Therefore, I didn't use OnReceive() in the client side. And, I do not know how to make the client automatically delete those messages from the stack.
I was just curious if this would overflow the buffer of the client port.
Thanks.
Bill
|
|
|
|
|
Yes the buffer will fill up on the receiving side. That will cause the sending side not to send
which means the send buffer will fill there as well. On the send side, a blocking socket will
block indefinitely and a non-blocking socket will indicate an WSAEWOULDBLOCK error on subsequent
sends.
If reply/acknowledge data is sent by the server in your communication protocol then it's
probably best to recv it at the client even if you do nothing with it.
I suppose it will work with the buffers full if both ends handle the condition correctly but if
efficiency is important it's best to keep the buffers flushed.
Mark
"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
