C / C++ / MFC

1-Jun-02 6:48

hi.. all
i have a function that travel the file tree( like window explore ), get the tree item, calculate the file size, and estimate how many page will print. and print to the .txt file.
the function is doing ok. it is fast when estimating all files( let's say 1000 files). but for 12000 files, so.. slow. for 35000 files, even worst. it took 10 minues to finish all travel, get file size, do caculation, and write to the file. i found out for that 35000 files, the txt file has 238 pages, which is the reason it took 10 minues, i guess.

here how i print to file.
1. open file -> ofstream file; file.open("c:\estimated.txt");
2. do estimate-> get file size and calculate
3. print to file -> file<

Joaquín M López Muñoz1-Jun-02 6:56

Joaquín M López Muñoz

1-Jun-02 6:56

Are you opening the file each time you write to it? If so, you might consider keeping the file open for the duration of the whole scanning process. This should speed your app up by orders of magnitude.

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo

Brian Delahunty1-Jun-02 7:11

1-Jun-02 7:11

If your opening the file each time then that woudl slow it down. Just open at the begining of your app and close at the bottom.

ofstream outFile("estimated.txt");

and then close it Smile | :)

"When a friend hurts us, we should write it down in the sand, where the winds of forgiveness get in charge of erasing it away, and when something great happens, we should engrave it in the stone of the memory of the heart, where no wind can erase it"
Nish on life [methinks]

pnpfriend1-Jun-02 7:52

1-Jun-02 7:52

yes.. i do open the file very top and close it after tree travesal, and calculation for all has finished.
but thanks i have another file which is getting the size of the file open and close for each file. i will put that into array and read it from array. hope that will speed my estimate page function.

thanks guys

Brian Delahunty1-Jun-02 9:33

1-Jun-02 9:33

Win wrote:
i will put that into array and read it from array. hope that will speed my estimate page function.

Try using a vector... itmight work quicker than an array. Especially if your filling it with lots of info... and it's dynamic too [and genreic] Wink | ;-)

pnpfriend1-Jun-02 9:47

1-Jun-02 9:47

oh.. i was trying to use it.. can you check my post which way is better.. no. let me post it back here again.
i have a structure, call

<br />
struct FileType<br />
{<br />
  char type[_MAX_EXT];<br />
  char size[20];<br />
   <br />
};<br />
<br />

and the text file that looks like

.txt 4140
.tif 4100
.doc 21000
.pdf 3459
.
.
.

so i want to read from the text file and put it into array.
so used vector.

<br />
#include <vector><br />
typedef vector<TypeSize> typeNsize;<br />
<br />
  TypeSize typeNsize;<br />
<br />
  ifstream filelist("TableOfType.txt",ios::in);   //open TableOfType.txt  <br />
  while(!filelist.eof())<br />
  {<br />
    filelist>>typeNsize.filetype>>typeNsize.size;<br />
    <br />
  }<br />
  filelist.close();<br />

my application is dialog base.

and i have following errors

<br />
<br />
SMPprojectDlg.cpp<br />
E:\SMP\SMPprojectDlg.cpp(2161) : error C2143: syntax error : missing ';' before '<'<br />
E:\SMP\SMPprojectDlg.cpp(2161) : error C2143: syntax error : missing ';' before '<'<br />
E:\SMP\SMPprojectDlg.cpp(2163) : error C2065: 'TypeSize' : undeclared identifier<br />
E:\SMP\SMPprojectDlg.cpp(2163) : error C2146: syntax error : missing ';' before identifier 'typeNsize'<br />
E:\SMP\SMPprojectDlg.cpp(2163) : error C2065: 'typeNsize' : undeclared identifier<br />
E:\SMP\SMPprojectDlg.cpp(2168) : error C2228: left of '.filetype' must have class/struct/union type<br />
E:\SMP\SMPprojectDlg.cpp(2168) : error C2228: left of '.size' must have class/struct/union type<br />
Error executing cl.exe.<br />
<br />
SMPproject.exe - 7 error(s), 0 warning(s)<br />

i was thinking to use CStringArray like read the sentence like

<br />
char info[50];<br />
filelist.getline(info,50,'\n');<br />
CString infoline = (const char*)info;<br />
CStringArray array;<br />
array.add(infoline)<br />

if i do so , i have to separate the string into two parts, type and size, again. i dont' want to do that..
do you have any idea better than what i have right now?

Brian Delahunty1-Jun-02 10:05

1-Jun-02 10:05

Try this

================================================
#include <iostream>
#include <fstream>
#include <vector>

using namespace std;

/*

Other code here

*/

struct FileType
{
char type[_MAX_EXT];
char size[20];

};

/*

other code here

*/

vector<FileType> v_filetypes;

ifstream filelist("TableOfType.txt", ios::in); //ios:in is optional

while(!filelist.eof())
{
filelist >> v_filetypes.type >> v_filetypes.size;
}

filelist.close();

================================================

That should work fine... I think.. but my brain isn't working the best Smile | :)

pnpfriend1-Jun-02 10:39

1-Jun-02 10:39

wow!!!
i use cstringarray to store files types and sizes
as follow:

<br />
char info[50];<br />
CStringArray array;<br />
ofstrea filelsit.open("type.txt");<br />
while(!filelist.eof())<br />
{<br />
filelist.getline(info,50,'\n');<br />
CString infoline = (const char*)info;<br />
array.add(infoline)<br />
}<br />

guess what it only tooks 16 sec to read and estimate page to print for all 350000 files.
compare to old function, way way faster. old function took 10 mins and now only 16 sec.
i say WOW WTF | :WTF:

let me try to use vector.. i think vector might be faster because i dont' have to separator type and size again.

Brian Delahunty1-Jun-02 10:35

geting start and end address of a running process?

1-Jun-02 10:35

Win wrote:
way way faster. old function took 10 mins and now only 16 sec

I'd say thats a good improvement!!! Smile | :)

hwnd1-Jun-02 6:26

hwnd

1-Jun-02 6:26

like "0x00400000"

Re: geting start and end address of a running process?

Mike Nordell1-Jun-02 7:02

Mike Nordell

1-Jun-02 7:02

Since a process can have multiple heaps, load DLL's at rather high addresses (eg kernel32.dll is loaded somewhere at 0x77xxxxxx IIRC) I think it's a rather unusable piece of information.

If you on the other hand was interested in what address (and with what length) a PE was mapped at you can use VirtualQuery(). To see what heaps a process has (and how large they are ...) you can use GetProcessHeaps() + HeapWalk().

Limiting Characters in Edit Box :: MFC

valikac1-Jun-02 5:30

valikac

1-Jun-02 5:30

Hi.

I would like to limit the number of characters a user make enter at any given time to a finite integer. For example, let say I have an edit box in a dialog box for entering zip code. I would like to limit the number of characters to *exactly five*.

I have tried using DDV verification feature in a dialog box. However, I found that the user can overflow the edit box. For example:

limit: 500
User: 500000

If the user overflow the edit box, for DDV will consider the data entered as being valid. I believe the problem has something to do with overflowing a datatype.

Nonetheless, what is the best way to limit the number of characters/digits entered in an edit box?

Thanks,
Kuphryn

Joaquín M López Muñoz1-Jun-02 5:38

Joaquín M López Muñoz

1-Jun-02 5:38

Have a look at Alvaro Mendez' article Validating Edit Controls. He provides several CEdit-derived controls for limitting user input --I guess they can serve your needs.

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo

dlhson1-Jun-02 5:49

dlhson

1-Jun-02 5:49

You just go to ClassWizard, go to member variables sheet,
you can see at the bottom of sheet, there is a property:
Maximum character !!!!!!!
Wink | ;)

Hung Son
A Vietnamese student
i-g.hypermart.net
dlhson2001@yahoo.com

valikac1-Jun-02 6:15

valikac

1-Jun-02 6:15

Okay. Thanks.

Kuphryn