C / C++ / MFC

Mark Salsbery30-Dec-06 8:38

Mark Salsbery

30-Dec-06 8:38

Is this line succeeding?

m_bmpBackImage.SetBitmapBits(bmih.biWidth*bmih.biHeight, byBmp + bmfh.bfOffBits);

bmih.biWidth*bmih.biHeight will only work for 8-bit bitmaps that have a width aligned to a
multiple of 4 bytes.

Here's a generic method of calculating bitmap image size that will work for all bit depths.

LONG BytesPerLine = (((bmih.biWidth * (long)bmih.biBitCount + 31L) & (~31L)) / 8L);
m_bmpBackImage.SetBitmapBits(BytesPerLine * (bmih.biHeight > 0 ? bmih.biHeight : -bmih.biHeight), 
                    byBmp + bmfh.bfOffBits);

You could also use bmih.biSizeImage if it's not 0.

Mark Salsbery30-Dec-06 10:05

Mark Salsbery

30-Dec-06 10:05

Another item....you should use SetDIBits() instead of SetBitmapBits() Smile | :)

Re: any gdi guru can help me? [modified]

OmarLodhi31-Dec-06 19:07

OmarLodhi

31-Dec-06 19:07

Hi,

Here is code that i use to create image.

file = fopen(m_csBkImagePath, "rb");
fseek(file, SEEK_END, SEEK_END);
nSize = ftell(file);

byBmp = new BYTE[nSize];
fseek(file, SEEK_SET, SEEK_SET);

memset(byBmp, 0, nSize);
fread(byBmp,nSize, 1, file);

BITMAPFILEHEADER bmfh;
memcpy(&bmfh, byBmp, sizeof(bmfh));
BITMAPINFOHEADER bmih;
memcpy(&bmih, byBmp + sizeof(bmfh), sizeof(bmih));

int nRet = m_bmpBackImage.CreateBitmap(bmih.biWidth, bmih.biHeight, bmih.biPlanes, bmih.biBitCount, NULL);

nRet = m_bmpBackImage.SetBitmapBits(bmih.biSizeImage, byBmp + bmfh.bfOffBits);
delete [] byBmp;

here is the drawing code that i use to draw the image.

dcMemBkImage.CreateCompatibleDC(pDC);
dcMemBkImage.SelectObject(&m_bmpBackImage);
GetObject(m_bmpBackImage,sizeof(bitmap),&bitmap);
pDC->BitBlt(m_nLeft, m_nTop, bitmap.bmWidth, bitmap.bmHeight, &dcMemBkImage, 0, 0, SRCCOPY);
dcMemBkImage.DeleteDC();

but nothing is displayed only white image.
is there any reference code i can see. no one has faced this type of problem before?

thanks for all people responses.
Omar Lodhi

Mark Salsbery1-Jan-07 11:22

Mark Salsbery

1-Jan-07 11:22

I changed the code a bit so I could test it, but here's a couple examples that hopefully you can
extract some useful parts from (note that I assumed drawing from a window class so I used a
CClientDC).

To convert the DIB to a DDB and draw the DDB:

FILE *file = fopen("C:\\test.bmp", "rb");
fseek(file, SEEK_END, SEEK_END);
long nSize = ftell(file);
 
BYTE *byBmp = new BYTE[nSize];
fseek(file, SEEK_SET, SEEK_SET);
 
//memset(byBmp, 0, nSize);
fread(byBmp,nSize, 1, file);
 
fclose( file );
 
BITMAPFILEHEADER *bmfh = (BITMAPFILEHEADER *)byBmp;
BITMAPINFO *bmi = (BITMAPINFO *)(byBmp + sizeof(BITMAPFILEHEADER));
BITMAPINFOHEADER *bmih = (BITMAPINFOHEADER *)bmi;
 
CClientDC dc(this);
CDC dcMemBkImage;
dcMemBkImage.CreateCompatibleDC(0);
CBitmap m_bmpBackImage;
LONG lScanLines = bmih->biHeight > 0 ? bmih->biHeight : -bmih->biHeight;
int nRet = m_bmpBackImage.CreateCompatibleBitmap(&dc, bmih->biWidth, lScanLines);
 
::SetDIBits(dcMemBkImage, m_bmpBackImage, 0, lScanLines, byBmp + bmfh->bfOffBits, bmi, DIB_RGB_COLORS); 
 
delete [] byBmp;
 
...
 
// Draw the DDB
CClientDC dc(this);
CBitmap *pOldBitmap = dcMemBkImage.SelectObject(&m_bmpBackImage);
BITMAP bitmap;
::GetObject(m_bmpBackImage,sizeof(bitmap),&bitmap);
dc.BitBlt(50, 50, bitmap.bmWidth, bitmap.bmHeight, &dcMemBkImage, 0, 0, SRCCOPY);
dcMemBkImage.SelectObject(pOldBitmap);
dcMemBkImage.DeleteDC();

An alternative is to draw the DIB bits without converting to a DDB:

FILE *file = fopen("C:\\test.bmp", "rb");
fseek(file, SEEK_END, SEEK_END);
long nSize = ftell(file);
 
BYTE *byBmp = new BYTE[nSize];
fseek(file, SEEK_SET, SEEK_SET);
 
//memset(byBmp, 0, nSize);
fread(byBmp,nSize, 1, file);
 
fclose( file );
 
BITMAPFILEHEADER *bmfh = (BITMAPFILEHEADER *)byBmp;
BITMAPINFO *bmi = (BITMAPINFO *)(byBmp + sizeof(BITMAPFILEHEADER));
BITMAPINFOHEADER *bmih = (BITMAPINFOHEADER *)bmi;
 
LONG lScanLines = bmih->biHeight > 0 ? bmih->biHeight : -bmih->biHeight;
 
CClientDC dc(this);
::SetDIBitsToDevice(dc, 50, 50, bmih->biWidth, lScanLines, 0, 0, 0, lScanLines, byBmp + bmfh->bfOffBits, bmi, DIB_RGB_COLORS);
 
delete [] byBmp;

-- modified at 22:07 Monday 1st January, 2007
*EDIT* Fixed code in first example Smile | :)

-- modified at 22:15 Monday 1st January, 2007

HiEdit V1.0.1.4 [modified]

OmarLodhi2-Jan-07 14:59

OmarLodhi

2-Jan-07 14:59

Thanks a lot Smile | :)

,
you have solved my problem.
thanks again.

omar lodhi

akyprian28-Dec-06 21:33

28-Dec-06 21:33

Hi all,

HiEdit V1.0.1.4 has been released. HiEdit is a multi-tabbed, high speed, large file edit control. It uses no more than ~140K of memory due to its sophisticated memory management. It supports most standard edit/richedit control messages and many custom ones. You can use it with any programming language since it is packaged as a standard dll and a static library. A full source demo application (written in Assembly) is inluded. You can get it here[^].

In addition, you can get HiEditor V1.0.1.5 (a full blown application that uses HiEdit)

Any feedback/suggestions is highly appreciated

Regards,

Antonis Kyprianou

-- modified at 3:53 Friday 29th December, 2006

http://www.winasm.net

And the question is?

CPallini28-Dec-06 21:43

CPallini

28-Dec-06 21:43

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

Re: And the question is?

akyprian28-Dec-06 21:50

28-Dec-06 21:50

Thanks for your reply. There is no question. HiEdit is a custom control that can be used in your applications and I wanted to let you know, in case you are interested.

Regards,

Antonis

http://www.winasm.net

Re: And the question is?

prasad_som28-Dec-06 22:22

prasad_som

28-Dec-06 22:22

Haven't read point no. 10 in Chris's sticky post at the top ?
"No advertising or soliciting."

Prasad
Notifier using ATL | Operator new[],delete[][^]

ThatsAlok28-Dec-06 23:00

ThatsAlok

28-Dec-06 23:00

akyprian wrote:
In addition, you can get HiEditor V1.0.1.5 (a full blown application that uses HiEdit)

Any feedback/suggestions is highly appreciated

ads are not allowed here, as per forum guidelines, you better post article here, expect the any feed back there

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief and you

akyprian29-Dec-06 0:03

29-Dec-06 0:03

Excuse my ignorance, but is the post about a free custom control considered as an ad? If so, please delete my post. Only questions are allowed?

http://www.winasm.net

ThatsAlok29-Dec-06 0:46

ThatsAlok

29-Dec-06 0:46

akyprian wrote:
Excuse my ignorance, but is the post about a free custom control considered as an ad? If so, please delete my post. Only questions are allowed?

i am not Admin here, i just showing you way to get good feedback

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief and you

David Crow29-Dec-06 3:56

David Crow

29-Dec-06 3:56

akyprian wrote:
Excuse my ignorance...

Ignorance issues aside, it's simply against forum guidelines to post an ad in a Q&A forum. Feel free to create an article about your custom control, however.

akyprian wrote:
...is the post about a free custom control considered as an ad?

It is in the context in which you did it.

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

akyprian29-Dec-06 4:18

29-Dec-06 4:18

If this kind of post is an ad, then I don't know what to say. I 've never considered this kind of posts in any of the forums I admin/moderate as an ad.

Thanks for your kindness, anyway

Antonis

http://www.winasm.net

Hamid_RT29-Dec-06 17:32

Hamid_RT

29-Dec-06 17:32

if you have an article and you think its helpful for other people you can post your article to the codeproject Smile | :)

WhiteSky

akyprian30-Dec-06 11:40

30-Dec-06 11:40

Thanks a lot WhiteSky. I 'll do.

Cheers,

Antonis

http://www.winasm.net