ASP.NET

9-Sep-06 16:39

Let me explain.
GetExcludeFolder() - Gets from XML folders that has to be excluded, that's ok.
To enable paging, first I have to fill the array and then display the data from an array as I did in foreach.

The problem code is if statesment.
It says if s.Name doesen't have any string that GetExcludeFolder() returns, then fill the array with this folder name otherwise dont fill array.

When I run this, I get all folder from wwwroot.
Iam confused, what Iam doing wrong?

protected override void Render(HtmlTextWriter writer)
{
    int i = 0, j = 0;
    DirectoryInfo dir = new DirectoryInfo(@"f:\inetpub\wwwroot\");
    DirectoryInfo[] d = dir.GetDirectories("*");

    foreach (DirectoryInfo s in d)
    {
        if (s.Name.IndexOf(GetExcludeFolder()) == -1) // folder filter
        {
            directory[i, j] = s.Name.ToString();
            directory[i, j + 1] = s.CreationTime.ToString();
            i++;
        }
    }

        Response.Write("<table cellpadding=\"0\" cellspacing=\"0\" border=\"1\" width=\"100%\">");
            Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px; width: 50%;\">Folder name");
                Response.Write("</td>");
                Response.Write("<td style=\"height: 25px; width: 50%;\">Date created");
                Response.Write("</td>");
            Response.Write("</tr>");

            j = 0;
            for (i = currentPage * pageSize - pageSize; i < currentPage * pageSize; i++ )
            {
                Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px;\"><a href=\"http://localhost/" + directory[i, j] + "/\">" + directory[i,j]); // folder name
                Response.Write("</a></td>");
                Response.Write("<td style=\"height: 25px;\">" + directory[i,j + 1]); // creation date
                Response.Write("</td>");
                Response.Write("</tr>");
            }
            Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px\" colspan=\"2\">");

                Response.Write("1 2 3");

                Response.Write("</td>");
            Response.Write("</tr>");
        Response.Write("</table>");

    //base.Render(writer);
}

Guffa9-Sep-06 23:10

9-Sep-06 23:10

You use a lot of variables that you (hopefully?) have defined outside the method. For instance, where, when and how do you create the directory array?

What does the GetExcludeFolder() method return? Why do you use IndexOf to compare it with the Name property?

---
b { font-weight: normal; }

Kasic Slobodan10-Sep-06 2:20

10-Sep-06 2:20

I said above what returns GetExcludeFolder()

GetExcludeFolder() - Gets from XML folders that has to be excluded, that's ok.

directory array is declared global to the class, like pageSize and currentPage.

I use IndexOf to see what folders I don't need to enter into the array so it checks if a s.Name is comprehended in string that GetExcludeFolder returns.
If so, don't add that folder name into the array.

One more thing. String that returns GetExcludeFolder is something like: aspnet_client;_vti_cnf;vti_pvt;_vti_script;_vti_text;

Hope this is understandable.

Guffa10-Sep-06 2:31

10-Sep-06 2:31

Kasic Slobodan wrote:
I said above what returns GetExcludeFolder()

GetExcludeFolder() - Gets from XML folders that has to be excluded, that's ok.

That information is not clear enough to determine the cause of the error. If the method actually returns more than one folder name, then your code doesn't make sense. That's also why I asked why you are using IndexOf.

Kasic Slobodan wrote:
One more thing. String that returns GetExcludeFolder is something like: aspnet_client;_vti_cnf;vti_pvt;_vti_script;_vti_text;

Then you should look in that string for the folder name, not the other way around.

---
b { font-weight: normal; }

Dominic Pettifer10-Sep-06 2:37

Dominic Pettifer

10-Sep-06 2:37

One more thing. String that returns GetExcludeFolder is something like: aspnet_client;_vti_cnf;vti_pvt;_vti_script;_vti_text;

Then your code is basically running the following...

if (s.Name.IndexOf("aspnet_client;_vti_cnf;vti_pvt;_vti_script;_vti_text;") == -1) // folder filter<br />
                {<br />
                    directory[i, j] = s.Name.ToString();<br />
                    directory[i, j + 1] = s.CreationTime.ToString();<br />
                    i++;<br />
                }

It's looking for the entire string of 'aspnet_client;_vti_cnf;vti_pvt;_vti_script;_vti_text;' inside your folder name for each folder and obviouly not finding it, and thus return ALL directories. You need to put the excluded folder names in some form of array then iterate through the array inside your foreach (DirectoryInfo s in d) checking ifthe current directory has been excluded. Hope that makes sense. Smile | :)

Sunday Ironfoot

www.dominicpettifer.co.uk (work in progress)

Dominic Pettifer10-Sep-06 2:49

Dominic Pettifer

10-Sep-06 2:49

Here's a rewrite of your code....

protected override void Render(HtmlTextWriter writer)
{
     int i = 0, j = 0;
     DirectoryInfo dir = new DirectoryInfo(@"f:\inetpub\wwwroot\");
     DirectoryInfo[] d = dir.GetDirectories("*");

     String[] excludedFolders = { "aspnet_client", "_vti_cnf", "vti_pvt", "_vti_script", "_vti_text" };

     foreach (DirectoryInfo s in d)
     {
          foreach(String folderToExclude in excludedFolders)
          {
               if (s.Name.IndexOf(folderToExclude) == -1) // folder filter
               {
                    directory[i, j] = s.Name.ToString();
                    directory[i, j + 1] = s.CreationTime.ToString();
                   i++;
               }
          }
     }

     // The rest of the code........
}

There may be a better way to write it rather than use multiple nested for loops, but that should work.

The 'excludedFolders' String array could get it's contents from your function ie.

String[] excludedFolders = GetExcludeFolder();

...making sure GetExcludeFolder() method returns an array of strings.

Sunday Ironfoot

www.dominicpettifer.co.uk (work in progress)

Kasic Slobodan10-Sep-06 4:13

10-Sep-06 4:13

@ Guffa

When I write if like: if (GetExcludeFolder().IndexOf(s.Name) == -1)
then all folder that GetExcludeFolder return arent added to array except two.

Iam confused, becouse I have done this planty of time, but reverse, not to exclude, but to include and this worked perfectly with the IndexOf method.
I don't know why that doesent work.

This is that method i was telling you about:

tFileTypes.Text = .zip;.rar;.exe;

and this is if

if (tFileTypes.Text.IndexOf(fi.Extension.ToString()) >= 0) // fi is in foreach, FileInfo

And this works. Its the same method, but the other condition.

I will use your code becouse I dont have a patience to experiment anymore.

Thank you both.

Dominic Pettifer10-Sep-06 4:39

Dominic Pettifer

10-Sep-06 4:39

When I write if like: if (GetExcludeFolder().IndexOf(s.Name) == -1)
then all folder that GetExcludeFolder return arent added to array except two.

That should work, maybe want to check the string variable contents, maybe a space or something is being added somewhere it shouldn't, does your IDE (Visual Studio etc) have a debugger?

The only problem with that though is that the GetExcludeFolder() method is being called multiple times, once in each 'foreach' loop depending on how many directories there are. If the 'GetExcludeFolder()' method is fairly resource intensive (reading the file system for instance), the code I gave you using string arrays may be more efficient since 'GetExcludeFolder()' method is only being called once.

Good luck! Smile | :)

Sunday Ironfoot

www.dominicpettifer.co.uk (work in progress)

Guffa10-Sep-06 6:25

10-Sep-06 6:25

What folders are excluded that you think should be included?

---
b { font-weight: normal; }

Kasic Slobodan10-Sep-06 7:38

Re: ASP.NET uploading images

10-Sep-06 7:38

I made a typo Smile | :)

when I said that there is folders that are excluded, but it's not.
There is no directory named vti_pvt and _vti_text it should be _vti_pvt and _vti_txt Smile | :)

.
Small typeo's, but makes a hell of a project Smile | :)

.
I did a detailed debug nd saw this irregularity.

I did listen to Ironfoot and move GetExcludedFolder() out of the foreach.
But I didn't do as Ironafoot said with two for's becouse it would be hard to create an array from one string that is read from Xml.
Replaced array with ArrayList becouse I need dynamic array and now code, that works, looks like this:

protected override void Render(HtmlTextWriter writer)
{
    string tmp = GetExcludeFolder();
    int i = 0;
    DirectoryInfo dir = new DirectoryInfo(GetWwwRootFolder());
    DirectoryInfo[] d = dir.GetDirectories("*");

    foreach (DirectoryInfo s in d)
    {
        if (tmp.IndexOf(s.Name) == -1) // folder filter
        {
            directory.Add(s.Name.ToString());
            date.Add(s.CreationTime.ToString());
            i++;
        }
    }

        Response.Write("<table cellpadding=\"0\" cellspacing=\"0\" border=\"0\" width=\"100%\">");
            Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px; width: 50%;\">Folder name");
                Response.Write("</td>");
                Response.Write("<td style=\"height: 25px; width: 50%;\">Date created");
                Response.Write("</td>");
            Response.Write("</tr>");

            for (i = currentPage * pageSize - pageSize + 1; i <= currentPage * pageSize; i++ )
            {
                if (i >= directory.Count)
                    break;

                Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px;\"><a href=\"http://localhost/" + directory[i - 1] + "/\">" + directory[i - 1]); // folder name
                Response.Write("</a></td>");
                Response.Write("<td style=\"height: 25px;\">" + date[i - 1]); // creation date
                Response.Write("</td>");
                Response.Write("</tr>");
            }
            Response.Write("<tr>");
                Response.Write("<td style=\"height: 25px\" colspan=\"2\"><div align=\"" + GetPagingAlign() + "\" id=\"CustomPageAlign\">");
                Response.Write("Choose page: ");

                int mat = (int)Math.Ceiling((decimal)directory.Count / pageSize);

                for (i = 1; i <= mat; i++)
                {
                    // creating page links
                    if (i == currentPage)
                    {
                        Response.Write(i + " | ");
                    }
                    else
                    {
                        Response.Write("<a href=\"Default.aspx?Page=" + i + "\">" + i + "</a> | ");
                    }
                }

                Response.Write("</div></td>");
            Response.Write("</tr>");
        Response.Write("</table>");

    //base.Render(writer);
}

It always helps me to see a bug if I talk to someone (forums, mails, etc.). I get a good code's that I can use and with talking, I can see some bugs that I could never see if I wasn't wrote this thread and ask you.

Thank you both for your time. I appreciated.

ASP.NET uploading images

Solly749-Sep-06 16:34

Solly74

9-Sep-06 16:34

How do i upload images on to specified web pages?

thank you Smile | :)

Nothing lasts but nothing is lost

postmaster@programmingknowledge.com9-Sep-06 17:47

postmaster@programmingknowledge.com

9-Sep-06 17:47

see an example at :
http://www.programmingknowledge.com/ImageUpload.aspx[^]

Re: ASP.NET uploading images

Britney S. Morales11-Sep-06 12:18

Britney S. Morales

11-Sep-06 12:18

Check this post

http://codeproject.com/aspnet/netimageupload.asp

Smile | :)

keep Learning...

Asp.net 2.0 + javascript ...please help

deepaks39-Sep-06 11:47

deepaks3

9-Sep-06 11:47

Hi
I have 2 chekboxes and a submit button in asp.net 2.0

on first checkbox onclick event i wrote a javascript , that will check the other checkbox to true and disable it.

now when i submit the page , before submmiting the page i get the other check box as checked = false; but acctually i have done it checked= true; using javasccript

please help why this is happening as i need to the other checkbox as checked = true using javascript

deepak

Re: Asp.net 2.0 + javascript ...please help

Guffa9-Sep-06 12:17