|
OK. So you know ArrayList's do not have fields - only one dimension
One value per row if you like...
You could use the ArrayList.Item(index) property passing the index
or ArrayList.Contains(Value) passing the value.
Do you just want to see if a value exists in each array?
Do you want to see if a value exists in each array at the same index?
Do your arrays contain duplicate values?
Steve
|
|
|
|
|
I want to see if the value at a given index in one array is the same as the value at the same index in a different array, I don't need to know what the value is, just want to see if the values are the same
|
|
|
|
|
I tried
For r As Integer = 0 To 9
If arraylist1.Item(r) = arralist2.Item(r) Then
count = count + 1
End If
Next
but still get this message "Operator is not valid for type "
|
|
|
|
|
Should be:
For r As Integer = 0 To 9
If arraylist1.Item(r) = arralist2.Item(r) Then
r = r + 1
End If
Next
Where did 'count' come from?
You can also increment by using r += 1
|
|
|
|
|
You may need to try something like this:
Dim str1, str2 As String
For r As Integer = 0 To 9
str1 = arraylist1.Item(r)
str2 = arralist2.Item(r)
If str1 = str2 Then
'Implementation code here - set bool flag, exit sub etc
End If
r = r + 1
Next
|
|
|
|
|
I should not need to increment 'r'
the for - next structure does that
the count is a count of the number of times the two rows match, dimmed before the for next statement
but when I try to run this I get a message
Operator is not valid for type
|
|
|
|
|
Oh! You are right. I'm sorry...don't know what I was thinking there!
Did you try:
str1 = ArrayList1(0)
str2 = ArrayList2(0)
and then compare the strings?
Steve
|
|
|
|
|
I've tried various combinations setting = to a string, using Cstr, referencing field, not referencing field
I've also tried copying to a array using copyto and setting an specific row = to a specific row in an array, but nothing works
My compare logic works for arrays, if I could figure out how to copy the arralyist to an array I would do the compare there
|
|
|
|
|
Ok. Give me a while and I'll try doing it myself.
I'll get back to you...
Steve
|
|
|
|
|
I'm thinking actually to create two sets of data
one in arraylists and one in arrays, sounds like a bad design, but there are things that I can only figure out how to do in an arraylist and things I can only figure out how to do in an array
Anyway, if I do this, my problem is solved, I can make it work this way
thanks
|
|
|
|
|
I have just tried it and this works:
Dim Arr1 As ArrayList
Dim Arr2 As ArrayList
Arr1 = New ArrayList(10)
Arr2 = New ArrayList(10)
Arr1.Add("Fred")
Arr2.Add("Fred")
If Arr1.Item(0) = Arr2.Item(0) Then
MessageBox.Show("There is a match!")
Else
MessageBox.Show("There is no match...")
End If
Change the string for Arr2 and you will get the 'no match' message.
Hope that helps.
Steve
|
|
|
|
|
Steve
got it working ,great
thanks for all your help
(also Steve)
|
|
|
|
|
Great! Pleased I could help.
Steve
|
|
|
|
|
I'm still have no idea on what will compare with what.
Lets figure these out:
say, you have 2 multidimension arrays
+-----------+ +-----------+
| StrList1 | | StrList2 |
+-----------+ +-----------+
| 0 | Jenny | | 0 | Jenny |
| 1 | Fred | | 1 | Fred |
| 2 | Sony | | 2 | Rudy |
| 3 | Marti | | 3 | Marti |
| 4 | Rudy | | 4 | Sony |
+-----------+ +-----------+
You want to compare the second coloumn of each array. if the values is match then will return the row index.
Make sure, the arrays have a same data type or you can convert it to specific datatype before you campare the values.
-------------------------------------------------
Dim RowIdx() as Integer = {}
For i as Integer=0 to StrList1.GetUpperBound(0)
if StrList1(i, 1) = StrList2(i, 1) then
'you can change with yours
Dim x as integer = RowIdx.GetUpperBound(0)
Redim RowIdx(x + 1)
Dim y as Integer = RowIdx.GetUpperBound(0)
RowIdx(y)=i
End If
Next
----------------------------------------------------
Is it what you mean?
-- modified at 7:41 Thursday 3rd August, 2006
|
|
|
|
|
thanks but
these are arraylists, not arrays
so yes the data rows look like this
+-----------+ +-----------+
| StrList1 | | StrList2 |
+-----------+ +-----------+
| 0 | Jenny | | 0 | Jenny |
| 1 | Fred | | 1 | Fred |
| 2 | Sony | | 2 | Rudy |
| 3 | Marti | | 3 | Marti |
| 4 | Rudy | | 4 | Sony |
+-----------+ +-----------+
And yes, I want to count the number of times the second value in each row matches, i;e Jenny = Jenny 1, Fred = Fred 2, Sony not = Rudy etc
But arraylists are one dimensional
Okay, no problem I think because
0 Jenny is still = 0 Jenny; i;e; if I have 0 Jenny and 1 Jenny, it's not a match, its only a match when every thing in the datarow is the same
So I tried this with the arraylist, assuming a one dimensional arraylist
Dim RowIdx() As Integer = {}
For r As Integer = 0 To 9
If arraylist1(r) = arraylist2(r) Then
Dim x As Integer = RowIdx.GetUpperBound(0)
ReDim RowIdx(x + 1)
Dim y As Integer = RowIdx.GetUpperBound(0)
RowIdx(y) = i
End If
Next
but I get the same error message I've been getting all lone
Operator is not valid for type ( field name)
I've had the logic working for arrays, but the program uses arraylists
I've tried copying the arraylist to an array, but it doesn't work
|
|
|
|
|
Hmm.. have you check the datatype on both arrays..
I believe you knew that Integer and Long were not the same things and it would throw exception if you compare those values.
or try to edit this line:
....
If arraylist1(r) = arraylist2(r) Then
....
replace with:
....
if CType(arrayList1(r), Object) = CType(arrayList2(r), Object) Then
....
you can replace Object data type into another data type but remember to set the sama data type on both side of comparison process.
|
|
|
|
|
Or...
Here we have 2 array list
ArrList1
--------
arrayA1 *
arrayA2 *
arrayA3 *
arrayA4 *
--------
ArrList2
--------
ArrayB1 *
arrayB2 *
arrayB3 *
arrayB4 *
--------
*= 1 dimensional array.
Lets say you want to compare arrayA2(n).Length with arrayB2(n).Length.
But before we compare the values, we need to compare the bounds of arrays.
-----------------------
Dim x as integer = ArrList1.GetUpperBound(0), _
y as integer = ArrList2.GetUpperBound(0)
if x = y then
For i as integer = 0 to x
If ArrList1(i).Length = ArrList2(i).Length Then
'put your code here
End If
Next
End If
You can't compare "arraylist1(r) = arraylist2(r)" because the value on both side is an array, not property of array.
Every array has properties(Length, UpperBound, LowerBound, i;e)
I mean you can't compare your gf with your friend's gf, except they properties such as skin color, cute face, height, etc.
Here sample code to copy an array from array list to a new array:
Dim newarr As Object() = ArrList1(1).Clone
Good Luck
-- modified at 4:59 Friday 4th August, 2006
|
|
|
|
|
I know this is very simple to you, but I could not debug the problem. I am writting a program to read everyline of a textfile. If the line has date as my format and an "Error" string, then it must go to the IF/THEN ELSE loop. But in fact, it can go to the IF/THEN ELSE loop even one of the condition is met. If I run my code today which is 8/1/2006, I expect to see is "8/1/2006 4:01:14 Error", but in fact, the result is 2 lines "7/1/2006 4:01:14 Error" and "8/1/2006 4:01:14 Error"
Would you please help me out. I would appreciate your big helps very much. Below is my text and code.
Tram88
This is the content of text file:-----------------------------------------------------------------
7/1/2006 4:01:14 Error
8/1/2006 4:01:14 Error
This is the VB.NET code:---------------------------------------------------------------------------
Dim eoFile As System.IO.File<br />
Dim eoRead As System.IO.StreamReader<br />
Dim ebStart As Boolean<br />
Dim eStart As String = Format(Today, "M" & "/" & "d" & "/" & "yyyy")<br />
Dim eEnd As String = "email notification started"<br />
eoRead = eoFile.OpenText(strFileEmailNotification) 'opens text file for reading<br />
Dim Pass As Integer = 0<br />
Dim eIntotalCount As Integer<br />
While eoRead.Peek <> -1 'reads until peek is -1, which is end of file<br />
Dim eLineOut = eoRead.ReadLine<br />
Dim estringtext As String = "Error" <br />
Dim eiLine As Integer<br />
<br />
If (InStr(1, eLineOut, estringtext, CompareMethod.Text)) And (InStr(1, eLineOut, eStart, CompareMethod.Text)) Then<br />
intTotalCount = CountStringInFile(strFileEmailNotification, estringtext)<br />
Pass = 1<br />
End If<br />
End While
|
|
|
|
|
I would write this a bit differently but I think this line ...
Dim eStart As String = Format(Today, "M" & "/" & "d" & "/" & "yyyy")
should be ...
Dim eStart As String = Format(Now(), "M" & "/" & "d" & "/" & "yyyy")
...Steve
1. quod erat demonstrandum
2. "Give a man a fish and you've fed him for a day. Teach him how to fish and you've fed him for life." I read that somewhere once 
|
|
|
|
|
Dear Steve,
First, I would say thank you very much for your consideration on my problem. However, I did apply your code but it is still the same, that means 2 lines can drop into the loop. I really get stuck on this, please help me out.
Thanks,
Tram88
|
|
|
|
|
In that case there could be something wrong with the data that's being read.
Run the code in the debugger and single-step it. Whilst doing this, watch the various variables for correct content.
Something is not what you assume it to be. From there we can make a better diagnosis.
...Steve
1. quod erat demonstrandum
2. "Give a man a fish and you've fed him for a day. Teach him how to fish and you've fed him for life." I read that somewhere once
|
|
|
|
|
You could also change this code to have the DIM statements outside of the While loop. Note also the change to the If conditions (i.e. testing for a return value > 0 from InStr() rather than relying on an implicit type conversin to Boolean).
Dim eLineOut As String
Dim estringtext As String = "Error"
Dim eiLine As Integer
While eoRead.Peek <> -1 'reads until peek is -1, which is end of file
eLineOut = eoRead.ReadLine
If (InStr(1, eLineOut, estringtext, CompareMethod.Text) > 0) And (InStr(1, eLineOut, eStart, CompareMethod.Text) > 0) Then
intTotalCount = CountStringInFile(strFileEmailNotification, estringtext)
Pass = 1
End If
End While
...Steve
1. quod erat demonstrandum
2. "Give a man a fish and you've fed him for a day. Teach him how to fish and you've fed him for life." I read that somewhere once 
|
|
|
|
|
Dear Steve,
Based on your code, I do have a question for intTotalCount = CountStringInFile(strFileEmailNotification, estringtext)
If I run the code, I would like to see intTotalCount=1 . In fact, it is 2. Can you teach me how to program it.
Once again, thank you Steve,
Tram88
|
|
|
|
|
Tram88 wrote: Based on your code, I do have a question for intTotalCount = CountStringInFile(strFileEmailNotification, estringtext)
If I run the code, I would like to see intTotalCount=1 . In fact, it is 2. Can you teach me how to program it.
The CountStringInFile() function is not a standard VB function call. I presume you have obtained this code from somewhere else?
If it does what its name implies, then it will scan the entire file for any occurrences of the search string - in this particular case with the data you have already supplied in your first post, there are two lines which contain "Error" therefore the return value will be 2.
What I think you need to do is to change this line:
intTotalCount = CountStringInFile(strFileEmailNotification, estringtext)
to
eIntotalCount = eIntotalCount + 1
since intTotalCount does not seem to be declared anywhere and eIntotalCount is declared but not used. [Was this intentional?]
When your code exits, eIntotalCount will now contain the count of the number of lines in your file that have both the error string AND the date string for which you are searching.
...Steve
1. quod erat demonstrandum
2. "Give a man a fish and you've fed him for a day. Teach him how to fish and you've fed him for life." I read that somewhere once
|
|
|
|
|
It's working now, Thank you very much Steve.
Tram88
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
