C / C++ / MFC

13-Jun-06 23:25

I am trying to get a directory using using one of the shell function i.e. SHBrowseForFolder. Here is my code snippet:

LPBROWSEINFOW dir;<br />
LPWSTR DisplayName;<br />
int iImage;<br />
dir->hwndOwner = NULL;<br />
dir->pidlRoot = NULL;<br />
dir->pszDisplayName = DisplayName;<br />
dir->lpszTitle = L"Open folder";<br />
dir->ulFlags = BIF_NONEWFOLDERBUTTON|BIF_RETURNONLYFSDIRS;<br />
dir->lpfn = NULL;<br />
dir->lParam = NULL;<br />
dir->iImage = NULL;<br />
SHBrowseForFolder(dir);

But as soon as I select a directory and press OK it crashes. Is there anything I am missing. Please help.

Cedric Moonen13-Jun-06 23:31

Cedric Moonen

13-Jun-06 23:31

iLL eFFect wrote:
LPBROWSEINFOW dir;

Your pointer is not initialized so it points to invalid memory address. Instead of using a pointer, use the structure:

BROWSEINFO dir;
dir.hwndOwner = NULL;
...
...
...

SHBrowseForFolder(&dir);

Cédric Moonen
Software developer

Charting control

iLL eFFect13-Jun-06 23:38

13-Jun-06 23:38

Ok it worked some. But crashed at some other place.
Is there something that i have to do?

Cedric Moonen13-Jun-06 23:46

Cedric Moonen

13-Jun-06 23:46

iLL eFFect wrote:
Is there something that i have to do?

Yes: use your debugger. It will help you to track the problem.

Cédric Moonen
Software developer

Charting control

iLL eFFect14-Jun-06 0:04

14-Jun-06 0:04

i cant even use the debugger... obviously that the first thing any developer will do.... the reason is that it is failing in gs_report.c

#if defined (_CRTBLD) && !defined (_SYSCRT)<br />
    DebuggerWasPresent = IsDebuggerPresent();<br />
    _CRT_DEBUGGER_HOOK(_CRT_DEBUGGER_GSFAILURE);<br />
#endif  /* defined (_CRTBLD) && !defined (_SYSCRT) */

and there is no traceable path backwards.

-- modified at 6:06 Wednesday 14th June, 2006

Blake Miller14-Jun-06 12:31

Blake Miller

14-Jun-06 12:31

The display name of the object selected is returned in the buffer pointed to by the pszDisplayName member of the BROWSEINFO parameter structure.

pszDisplayName
Address of a buffer to receive the display name of the folder selected by the user. The size of this buffer is assumed to be MAX_PATH characters.

D'Oh! | :doh:

BROWSEINFOW dir;
WCHAR wcDisplayName[MAX_PATH];

...
dir.pszDisplayName = DisplayName;
...

I've seen better runs in my shorts! - Patches O'Houlihan

iLL eFFect14-Jun-06 17:56

function with variable param

14-Jun-06 17:56

Thanks for the help. it did work.

blue_rabbit13-Jun-06 23:22

blue_rabbit

13-Jun-06 23:22

Hey, i have a trouble for all. That is: For example: I want to write a function that display a messagebox with many param that i want. It should like this (like sprintf())
ms(HWND hwd,char *control_string,...){
static char *c[1000];
sprintf(c,control_string,???);
MessageBox(hwd,c,"ms",0);
};

Understand, but i don't know what ??? is ?.

If i have this function then i can call this function very useful like this:
ms(0,"%s%i%s",
"Untill now, I posted: ",
10000000000000,
" question!");

Is it useful?

Viorel.13-Jun-06 23:39

Viorel.

13-Jun-06 23:39

You have to use va_arg, va_end and va_start macros. Try this:

#include <stdarg.h>
// ...
void ms( HWND hwd, const char * control_string, ...)
{
    va_list argptr;
    va_start(argptr, control_string);
    char c[1000];
    _vsnprintf(c, 1000, control_string, argptr);
    MessageBox(hwd, c, "ms", 0);
    va_end(argptr);
};

Hope it helps.

Serge A. Zhirko13-Jun-06 23:46

Serge A. Zhirko

13-Jun-06 23:46

Try use this lines Wink | ;)

:

int EnhMessageBox(HWND hWnd, int mbFlags, LPCSTR pCaption, LPCSTR pTextFormat, ...)
{
va_list args;
va_start(args, pTextFormat);
int bufSize;
char pBuffer[MAX_PATH*4] = "\0";
bufSize = vsprintf(pBuffer, pTextFormat, args);
va_end(args);
return MessageBox(hWnd, pBuffer, pCaption, mbFlags);
}

Tantum possumus, quantum scimus.

blue_rabbit13-Jun-06 23:51

blue_rabbit

13-Jun-06 23:51

what's vsprintf(...). Please tell me! I'm lazy.

Thanks for your help!