C / C++ / MFC

13-Mar-05 4:05

Hello,

I've posted a question on code project, but didn't get a good reply.

Why does the following code isn't working:

// the input params are

szOperation =  "diff.exe"
szParams = " "C:\1.txt" "C:\WINDOWS\FileSafe\0017CF85-0029-0000-B9ED-DF4AD816684A\olvf.fs"
szCompareResFile ="C:\WINDOWS\FileSafe\0017CF85-0029-0000-B9ED-DF4AD816684A\cfv.fs.cr.1"

The called function to operate the GNU "Diff.exe" (which is based on the RGDiff application taken from code project) is :

int CFSMgr::OperateGNUDiff(CString szOperation,CString szParams,CString szCompareResFile)
{
//	_ONERR(0 < szOperation.GetLength() && 
//		   0 < szParams.GetLength()    && 
//		   0 < szDestFile.GetLength(), return -1);

	int iOperationLen = szOperation.GetLength();
	int iParamsLen    = szParams.GetLength();
	CString szCmdLine(szOperation);
	szCmdLine += _T(" ");
	szCmdLine += szParams;
	TCHAR szCmd[CMD_LINE_BUFF_LEN];
	_tcsncpy(szCmd,(LPTSTR)(LPCTSTR)szCmdLine,iOperationLen + iParamsLen + 2);

	CString szEcnrypted(szCompareResFile);
	szEcnrypted += _T(".enc");

	CString szErrFile(szCompareResFile);
	szErrFile += _T(".err");

	CCrypt c;
	DWORD dwExitCode(0);
	int iLen = szEcnrypted.GetLength();
	TCHAR szKey[] = _T("FS@CORE@");
	TCHAR* lpszEncrypted = NULL;

	BOOL bSucc(FALSE);

	try
	{
		SECURITY_ATTRIBUTES sa;
		sa.nLength = sizeof(sa);
		sa.lpSecurityDescriptor = 0;
		sa.bInheritHandle = 1;

		HANDLE hOutput = CreateFile(szCompareResFile,
									GENERIC_READ|GENERIC_WRITE,
									FILE_SHARE_WRITE | FILE_SHARE_READ,
									&sa, 
									CREATE_ALWAYS,
									FILE_ATTRIBUTE_NORMAL, 
									0);
		HANDLE hErr	= CreateFile(szErrFile,
								 GENERIC_READ|GENERIC_WRITE,
								 FILE_SHARE_WRITE | FILE_SHARE_READ,
								 &sa, 
								 CREATE_ALWAYS,
								 FILE_ATTRIBUTE_NORMAL, 
								 0);

		STARTUPINFO         siStartupInfo;
		PROCESS_INFORMATION piProcessInfo;

		::ZeroMemory(&siStartupInfo, sizeof(siStartupInfo));
		::ZeroMemory(&piProcessInfo, sizeof(piProcessInfo));

		siStartupInfo.cb			= sizeof(siStartupInfo);
		siStartupInfo.dwFlags		= STARTF_USESHOWWINDOW | STARTF_USESTDHANDLES;		
		siStartupInfo.wShowWindow	= SW_HIDE;
		siStartupInfo.hStdOutput	= hOutput;
		siStartupInfo.hStdError		= hErr;
		
		bSucc = CreateProcess(0,    
							  szCmd,	
							  0,
							  0,
							  FALSE,
							  0,
							  0,
							  0,
							  &siStartupInfo,
							  &piProcessInfo);

//	    _ONERR(bSucc, return -1);
    	
    	while (TRUE)
        {
			bSucc = GetExitCodeProcess(piProcessInfo.hProcess, &dwExitCode);
//			_ONERR(bSucc, return -1);

			if (dwExitCode != STILL_ACTIVE)
				break;
			else
				Sleep(50);
		}

		CloseHandle(piProcessInfo.hProcess);
		CloseHandle(hOutput);
		CloseHandle(hErr);

		switch (dwExitCode)
		{
			case 0:
				
				bSucc = DeleteFile(szCompareResFile);
//				_ONERR(bSucc, return -1);
				return 0;
				
			case 1:

				lpszEncrypted = new TCHAR[iLen];
				_tcscpy(lpszEncrypted,szEcnrypted);

				c.EncryptFile((LPTSTR)(LPCTSTR)szCompareResFile,lpszEncrypted,szKey);
				if (lpszEncrypted)
					SAFE_DELETE(lpszEncrypted);

				bSucc = MoveFile(szEcnrypted,szCompareResFile);
				_ONERR(bSucc, return -1);
				
				return 1;

			case 2:

				ATLASSERT(FALSE);
				return 2;
			
			default:
				ATLASSERT(FALSE);
				return -1;
		}

		return 0;
	}
	catch(...)
	{
		ATLASSERT(FALSE);
		return -1;
    }
}

CreateProcess returns TRUE (succeeded!) but the GetExitCodeProcess method puts 2 for dwExitCode which indicates a diff.exe failure!

I can't figure out what's wrong????

Can any1 help ?
Thanks in advanced
Yaron

Ask not what your application can do for you,
Ask what you can do for your application

Gary R. Wheeler13-Mar-05 4:22

13-Mar-05 4:22

This means that the diff.exe process ran, and returned an exit code of 2. Taking a guess, this might mean that the two files you passed to it did not compare (they didn't have the same contents).

If you've got the documentation, see what diff.exe returns for files that are identical and those that are not. You might also want to try this from the command line or a batch file, where you can test exit codes using IF ERRORLEVEL.

Software Zen: delete this;

YaronNir13-Mar-05 4:29

13-Mar-05 4:29

thanks for the quick response.

i have based my code uppon the article "RGDiff - Visual Diff Tool" by Rob Groves, you can find it here : http://www.codeproject.com/tools/rgdiff.asp[^]

the documentation says that 2 means an error occured whilst doing the diff and the err output file which i have placed (siStartupInfo.hStdError) should write the error that occured. unfortunately the error file that was created was empty....?

I still need some guidens here...you've mentioned a batch file and testing an error code, can u give an example code?

thanks again
Yaron

Ask not what your application can do for you,
Ask what you can do for your application

Gary R. Wheeler13-Mar-05 5:11

13-Mar-05 5:11

Testing with a batch file is useful when you don't have documentation for the diff.exe program.

Given that you are constructing the command line dynamically, I would first verify that the command line you are building is correct. Set a breakpoint right before the call to CreateProcess and examine the contents of the command line. If that looks correct, I would try running diff.exe from the command line with the exact text you saw in the debugger, and see what message diff.exe is displaying. In this case, it should simply output the message to the screen.

Software Zen: delete this;

YaronNir13-Mar-05 5:15

13-Mar-05 5:15

thanks for the reply.

I already did that, and running it from command line using the input params give 100% result! that is why i am so annoying. it works with a command line but it doesn't work using CreateProcess code....

help!?

Yaron

Ask not what your application can do for you,
Ask what you can do for your application

David Crow14-Mar-05 3:36

David Crow

14-Mar-05 3:36

YaronNir wrote:
szParams = " "C:\1.txt" "C:\WINDOWS\FileSafe\0017CF85-0029-0000-B9ED-DF4AD816684A\olvf.fs"
szCompareResFile ="C:\WINDOWS\FileSafe\0017CF85-0029-0000-B9ED-DF4AD816684A\cfv.fs.cr.1"

You must use double backslashes for string literals. Also, the szParams= statement has an odd number of quotation marks.

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

YaronNir14-Mar-05 6:39

urgent- how to flush output buffers in VC++

14-Mar-05 6:39

whilst using the code i did use double back slash.
the odd number of quatation marks is wrong, in my code it is even

I've manage to get this code to work. aparantly i needed some more stuff to be initialized.....

thanks again for all the help

cheers

Yaron

Ask not what your application can do for you,
Ask what you can do for your application

Member 176156313-Mar-05 3:29

Member 1761563

13-Mar-05 3:29

Hello ,
I am rohit,and I am working on a project where we are receiving sms from mobile phone to our vc++ window, but the problem is that we dont know how to flush output buffers .
The result comes correct for first time but for the next time it is wrong.
After reastarting the computer and executing the program again the answer is correct ..
I also need help on some functions like -GetInputLen()
-GetInput() etc.

So plz help me its very urgent..

Re: urgent- how to flush output buffers in VC++

Gary R. Wheeler13-Mar-05 4:25

Re: urgent- how to flush output buffers in VC++

13-Mar-05 4:25

You need to provide a little more information. Which output buffers are you trying to flush? Are the functions GetInputLen() and GetInput part of some SMS-related API?

Software Zen: delete this;

Member 176156313-Mar-05 16:06

Member 1761563

13-Mar-05 16:06

Thanks Gary,
Well I have connected a mobile phone to serial port 'com1' and am communicating with that mobile phone using 'AT' commands.When I send any AT command to that port using ToCommPort()
functio the mobile should respond with O.K. The problem is that since the buffer is not cleared ,I have to restart the P.C in order to get the correct output i.e. O.K.

The functions GetInput() and GetInputLen() are related to the serial port comm1..

regards

Rohit Deshpande-
atotalgeek@gmail.com

Re: urgent- how to flush output buffers in VC++

Member 176156314-Mar-05 0:18

Member 1761563

14-Mar-05 0:18

Rohit Deshpande-
atotalgeek@gmail.com

Messenger Addon

Kannan Ramanathan13-Mar-05 3:14

Kannan Ramanathan

13-Mar-05 3:14

I want to develop a bot plugin to Windows Messenger (not MSN Messenger!). Where do I find more info on how to go about this? Anyone know of a open source or a free tool w/source for a Messenger plugin? TIA.

Virtual Inheritancae and Mutiple Inheritance

phijophlip13-Mar-05 3:05

phijophlip

13-Mar-05 3:05

Hello Friends,

Can any tell what is the difference between "Virutal Inheritance and Multiple Inheritance" in C++. And what are the situation in which the virutal inheritance and multiple inheritance used in c++ programs.

Hoping for a reply.

Best Regards,
Phijo

YaronNir13-Mar-05 4:11

13-Mar-05 4:11

virtual inheritance is tricky.

consider class A to be a parent class. also consider A has a member int i;

then class B and class C inherites class A.

then class D inherties both B and C (multiple inheritance)

now if you create an object from D, C and B will be created in memory causing class A to be created in memory twice!!!???? (1 for B and 1 for C)

to avoid that we use the virtual inheritance.

multiple inheritance simply allow us to inherite from several classes....

hope that helped you...

Ask not what your application can do for you,
Ask what you can do for your application

Michael Dunn13-Mar-05 4:58

Michael Dunn

13-Mar-05 4:58

See the C++ FAQ Lite:
[25] Inheritance — multiple and virtual inheritance[^]

--Mike--
LINKS~! Ericahist | 1ClickPicGrabber | CP SearchBar v2.0.2 | C++ Forum FAQ
Strange things are afoot at the U+004B U+20DD

Gary R. Wheeler13-Mar-05 5:13

13-Mar-05 5:13

(thumps forehead; forgot the look-in-the-faq thing again)

Software Zen: delete this;

Gary R. Wheeler13-Mar-05 5:01