Re: Converting text to float (MFC) - C / C++ / MFC Discussion Boards

Member 166473326-Jan-05 6:39

26-Jan-05 6:39

I'm trying to convert a Ctring I read from an editbox into a float. This is the code I've got so far;

CString val, txtEdit;<br />
float boxval = 0.2f;<br />
<br />
GetDlgItemText(IDC_EDITBOX,txtEdit);<br />
char *txt = (char *) (LPCTSTR) txtEdit;  <br />
  //where txtEdit is the Ctring containing the text read from an Edit box<br />
<br />
sscanf(txt, "%f", &boxval);<br />
val.Format(_T("%f"), boxval);<br />
AfxMessageBox(val);

Unfotunately it does not return the right float. It does return a float but it is truncated to its integer value. I.e. if I enter 2.3 it returns 2.00.

Could anyone help me here? What am I doing wrong?
What's the best way to convert a string into a float?
Thanks!

Re: Converting text to float (MFC)

David Crow26-Jan-05 6:47

David Crow

26-Jan-05 6:47

How about:

GetDlgItemText(IDC_EDITBOX, txtEdit);
double d = atof(txtEdit);

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Member 166473326-Jan-05 6:56

Member 1664733

26-Jan-05 6:56

Thanks, I had tried that too but have the exact same problem!
I should prob add that it works ok with text in define in the code but not with text I read from an edit box...
Really don't understand what I'm doing wrong???

Re: Converting text to float (MFC)

David Crow26-Jan-05 7:00

David Crow

26-Jan-05 7:00

What is the value of txtEdit after the call to GetDlgItemText()?

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Member 166473326-Jan-05 7:05

Member 1664733

26-Jan-05 7:05

When I display it in a messagebox its value is the decimal value read from the edit box.

Re: Converting text to float (MFC)

David Crow26-Jan-05 7:13

David Crow

26-Jan-05 7:13

Unless there is something else going on that is not being shown, the code snippet I provided will work.

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Member 166473326-Jan-05 7:16

Member 1664733

26-Jan-05 7:16

Actually I've only just realised that only the first digit is being converted. I.e. if I enter 2.3 I get 2.00 but if I enter 14.6 I get 1.00.
I must do something really wrong somewhere but I can't see where! Sigh | :sigh:

Thanks for your help!

Re: Converting text to float (MFC)

Bob Ciora26-Jan-05 7:27

Bob Ciora

26-Jan-05 7:27

Something's definitely amiss here. If you don't make the call to GetDlgItemText but, instead, just set txtEdit to "2.334" (for example), boxval ends up being 2.334 (or whatever you ste in txtEdit). This works just fine...tested it m'self, I did.

So something's not right, and it's definitely something to do with the conditions under which GetDlgItemText is called. Maybe you're only responding to single keystrokes in the edit box, I'm not sure.

Some things to try testing:

* GetDlgItemText returns the number of characters copied. Store this returned value to an int and make sure it's returning the right number of characters.

* sscanf returns the number of arguments extracted from the string. So if your sscanf() isn't returning '1', then something's wrong.

Bob Ciora

Re: Converting text to float (MFC)

Member 166473326-Jan-05 7:49

Member 1664733

26-Jan-05 7:49

First thanks for the help! Much appreciated! Smile | :)

Here's my exact code now;

void CmySpinButtonCtrl::OnDeltapos(NMHDR* pNMHDR, LRESULT* pResult) <br />
        {<br />
	NM_UPDOWN* pNMUpDown = (NM_UPDOWN*)pNMHDR;<br />
<br />
<br />
        CString tmp, txtEdit="82.45";<br />
	float boxval;<br />
<br />
	char *txt = (char *) (LPCTSTR) txtEdit; <br />
	sscanf(txt, "%f", &boxval);<br />
	double d = atof(txt); <br />
<br />
	tmp.Format(_T("atof is %f"), d);<br />
	AfxMessageBox(tmp);<br />
	tmp.Format(_T("sscanf is %f"), boxval);<br />
	AfxMessageBox(tmp);<br />
<br />
<br />
	*pResult = 0;<br />
        }

Both Message boxes display the same value 8.0000.
This function is being called every time the spinner is clicked on.
I'm lost now! What am I doing wrong?

Re: Converting text to float (MFC)

Bob Ciora26-Jan-05 8:03

Bob Ciora

26-Jan-05 8:03

Try putting a breakpoint at the start of the function, then single step through it (with F10). Use your Watch window to watch the values of tmp, txtEdit, boxval, and d as each line is executed. Validate the values at each step, and make sure you see the following:

  (code)                                 (output)

  CString tmp, txtEdit="82.45";          // tmp = "", txtEdit = "82.45"
  float boxval;                          // boxval is undefined at this point

  char *txt = (char *)(LPCTSTR)txtEdit;  // txt = "82.45"
  sscanf(txt, "%f", &boxval);            // boxval = 82.45
  double d = atof(txt);                  // d = 82.45

  tmp.Format(_T("atof is %f", d);        // what is tmp here?
// AfxMessageBox(tmp);                   // don't need this for testing
  tmp.Format(_T("sscanf is %f", boxval); // what is tmp here?
//  AfxMessageBox(tmp);                  // single step is your friend!

Definitely a stumper, but it's definitely worth single stepping.

As a side note on programming practice, you should do the following:
const char * txt = (LPCTSTR)txtEdit; instead of your original char * txt = (char *)(LPCTSTR)txtEdit;. You may run into unintended consequences if you force a const to a non-const. It's not hurting you here, but it could bite you in bad places. I'm curious to know if you get a compiler warning from your original statement.

Bob Ciora

Re: Converting text to float (MFC)

Member 166473326-Jan-05 8:26

Member 1664733

26-Jan-05 8:26

Thanks again for your precious help!

So using the debugger I've now realised that the line char *txt = (char *)(LPCTSTR)txtEdit; is the one causing the problem. In the debbuger the value for txt is 8.00. Funny the message box was returning the right charactere when reading from the edit box.. D'Oh! | :doh:

I have tried using char * txt = (char *)(LPCTSTR)txtEdit; instead but it gives me the error cannot convert from 'const unsigned short *' to 'const char *'.

Re: Converting text to float (MFC)

Member 166473326-Jan-05 8:28

Member 1664733

26-Jan-05 8:28

Sorry tried using const char * txt = (LPCTSTR)txtEdit; and got the error! Sigh | :sigh:

Re: Converting text to float (MFC)

Bob Ciora26-Jan-05 8:59

Bob Ciora

26-Jan-05 8:59

I didn't say that was the line causing the problem Wink | ;)

I was just touching on coding practice. So have you single-stepped through the code and checked the values of the variables after each line is executed?

Bob Ciora

Re: Converting text to float (MFC)

Member 166473326-Jan-05 9:05

Member 1664733

26-Jan-05 9:05

No no, I stepped throught the code and that's where the problem is!
I've tried atof and sscanf again defining the char instead of the Cstring and they work fine! Smile | :)

All I need to do now is copy my Cstring into a char, unfortunately const char * txt = (LPCTSTR)txtEdit; doesn't work! Frown | :(

Thanks again!!! Smile | :)

Re: Converting text to float (MFC)

Bob Ciora26-Jan-05 9:21

Bob Ciora

26-Jan-05 9:21

Actually... CString has a LPCTSTR operator that will perform the conversion automatically in many cases. So:

CString sFloat = "123.45";

// This will compile without error and run successfully:
const char * szText = sFloat;

// So will this:
float boxval;
int nArgs = sscanf(sFloat, "%s", &boxval);

// As will this:
double d = atof(sFloat);

In all three cases, the compiler understands (based on the l-value in the assignment statements and the prototypes for sscanf and atof) that you're using the LPCTSTR operator for CString.

The code above will compile and run successfully, and boxval and d will be 123.45.

I have a sneaking suspicion that you've changed something elsewhere in the program, even a minor change, and it fixed the problem.

Bob Ciora

Re: Converting text to float (MFC)

Member 166473326-Jan-05 9:31

Member 1664733

26-Jan-05 9:31

CString sFloat = "123.45";
const char * szText = sFloat;

This gives me the following error;
error C2440: 'initializing' : cannot convert from 'class CString' to 'const char *'

float boxval;
int nArgs = sscanf(sFloat, "%s", &boxval);

error C2664: 'sscanf' : cannot convert parameter 1 from 'class CString' to 'const char *'

double d = atof(sFloat);

error C2664: 'atof' : cannot convert parameter 1 from 'class CString' to 'const char *'

Thank you so much!!!

Re: Converting text to float (MFC)

David Crow26-Jan-05 9:59

David Crow

26-Jan-05 9:59

There are some underlying issues here that have not been explained. Did you use AppWizard to create the project? If so, what type of project is it?

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Member 166473326-Jan-05 10:06

Member 1664733

26-Jan-05 10:06

Sorry, I'm new to all of this.

I did use AppWizard to create the project with eMbedded visual C++ 3.0 for Pocket PC 2002 application.
Shall it change anything?
Sorry to keep on bothering you all!
Thanks.

Re: Converting text to float (MFC)

David Crow26-Jan-05 10:11

David Crow

26-Jan-05 10:11

Anonymous wrote:
I did use AppWizard to create the project with eMbedded visual C++ 3.0 for Pocket PC 2002 application.

By this I assume it is not Visual Studio v6.

Anonymous wrote:
Shall it change anything?

The compiler errors you are seeing hint at MFC not being properly defined within the project. As has already been pointed out, CString has an LPCTSTR operator and for that not to work means something is wrong further upstream.

Anonymous wrote:
Sorry to keep on bothering you all!

It's definitely not a bother. But, like most crime dramas on tv, it helps to provide the detective with all pertinent information up front so that s/he can look for clues in all the right places.

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Bob Ciora26-Jan-05 10:43

Bob Ciora

26-Jan-05 10:43

Ok, you fixed the problem, so I'm done Smile | :)

Good luck with the rest of your app!

Bob Ciora

Re: Converting text to float (MFC)

David Crow26-Jan-05 8:53

David Crow

26-Jan-05 8:53

I'm not sure exactly what you are after here but converting text to double, as the subject implies, is as simple as the code snippet I provided earlier. The other code you have is definitely not necessary. You appear to be doing:

text --> double --> text

Is there a point to this exercise? If you are simply wanting to show in a message box what was typed, two lines of code will suffice:

GetDlgItemText(IDC_EDITBOX, txtEdit);
AfxMessageBox("Value is " + txtEdit);

If you need the value for calculation reasons, just call atof(txtEdit).

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Re: Converting text to float (MFC)

Tom Wright26-Jan-05 8:45

Tom Wright

26-Jan-05 8:45

Ah...again is it just me or, why don't you just set your edit box to value and float. That way you won't have to convert anything.

Tom Wright
tawright915@yahoo.com

Re: Converting text to float (MFC)

Member 166473326-Jan-05 8:53

Member 1664733

26-Jan-05 8:53

That's right but if I do that I'd have to write my function as many times as I have Edit boxes with just the name of the float variable changing.
I'd like to do something more generic. It would all work fine if I could convert a string to a float! Frown | :-(

Thanks for the help though!

CDialog Question

Anonymous26-Jan-05 5:53

Anonymous

26-Jan-05 5:53

How do I find out if a Dialog box is open?

I am trying to do a popup dialog box. When user holds down R mouse button a dialog appear and will disappear when R mouse button is release.

I am able to invoke the dialog but I am having problem terminating the dialog

Re: CDialog Question

David Crow26-Jan-05 5:59

David Crow

26-Jan-05 5:59

Anonymous wrote:
I am able to invoke the dialog but I am having problem terminating the dialog

Is it modal or modeless?

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.