Welcome to the Lounge

honey the codewitch wrote:

other platforms without memory protection

static void wav_voice_16_1_to_16_2(const voice_func_info_t& info, void*state) {
    wav_info_t* wi = (wav_info_t*)state;
    if(!wi->loop&&wi->pos>=wi->length) {
        return;
    }
    uint16_t* dst = (uint16_t*)info.buffer;
    for(int i = 0;i<info.frame_count;++i) {
        int16_t i16;
        if(wi->pos>=wi->length) {
            if(!wi->loop) {
                break;
            }
            wi->on_seek_stream(wi->start,wi->on_seek_stream_state);
            wi->pos = 0;
        }
        if(player_read16s(wi->on_read_stream,wi->on_read_stream_state,&i16)) {
            wi->pos+=2;
        } else {
            break;
        }
        uint16_t u16 = (uint16_t)((i16+32768U)*wi->amplitude);
        for(int j=0;j<info.channels;++j) {
            *dst+=u16;
            ++dst;
            // YIKES! I lost track of the loop i was in and tried
            // writing out both channels here. removing these
            // two lines fixes it:
            *dst+=u16;
            ++dst;

        }
    }
}

jmaida wrote:

Buffer overflows were and maybe still are reasons many virus attacks

jmaida wrote:

The best one can do is lot of bounds checking in one's code.

as for your situation would it make sense to run your code on a desktop/laptop in a kind of simulator of your devices w/ memory protection code so as to find any such errors ?

BernardIE5317 wrote:

co-workers who each held me in contempt not to mention the 3 owners who disliked me as they were aware i believed each of them to be insane .