|
Exactly, and your point is... ?
|
|
|
|
|
Programming by error - using an error in the normal flow of an operation. This is using the error trap is incorrect.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Welcome to the code project, what is your iternicene debate of choice today, sir?
|
|
|
|
|
Well, this has certainly been an interesting debate. What nobody has seemed to point out so far is that you actually should combine the two techniques. This is for a simple reason - while you should certainly attempt to detect the unique key violation explicitly, there is no guarantee that this alone will work. The reason for this is simple, presumably your application is going to be multi-user; well, between the time you check the uniqueness and the actual insert occurs, another user could have inputted the same values. So, you have two checks in there - one to cope with the initial check, and a try/catch to cope with the database race condition.
Simple. Job done.
|
|
|
|
|
As I responded prior, I would use TryParse rather than Try/Catch but be prepared for UnhandledExceptions
There is no one size fits all in software development and as the saying goes, they keep building better idiots.
I know the language. I've read a book. - _Madmatt
|
|
|
|
|
What does TryParse have to do with attempting to insert a duplicate key?
|
|
|
|
|
The statement is in regard to exception handling in general, which is what the debate is about, not a specific, narrow case of one type of SqlException
I know the language. I've read a book. - _Madmatt
|
|
|
|
|
Ah, thanks for clearing that up. I was a touch confused on this.
|
|
|
|
|
Pete O'Hanlon wrote: So, you have two checks in there - one to cope with the initial check, and a try/catch to cope with the database race condition.
I wouldn't do both if the exception handling is going to be necessary anyway. I see no advantage to doing that (e.g., performance would probably be better the exception route anyway). I sometimes see this strategy when dealing with multithreaded applications (e.g., you check a condition that is fast and commonly results in false, then you lock, then you check that condition again). However, I don't think that technique applies here, so I'd just go with the exception handling.
|
|
|
|
|
The reason for the first is simply that you are giving the user information up front that the item already exists. The try/catch is for the really exceptional case where there's a race condition.
|
|
|
|
|
I'd say that depends on the code/application. If the distinction between it being a race condition and it being an old duplicate key is unimportant, then I'd go with exception handling. If the race condition should be handled differently, then it makes sense to do both.
|
|
|
|
|
Pete O'Hanlon wrote: there is no guarantee that this alone will work
10!
|
|
|
|
|
Your problem is not how to deal with the error, the problem is what is the CAUSE of the error. There is no excuse for primary key violation and it is up to the developer to make sure the exception cannot arise in the normal flow of the program.
erdinc27 wrote: if the user tries to add an existing data it gives error like that
I suspect you are inserting instead of updating a record.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
|
Mycroft Holmes wrote: There is no excuse for primary key violation
You're right in that - but the OP didn't have a primary key violation he had a unique constraint violation - which is legitimate.
For example, I am adding new products each of which has a unique id (maybe a GUID or an integer) which will be the primary key.
But the product also requires a human-readable Code - which is also required to be unique.
At some point the user needs to type in the code for a new product - you can check the DB at this point, and tell them to go ahead. Meanwhile another user can try to use the same code, pass the 'does it exist' test, and attempt a commit.
Whoever gets there first will be fine, the 2nd person's commit will fail.
___________________________________________
.\\axxx
(That's an 'M')
|
|
|
|
|
_Maxxx_ wrote: he had a unique constraint violation
Ok I missed that mainly b/c I make no distinction between the 2 constraints, if that scenario existed then I would still do a select on the code field before inserting and feed the result back to the user. In the case of your new product I would return the record/info on the product entered by the first commit.
I admit there is a potential for a conflict on a really high volume system but I have yet to meet such a system.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Mycroft Holmes wrote: I admit there is a potential for a conflict on a really high volume system but I have yet to meet such a system.
Welcome to my world!
Imagine, if you will, something like a public facing web site that requires registration using a user name (rather than an email address which reduces but doesn't eliminate the problem).
___________________________________________
.\\axxx
(That's an 'M')
|
|
|
|
|
I can just about see the latency issue getting into it there, I would think even that would need to be a fairly high volume system. Have you ever tracked the number of constraint violations?
I think I'll stick to my corporate systems and stay hidden behind the firewall thank you!
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Catch it and interpret it -- which database engine?
|
|
|
|
|
hey guys thanks for all your replies
i use MsSql 2008 express..and i tried something like that
try
{
dr[j] = xnl.Item(i).ChildNodes[j].InnerText;
}
catch(SqlException ex)
{
Console.WriteLine("This Record is already exist");
}
but still on the screen it shows the same error which is shown in Sql screen
and sometimes it gives error like object reference not set to an instance of an object in that line
dr[j] = xnl.Item(i).ChildNodes[j].InnerText;
what is wrong here.i read a Xml file over website and put it in a datatable is it because it cannot connect that site ?
vemedya.com
modified on Thursday, December 9, 2010 4:20 AM
|
|
|
|
|
In this case, I'd suspect that xml.Item(i) doesn't have any child nodes, so attempting to do anything with it would cause a problem.
|
|
|
|
|
I think exception try..catch.. can only save you from this trouble.
Just use Try and Catch SqlException.
And check the detail in SqlException,If it Contains word 'UNIQUE' then you'll get sure that the exception is regarding UNIQUE Key Constrain and further more you can notify to users with a formatted message.
That's not a big deal.
|
|
|
|
|
Hiren Solanki wrote: ,If it Contains word 'UNIQUE'
And what do you do when you deploy it onto a localised version of SQL Server, say the Japanese version?
|
|
|
|
|
Hi,
how to change (override) selected (highlighted)listviewitem background color in listview control.
|
|
|
|
|
Subclass the control and handle the OnPaint method. Or use WPF and apply a template.
I know the language. I've read a book. - _Madmatt
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
