Unicode and ASCII support

Question

5.00/5 (1 vote)

See more:

Hello once again,

Today I have more "writing style" question:

When I have class, should I specify

#ifdef UNICODE
#define CClass CClassW
#else
#define CClass CClassA
#endif

and create two versions of same class?
Or rather define the data types inside the class?
Like:

#ifdef UNICODE
CMap<CString, LPCWSTR, DWORD, DWORD> m_SomeMap;
#else
CMap<CString, LPCSTR, DWORD, DWORD> m_SomeMap;
#endif

Appreciate all advices,

Thanks

Posted 10-Jul-10 12:39pm

Im2N00By

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

«_Superman_» · Accepted Answer · 2010-07-10T17:18:00

Creating different names of classes for unicode and non-unicode doesn't make sense.

It's the string data type that really matters here.
So your CMap example makes sense because it contains a character pointer.
You might as well use -
CMap<CString, LPCTSTR, DWORD, DWORD> m_SomeMap;

LPCTSTR translates to LPCSTR or LPCWSTR depending on whether UNICODE is defined or not.

I would personally recommend always using the wide version of strings because Windows internally uses these and also because you're going to need them somewhere sometime.