that code in c++ not run and i don't know the result and i need help

Question

1.00/5 (1 vote)

See more:

#include >iostream.h>
#include >conio.h>
struct student
{
char name[20];
int score;
char grade;
struct student* next;
};
typedef struct student student;
student* head,*current;
void main()
{
cout<<"enter std data \n";
cout<<"\n enter std name";
cin>>head->name;
cout<<"\n enter std grade";
cin>>head->grade;
head->next=Null;
cout<<"Do you want continue Y||N\t";
cin>>ans;
if(ans=='y')||(ans=='Y')
head->next=(student*);
malloc(sizeof(student));
void fillnode(struct student *w)
{
cout<<"\n enter std name";
cin>>w->name;
cout<<"\n enter std score";
cin>>w->score;
cout<<"\n enter std grade";
cin>>w->grade;
w->next=Null;
}
void createlist(struct student* head)
{
struct student*new=Null;
struct student*current=Null;
new=(student*)malloc(sizeof(student));
head=new;
current=new;
fillnode(head);
cout<<"do you want continue Y||N"

cin>.ans;

if(ans=='y')||(ans=='y')
{
if(___________)
{
do
new=(student*)malloc(sizeof(student));
current->next=new;
fillnode(new);
current=new;
cout<<"do you want to continue Y||N";
cin>>ans;
while(ans=='Y'||ans=='y')
}}
void printlist(student *h)
{
while(h!=Null)
{
cout<<"the name is"<<h->name;
cout<<"the score is"<<h->score;
cout<<"the grade is"<<h->grade;
h=h->next;
}
}

Posted 29-Jun-10 7:24am

mks_137

Updated 29-Jun-10 9:26am

Aescleal

v4

Add a Solution

Comments

Kristian Sixhøj 29-Jun-10 13:32pm

Reason for my vote of 1
"This code does not work, why?" is basically what you're asking. You need to provide more information and phrase your question better.

Aescleal 29-Jun-10 15:30pm

I get the fact that you're still learning, but what you're writing is not particularly idiomatic C++ - it looks like C to me apart from the token uses of pre-standardisation IOStreams. If someone's charging you money for a C++ course based on this I'd suggest asking for a refund. If you're learning from a book then it's doing you no favours with it's teaching method. Chuck the book away and buy a copy of "Programming -- Principles and Practice Using C++" by Bjarne Stroustrup instead, it's well worth the money.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2010-06-29T07:48:00

Solution 1

This line is suspect:

cin>.ans;

Posted 29-Jun-10 7:48am

#realJSOP

Comments

[no name] 29-Jun-10 14:25pm

thank u mr.simmons
is that is a only false in the code ???
because I am still a student

[no name] 29-Jun-10 14:25pm

Reason for my vote of 5
good

Niklas L · Answer 2 · 2010-06-29T08:50:00

I suppose you have to fill in something here:

if(___________)

Your first two includes needs to be corrected, using:

#include <file name here>

Edit: Lots of nice stuff

if(ans=='y')||(ans=='Y')
head->next=(student*);
malloc(sizeof(student));

Read up on how if-statements are to be written. The last malloc is dangling since it's preceded by a semi-colon.

Look at what the compiler tells you. Check each line in the error report, and compare to your literature and you will learn a lot faster.

William Winner · Answer 3 · 2010-06-29T11:36:00

To add to this:

You open your Main, but never close it before starting a new method:

C

malloc(sizeof(student));
void fillnode(struct student *w)
{

C

if(ans=='y')||(ans=='y')

That is checking for the same things

When you do this:

C

head=new;
current=new;

you lose all reference to the actual head of the list since each student just contains a reference to the Next student, not the previous.

and, once again, you don't close off a method before starting a new one:

C

if(ans=='y')||(ans=='y')
{
if(___________)
{
do
//stuff
while(ans=='Y'||ans=='y')
}}
void printlist(student *h)

You're clearly floundering. You need to outline the different steps to begin with...as in
1.) Read in first student
2.) Ask if they want to continue
3.) Continue reading until they don't want to continue

Then, break that down into steps and code it out instead of just writing without having any clue what you're trying to do.

that code in c++ not run and i don't know the result and i need help

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0