C# throwing exceptions throws another exception

Question

0.00/5 (No votes)

See more:

Im having a exception throwing problem with my program which works with a access database through OleDB connection.
Here is my function which causes the error.

C++

public static string getNICByID(int ID)
        {
            //validation params
            if (ID <= 0)
                throw new Exception("Invalid ID");
            //if (!isRegNumExists(ID))
            //    throw new Exception("No records");


            const string query = @"select NICNumber from Student where StudentRegNo = @_regNum";

            try
            {
                using (OleDbConnection con = new OleDbConnection(conString))
                {
                    con.Open();

                    using (OleDbCommand cmd = new OleDbCommand(query, con))
                    {
                        cmd.Parameters.Add("@_regNum", OleDbType.Integer).Value = ID;

                        object obj = cmd.ExecuteScalar();
                        if (obj != null)
                            return obj.ToString();
                        else
                            throw new Exception("No records");
                    }
                }
            }
            catch { throw; }

This functions works fine and returns what I want if the data table contains a record with respect to the ID. But if the table doesnt contain a record it throws another exception like the picture below.

http://s7.postimg.org/w4j72ie8b/Untitled.png[^]

What's the wrong with my code ?

Thanks in advance.

Posted 5-Mar-15 21:53pm

Mark

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Afzaal Ahmad Zeeshan · Answer 1 · 2015-03-05T22:19:00

That is because you, yourself, personally are throwing this exception in your code when there is no record found in the database.

C#

if (obj != null)
     return obj.ToString();
else
     throw new Exception("No records");

This line of code is intended to do what you're seeing. It will see, if there is any record, ortherwise throw the exception; with the parameter as the reason or Message.

To ignore the exception being raised, please remove this line,

C#

throw new Exception("No records");

Then it won't throw the exception, instead you can show a message pop up to the user with this value.

Joan Magnet · Answer 2 · 2015-03-05T23:29:00

Solution 2

You're throwing the Excetion again in your catch() section.

try
{
    // your code
    throw New Exception ("no recors")
}
catch (throw)  
catch (Exception ex)
{
    MessageBox.Show(ex.Message);
}

Posted 5-Mar-15 23:29pm

Joan Magnet

Simon_Whale · Answer 3 · 2015-03-06T00:21:00

The other two answers are showing you what is going on. What I would do is

change your try catch block to

C#

try
{
   if (obj != null)
       return obj.ToString();
   else
       throw new Exception("No records");
}
catch(Exception ex)
{
  //put a break point on this line below
  String message = ex.message;
}

I would put a breakpoint on the string message line and then while debugging check the ex.message as it will show you that the error message should be "No Records"

I personally would also change your exception to something more appropriate such as SQLExcpetion rather than the catch all Exception

C# throwing exceptions throws another exception

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0