Create seperate files

Question

1.00/5 (2 votes)

See more:

Hi everybody,

I have this:

C#

static void Main(string[] args)
    {


        const int linesPerFile = 10;
        const string destinationFileName = @"G:\Folder\File-Part-{0}.txt";
        //string fileName = "File";






            var fileCounter = 0;
            var destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter + 1));
            try
            {

                // foreach (var bank in BankAcoutNumbers.BANS.Take(100))
                //{
                var lineCounter = 0;
                string line;

                while ((line = destiNationFile.NewLine) != null)
                {
                    foreach (var bank in BankAcoutNumbers.BANS.Take(200))
                    {
                        if (lineCounter >= linesPerFile)
                        {
                            lineCounter = 0;
                            fileCounter++;
                            destiNationFile.Dispose();
                            destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter + 1));

                        }

                        destiNationFile.WriteLine(bank);
                        lineCounter++;
                    }
                    //}


                }
            }
            catch (Exception)
            {

                throw;
            }



        // Keep the console window open in debug mode.
        System.Console.WriteLine("Press any key to exit.");
        System.Console.ReadKey();
    }

But the problem is it creates endless files. Not 20 files - what it has to be.

Thank you

I have it now like this:

C#

static void Main(string[] args)
    {


        const int linesPerFile = 10;
        const string destinationFileName = @"G:\Folder\File-Part-{0}.txt";
        //string fileName = "File";
        var maxNumberOfFiles = 10;
        Stopwatch timer = new Stopwatch();



            var fileCounter = 0;

            var destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter + 1));
            try
            {

                // foreach (var bank in BankAcoutNumbers.BANS.Take(100))
                //{
                var lineCounter = 0;
                string line;

                while (fileCounter <= maxNumberOfFiles)
                {
                    timer.Start();
                    foreach (var bank in BankAcoutNumbers.BANS.Take(100))
                    {
                        if (lineCounter % linesPerFile == 0)
                        {
                            //lineCounter = 0;
                            destiNationFile.Flush();
                            destiNationFile.Dispose();
                            destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter + 1));
                            fileCounter++;
                        }

                        destiNationFile.WriteLine(bank);
                        lineCounter++;

                    }

                    fileCounter++;

                    //}


                }
                timer.Stop();
                Console.WriteLine(timer.Elapsed.Seconds);
            }
            catch (Exception)
            {

                throw;
            }



        // Keep the console window open in debug mode.

        System.Console.WriteLine("Press any key to exit.");
        System.Console.ReadKey();
    }

But I get ten fiels, so that is correct 10*10. But the problem is that every time the tinth file is empty

Posted 20-Jan-15 1:26am

Member 10225052

Updated 20-Jan-15 2:37am

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Arian Celina · Accepted Answer · 2015-01-20T01:41:00

Solution 2

The problem is with your while loop condition, it never gets to false so never stops

You should put something that eventually evaluates to false, something like

C#

var maxNumberOfFiles= 20

while (fileCounter < maxNumberOfFiles) {

//your code here

fileCounter++;

}

Posted 20-Jan-15 1:41am

Arian Celina

Nathan Minier · Accepted Answer · 2015-01-20T01:37:00

That's becuase you have an assignment operation as your sentinel, and assignments always return true. Assignments in sentinals are a giant anti-pattern

I suspect you're trying to do this:

C#

var fileCounter = 1;
var lineCounter = 0
var destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter));
foreach(var bank in BankAcoutNumbers.BANS.Take(200))
{
    if(lineCounter % linesPerFile == 0)
    {
        destiNationFile.Flush();
        destiNationFile.Dispose();
        destiNationFile = new StreamWriter(string.Format(destinationFileName, fileCounter));
        fileCounter++;
    } 
    destiNationFile.WriteLine(bank);
    lineCounter++;
}

Oh, and then you dispose of it in the loop, which is bad juju since your break condition now no longer exists in memory. Use a recursive function for this, not a while loop.

The while loop looks to be meaningless, so here's a more concise copy.