c# - How do I solve syntax error in from clause

Question

3.00/5 (3 votes)

See more:

MY CODE IS :

VB

string query="select DISPATCH.Bill_No, NWTHAN.Quality, NWTHAN.Than_No, NWTHAN.Length, NWTHAN.Weight, NWTHAN.Tobaleno "+
                           "from DISPATCH , BALES , NWTHAN"+
                           "where DISPATCH.Bill_no='" + comboBox1.SelectedValue.ToString() + "' and BALES.Bill_No=DISPATCH.Bill_no and NWTHAN.Tobaleno=BALES.Bale_No" +
                            "order by NWTHAN.Than_No";

HELP ME !!!

Posted 4-Jan-15 22:07pm

Member 10231328

Add a Solution

Comments

Arjsrya 5-Jan-15 4:17am

Why don't you try store procedure?Did you debug the code?Does it frame the correct sql syntax?

Tomas Takac 5-Jan-15 4:21am

Have a look on what's actually in query, then it will be much clearer. If it's not, try to run the statement directly (in SSMS perhaps?).

4 solutions

Solution 3

1.The first error that I saw is that you forgot to let a space before to add "WHERE" clause, ans also before "order by".

2.So you should change your SQL like this:

C#

string query="select DISPATCH.Bill_No, NWTHAN.Quality, NWTHAN.Than_No, NWTHAN.Length, NWTHAN.Weight, NWTHAN.Tobaleno "+
                           "from DISPATCH , BALES , NWTHAN "+ //Here was the problem!
                           "where DISPATCH.Bill_no='" + comboBox1.SelectedValue.ToString() + "' and BALES.Bill_No=DISPATCH.Bill_no and NWTHAN.Tobaleno=BALES.Bale_No " //Also here a similar problem! 
                            +"order by NWTHAN.Than_No";

Posted 4-Jan-15 22:26pm

Raul Iloc

Solution 4

SQL

string query = @"select DISPATCH.Bill_No, NWTHAN.Quality, NWTHAN.Than_No, NWTHAN.Length, NWTHAN.Weight, NWTHAN.Tobaleno
                           from DISPATCH , BALES , NWTHAN
                           where DISPATCH.Bill_no= " + comboBox1.SelectedValue.ToString() + " and BALES.Bill_No=DISPATCH.Bill_no and NWTHAN.Tobaleno=BALES.Bale_No order by NWTHAN.Than_No";

Posted 4-Jan-15 22:35pm

Mukesh.Ce62

Solution 5

VB

string query="select DISPATCH.Bill_No, NWTHAN.Quality, NWTHAN.Than_No, NWTHAN.Length, NWTHAN.Weight, NWTHAN.Tobaleno "+
                           "from DISPATCH , BALES , NWTHAN"+
                           " where DISPATCH.Bill_no='" + comboBox1.SelectedValue.ToString() + "' and BALES.Bill_No=DISPATCH.Bill_no and NWTHAN.Tobaleno=BALES.Bale_No" +
                            " order by NWTHAN.Than_No";

just add space before where and order by clause. your query will run fine.

Posted 4-Jan-15 22:45pm

Ainy Mughal

Updated 4-Jan-15 23:29pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2015-01-04T22:24:00

You have two problems:
1. Your code is wide open to SQL injection...Never use string concatenation to create queries, use parametrized queries!
2. You do not add spaces between the parts of the query...
This:

C#

"from DISPATCH , BALES , NWTHAN"+
"where DISPATCH.Bill_no='"

Is equal to his:

C#

"from DISPATCH , BALES , NWTHANwhere DISPATCH.Bill_no='"

As you can see no space between the last able and the where...
You have the very same at the order by...