view is returning Null value for List to the controller in mvc4

Question

0.00/5 (No votes)

See more:

In post my view model is returning NUll value for List OrderDetail ProductName,Price,Quantity but for customerID and NetPrice are returning the value from view..
In my View CustomerOrder and OrderDetail.The OrderDetail is given us a list in Customer Detail.

public class CustomerOrder
{
public int CustomerId { get; set; }
public int NetPrice { get; set; }
public List<orderdetail> Orderlist { get; set; }
public CustomerOrder()
{
Orderlist = new List<orderdetail>();
}
}
public class OrderDetail
{
public string ProductName { get; set; }
public int Quantity { get; set; }
public int Price { get; set; }
public int TotalPrice { get { return Price * Quantity; } }
}

This is my View , I have used foreach for the List

@model MvcCustomerOrderClass4g.Models.CustomerOrder
@{
ViewBag.Title = "CustomerOrder";
}

CustomerOrder

@using (Html.BeginForm(FormMethod.Post))
{

CustomerOrder

@Html.LabelFor(model => model.CustomerId)

@Html.EditorFor(model => model.CustomerId)
@Html.ValidationMessageFor(model => model.CustomerId)

@Html.LabelFor(model => model.NetPrice)

@Html.EditorFor(model => model.NetPrice)

@foreach(var extra in Model.Orderlist)
{

@Html.LabelFor(model =>extra.ProductName)

@Html.TextBoxFor(model=>extra.ProductName)

@Html.LabelFor(model => extra.Quantity)

@Html.TextBoxFor(model=>extra.Quantity)

@Html.LabelFor(model => extra.TotalPrice)

@Html.TextBoxFor(model=>extra.TotalPrice)

}

}
@{
if (ViewData["result"] != "" && ViewData["result"] != null)
{
<script type="text/javascript" lang="javascript">
alert("Data saved Successfully");
</script>
}
}

This is my Controller. In httppost is returning count 0 in orderlist

public class CustomerOrderController : Controller
{

public ActionResult CustomerOrder()
{
CustomerOrder model = new Models.CustomerOrder();

OrderDetail dr = new Models.OrderDetail();
dr.ProductName = "1";
dr.Quantity = 1;
dr.Price = 1;
model.Orderlist.Add(dr);
return View(model);

}
[HttpPost]
public ActionResult CustomerOrder(CustomerOrder SelectedOrder)
{
DataBase dataBase = new DataBase();
var result = dataBase.InsertData(SelectedOrder);
ViewData["result"] = result;
return View();
}

}

DataBase.cs
File is connected to the database to insert value in the Product Name is showing Null Value in return

public class DataBase
{
int OrderID = 0;
int result2 = 0;
int result = 0;
public int InsertData(CustomerOrder SelectOrder)
{
using (SqlConnection connection = new SqlConnection(ConfigurationManager.ConnectionStrings["MyConnection"].ConnectionString))
{
using (SqlCommand command = new SqlCommand("INSERT INTO Orders(CustomerID,TotalPrice) VALUES(@CustomerID,@TotalPrice)" + " SELECT SCOPE_IDENTITY()", connection))
{
command.Parameters.AddWithValue("@CustomerID", SelectOrder.CustomerId);
command.Parameters.AddWithValue("@TotalPrice", SelectOrder.NetPrice);
connection.Open();
command.CommandType = CommandType.Text;
int OrderID = Convert.ToInt32(command.ExecuteScalar());
result = command.ExecuteNonQuery();

// List<orderdetail> OrderList = new List<orderdetail>();
OrderDetail customerSelectedOrder = new OrderDetail();

var ProductName = customerSelectedOrder.ProductName;
var Price = customerSelectedOrder.Price;
var Quantity = customerSelectedOrder.Quantity;
var totalPrice = customerSelectedOrder.TotalPrice;
using (SqlCommand Command = new SqlCommand("INSERT INTO OrderDetails(OrderID,ProductName,Price,Quantity,TotalPrice) VALUES('" + OrderID + "',@ProductName,@Quantity,@Price,@TotalPrice)", connection))
{
Command.Parameters.AddWithValue("@ProductName", ProductName);
Command.Parameters.AddWithValue("@Quantity", Price);
Command.Parameters.AddWithValue("@Price", Quantity);
Command.Parameters.AddWithValue("@TotalPrice", totalPrice);
Command.CommandType = CommandType.Text;
result2 = Command.ExecuteNonQuery();
}
}
}
return result2;
}}

How to return value from view from two model I Created, Is there any other way to get values for the list from the view

Posted 25-Nov-14 1:07am

Member 11166907

Updated 25-Nov-14 1:15am

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nathan Minier · Accepted Answer · 2014-11-25T02:59:00

You have a couple structure issues in the code IMO, but this issue is being cause by the following:

C#

@foreach(var extra in Model.Orderlist)
{

@Html.LabelFor(model =>extra.ProductName)
@Html.TextBoxFor(model=>extra.ProductName)
@Html.LabelFor(model => extra.Quantity)
@Html.TextBoxFor(model=>extra.Quantity)
@Html.LabelFor(model => extra.TotalPrice)
@Html.TextBoxFor(model=>extra.TotalPrice)
}

You lambda expressions and iterator are wrong, so the orderlist is empty. Try this:

C#

@for(var i = 0; i < Model.OrderList.Count(); i++)
{

@Html.LabelFor(model =>model.OrderList[i].ProductName)
@Html.TextBoxFor(model=> model.OrderList[i].ProductName)
@Html.LabelFor(model => model.OrderList[i].Quantity)
@Html.TextBoxFor(model=> model.OrderList[i].Quantity)
@Html.LabelFor(model => model.OrderList[i].TotalPrice)
@Html.TextBoxFor(model=> model.OrderList[i].TotalPrice)
}